Completed
Pull Request — master (#5)
by Tim
02:21
created

AttributeOptionValueUpdateObserver   A

Complexity

Total Complexity 3

Size/Duplication

Total Lines 41
Duplicated Lines 100 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 0
Metric Value
wmc 3
lcom 1
cbo 2
dl 41
loc 41
c 0
b 0
f 0
rs 10

2 Methods

Rating   Name   Duplication   Size   Complexity  
A initializeAttribute() 16 16 2
A loadAttributeOptionValueByAttributeCodeAndStoreIdAndValue() 4 4 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
/**
4
 * TechDivision\Import\Attribute\Observers\AttributeOptionValueUpdateObserver
5
 *
6
 * NOTICE OF LICENSE
7
 *
8
 * This source file is subject to the Open Software License (OSL 3.0)
9
 * that is available through the world-wide-web at this URL:
10
 * http://opensource.org/licenses/osl-3.0.php
11
 *
12
 * PHP version 5
13
 *
14
 * @author    Tim Wagner <[email protected]>
15
 * @copyright 2016 TechDivision GmbH <[email protected]>
16
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
17
 * @link      https://github.com/techdivision/import-attribute
18
 * @link      http://www.techdivision.com
19
 */
20
21
namespace TechDivision\Import\Attribute\Observers;
22
23
use TechDivision\Import\Utils\StoreViewCodes;
24
use TechDivision\Import\Attribute\Utils\ColumnKeys;
25
26
/**
27
 * Observer that update's the attribute option values found in the additional CSV file.
28
 *
29
 * @author    Tim Wagner <[email protected]>
30
 * @copyright 2016 TechDivision GmbH <[email protected]>
31
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
32
 * @link      https://github.com/techdivision/import-attribute
33
 * @link      http://www.techdivision.com
34
 */
35 View Code Duplication
class AttributeOptionValueUpdateObserver extends AttributeOptionValueObserver
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
36
{
37
38
    /**
39
     * Initialize the EAV attribute option value with the passed attributes and returns an instance.
40
     *
41
     * @param array $attr The EAV attribute option value attributes
42
     *
43
     * @return array The initialized EAV attribute option value
44
     */
45
    protected function initializeAttribute(array $attr)
46
    {
47
48
        // initialize the data to load the EAV attribute option
49
        $value = $this->getValue(ColumnKeys::VALUE);
50
        $storeId = $this->getRowStoreId(StoreViewCodes::ADMIN);
0 ignored issues
show
Bug introduced by
The method getRowStoreId() does not exist on TechDivision\Import\Attr...tionValueUpdateObserver. Did you maybe mean getRow()?

This check marks calls to methods that do not seem to exist on an object.

This is most likely the result of a method being renamed without all references to it being renamed likewise.

Loading history...
51
        $attributeCode = $this->getValue(ColumnKeys::ATTRIBUTE_CODE);
52
53
        // try to load the EAV attribute option value
54
        if ($attributeOptionValue = $this->loadAttributeOptionValueByAttributeCodeAndStoreIdAndValue($attributeCode, $storeId, $value)) {
55
            return $this->mergeEntity($attributeOptionValue, $attr);
56
        }
57
58
        // simply return the attributes
59
        return $attr;
60
    }
61
62
    /**
63
     * Load's and return's the EAV attribute option value with the passed code, store ID and value.
64
     *
65
     * @param string  $attributeCode The code of the EAV attribute option to load
66
     * @param integer $storeId       The store ID of the attribute option to load
67
     * @param string  $value         The value of the attribute option to load
68
     *
69
     * @return array The EAV attribute option value
70
     */
71
    protected function loadAttributeOptionValueByAttributeCodeAndStoreIdAndValue($attributeCode, $storeId, $value)
72
    {
73
        return $this->getAttributeBunchProcessor()->loadAttributeOptionValueByAttributeCodeAndStoreIdAndValue($attributeCode, $storeId, $value);
74
    }
75
}
76