EavAttributeSetCreateProcessor - Code Metrics - Inspection of "Merge pull request #1 from wagnert/master" - techdivision/import-attribute-set - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d3602f...354389 )

by Tim

created 2019-01-07 15:30 UTC

EavAttributeSetCreateProcessor A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	2
eloc	5
dl	0
loc	30
ccs	0
cts	10
cp	0
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getStatements()	0	6	1
A	execute()	0	4	1

<?php

/**
 * TechDivision\Import\Attribute\Set\Actions\Processors\EavAttributeSetCreateProcessor
 *
 * NOTICE OF LICENSE
 *
 * This source file is subject to the Open Software License (OSL 3.0)
 * that is available through the world-wide-web at this URL:
 * http://opensource.org/licenses/osl-3.0.php
 *
 * PHP version 5
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2019 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/techdivision/import-attribute-set
 * @link      http://www.techdivision.com
 */

namespace TechDivision\Import\Attribute\Set\Actions\Processors;

use TechDivision\Import\Attribute\Set\Utils\SqlStatementKeys;
use TechDivision\Import\Actions\Processors\AbstractCreateProcessor;

/**
 * The EAV attribute set create processor implementation.
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2019 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/techdivision/import-attribute-set
 * @link      http://www.techdivision.com
 */
class EavAttributeSetCreateProcessor extends AbstractCreateProcessor
{

    /**
     * Return's the array with the SQL statements that has to be prepared.
     *
     * @return array The SQL statements to be prepared
     * @see \TechDivision\Import\Actions\Processors\AbstractBaseProcessor::getStatements()
     */
    protected function getStatements()
    {

        // return the array with the SQL statements that has to be prepared
        return array(
            SqlStatementKeys::CREATE_ATTRIBUTE_SET => $this->loadStatement(SqlStatementKeys::CREATE_ATTRIBUTE_SET)
        );
    }

    /**
     * Persist's the passed row.
     *
     * @param array       $row  The row to persist
     * @param string|null $name The name of the prepared statement that has to be executed
     *
     * @return string The last inserted ID
     */
    public function execute($row, $name = null)
    {
        parent::execute($row, $name);
        return $this->getConnection()->lastInsertId();
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1			<?php
2
3			/**
4			* TechDivision\Import\Attribute\Set\Actions\Processors\EavAttributeSetCreateProcessor
5			*
6			* NOTICE OF LICENSE
7			*
8			* This source file is subject to the Open Software License (OSL 3.0)
9			* that is available through the world-wide-web at this URL:
10			* http://opensource.org/licenses/osl-3.0.php
11			*
12			* PHP version 5
13			*
14			* @author Tim Wagner <[email protected]>
15			* @copyright 2019 TechDivision GmbH <[email protected]>
16			* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
17			* @link https://github.com/techdivision/import-attribute-set
18			* @link http://www.techdivision.com
19			*/
20
21			namespace TechDivision\Import\Attribute\Set\Actions\Processors;
22
23			use TechDivision\Import\Attribute\Set\Utils\SqlStatementKeys;
24			use TechDivision\Import\Actions\Processors\AbstractCreateProcessor;
25
26			/**
27			* The EAV attribute set create processor implementation.
28			*
29			* @author Tim Wagner <[email protected]>
30			* @copyright 2019 TechDivision GmbH <[email protected]>
31			* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
32			* @link https://github.com/techdivision/import-attribute-set
33			* @link http://www.techdivision.com
34			*/
35			class EavAttributeSetCreateProcessor extends AbstractCreateProcessor
36			{
37
38			/**
39			* Return's the array with the SQL statements that has to be prepared.
40			*
41			* @return array The SQL statements to be prepared
42			* @see \TechDivision\Import\Actions\Processors\AbstractBaseProcessor::getStatements()
43			*/
44			protected function getStatements()
45			{
46
47			// return the array with the SQL statements that has to be prepared
48			return array(
49			SqlStatementKeys::CREATE_ATTRIBUTE_SET => $this->loadStatement(SqlStatementKeys::CREATE_ATTRIBUTE_SET)
50			);
51			}
52
53			/**
54			* Persist's the passed row.
55			*
56			* @param array $row The row to persist
57			* @param string\|null $name The name of the prepared statement that has to be executed
58			*
59			* @return string The last inserted ID
60			*/
61			public function execute($row, $name = null)
62			{
63			parent::execute($row, $name);
64			return $this->getConnection()->lastInsertId();
			0 ignored issues – show Bug Best Practice introduced 2019-01-04 21:23 UTC by Report Bug Copy Issue Report The expression `return $this->getConnection()->lastInsertId()` returns the type `string` which is incompatible with the return type mandated by `TechDivision\Import\Acti...sorInterface::execute()` of `void`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
65			}
66			}
67

techdivision / import-attribute-set

Push — master ( d3602f...354389 )

EavAttributeSetCreateProcessor A

Complexity

Size/Duplication

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like