Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 19 | View Code Duplication | final class PartParamHandler extends AbstractParameterHandler |
|
| 20 | { |
||
| 21 | /** |
||
| 22 | * @var RequestBodyConverter |
||
| 23 | */ |
||
| 24 | private $converter; |
||
| 25 | |||
| 26 | /** |
||
| 27 | * @var string |
||
| 28 | */ |
||
| 29 | private $name; |
||
| 30 | |||
| 31 | /** |
||
| 32 | * @var string |
||
| 33 | */ |
||
| 34 | private $encoding; |
||
| 35 | |||
| 36 | /** |
||
| 37 | * Constructor |
||
| 38 | * |
||
| 39 | * @param RequestBodyConverter $converter |
||
| 40 | * @param string $name |
||
| 41 | * @param string $encoding |
||
| 42 | */ |
||
| 43 | 6 | public function __construct(RequestBodyConverter $converter, string $name, string $encoding) |
|
| 49 | |||
| 50 | /** |
||
| 51 | * Set a value to the [@see RequestBuilder] for parameter type |
||
| 52 | * |
||
| 53 | * @param RequestBuilder $requestBuilder |
||
| 54 | * @param mixed $value |
||
| 55 | * @return void |
||
| 56 | */ |
||
| 57 | 4 | public function apply(RequestBuilder $requestBuilder, $value): void |
|
| 61 | } |
||
| 62 |