ArrayPrinter::__construct() - Code Metrics - Inspection of "Refactoring generation handlers" - tebru/retrofit-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (972ca0)

by Nate

created 2016-04-14 23:27 UTC

ArrayPrinter::__construct() A

↳ Parent: ArrayPrinter

Complexity

Conditions	3
Paths	4

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	13
rs	9.4285
cc	3
eloc	7
nc	4
nop	2

<?php
/*
 * Copyright (c) 2015 Nate Brunette.
 * Distributed under the MIT License (http://opensource.org/licenses/MIT)
 */

namespace Tebru\Retrofit\Generation\Printer;

use PhpParser\Lexer;
use PhpParser\Parser;
use PhpParser\PrettyPrinter\Standard;
use PhpParser\PrettyPrinterAbstract;

/**
 * Class ArrayPrinter
 *
 * @author Nate Brunette <[email protected]>
 */
class ArrayPrinter
{
    /**
     * @var Parser
     */
    private $parser;

    /**
     * @var PrettyPrinterAbstract
     */
    private $printer;

    /**
     * Constructor
     *
     * @param Parser $parser
     * @param PrettyPrinterAbstract $printer
     */
    public function __construct(Parser $parser = null, PrettyPrinterAbstract $printer = null)
    {
        if (null === $parser) {
            $parser = new Parser(new Lexer());
        }

        if (null === $printer) {
            $printer = new Standard();
        }

        $this->parser = $parser;
        $this->printer = $printer;
    }

    /**
     * Take a PHP array and convert it to a string
     *
     * @param array $array
     * @return string
     */
    public function printArray(array $array)
    {
        $string = var_export($array, true);
        $string = preg_replace('/\'\$(.+)\'/', '$' . '\\1', $string);

        $statements = $this->parser->parse($string);

        return $this->printer->prettyPrintFile($statements);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }
}


1			<?php
2			/*
3			* Copyright (c) 2015 Nate Brunette.
4			* Distributed under the MIT License (http://opensource.org/licenses/MIT)
5			*/
6
7			namespace Tebru\Retrofit\Generation\Printer;
8
9			use PhpParser\Lexer;
10			use PhpParser\Parser;
11			use PhpParser\PrettyPrinter\Standard;
12			use PhpParser\PrettyPrinterAbstract;
13
14			/**
15			* Class ArrayPrinter
16			*
17			* @author Nate Brunette <[email protected]>
18			*/
19			class ArrayPrinter
20			{
21			/**
22			* @var Parser
23			*/
24			private $parser;
25
26			/**
27			* @var PrettyPrinterAbstract
28			*/
29			private $printer;
30
31			/**
32			* Constructor
33			*
34			* @param Parser $parser
35			* @param PrettyPrinterAbstract $printer
36			*/
37			public function __construct(Parser $parser = null, PrettyPrinterAbstract $printer = null)
38			{
39			if (null === $parser) {
40			$parser = new Parser(new Lexer());
41			}
42
43			if (null === $printer) {
44			$printer = new Standard();
45			}
46
47			$this->parser = $parser;
48			$this->printer = $printer;
49			}
50
51			/**
52			* Take a PHP array and convert it to a string
53			*
54			* @param array $array
55			* @return string
56			*/
57			public function printArray(array $array)
58			{
59			$string = var_export($array, true);
60			$string = preg_replace('/\'\$(.+)\'/', '$' . '\\1', $string);
61
62			$statements = $this->parser->parse($string);
63
64			return $this->printer->prettyPrintFile($statements);
			0 ignored issues – show Bug introduced 2016-04-14 23:29 UTC by Report Bug Copy Issue Report It seems like `$statements` defined by `$this->parser->parse($string)` on line `62` can also be of type `null`; however, `PhpParser\PrettyPrinterAbstract::prettyPrintFile()` does only seem to accept `array<integer,object<PhpParser\Node>>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
65			}
66			}
67

tebru / retrofit-php

Branch — develop (972ca0)

ArrayPrinter::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like