ArrayTypeAdapter::read() - Code Metrics - Inspection of "v0.7 Branch" - tebru/gson-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — master (#44)

by Nate
created 2019-10-16 18:40 UTC
ArrayTypeAdapter::read() C

↳ Parent: ArrayTypeAdapter
Complexity

Conditions	17
Paths	16
Size

Total Lines	85
Code Lines	49
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	47
CRAP Score	17
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
cc	17
eloc	49
c	1
b	0
f	0
nc	16
nop	1
dl	0
loc	85
ccs	47
cts	47
cp	1
crap	17
rs	5.2166
How to fix Long Method Complexity

<?php
/*
 * Copyright (c) Nate Brunette.
 * Distributed under the MIT License (http://opensource.org/licenses/MIT)
 */

declare(strict_types=1);

namespace Tebru\Gson;

use LogicException;
use stdClass;
use Tebru\Gson\Exception\JsonSyntaxException;
use Tebru\Gson\Internal\TypeAdapterProvider;
use Tebru\PhpType\TypeToken;

/**
 * Class ArrayTypeAdapter
 *
 * @author Nate Brunette <[email protected]>
 */
class ArrayTypeAdapter extends TypeAdapter
{
    /**
     * @var TypeAdapterProvider
     */
    private $typeAdapterProvider;

    /**
     * @var TypeToken
     */
    private $keyType;

    /**
     * @var TypeAdapter
     */
    private $valueTypeAdapter;

    /**
     * @var int
     */
    private $numberOfGenerics;

    /**
     * Constructor
     *
     * @param TypeAdapterProvider $typeAdapterProvider
     * @param TypeToken $keyType
     * @param TypeAdapter $valueTypeAdapter
     * @param int $numberOfGenerics
     */
    public function __construct(
        TypeAdapterProvider $typeAdapterProvider,
        TypeToken $keyType,
        TypeAdapter $valueTypeAdapter,
        int $numberOfGenerics
    ) {
        $this->typeAdapterProvider = $typeAdapterProvider;
        $this->keyType = $keyType;
        $this->valueTypeAdapter = $valueTypeAdapter;
        $this->numberOfGenerics = $numberOfGenerics;
    }

    /**
     * Read the next value, convert it to its type and return it
     *
     * @param JsonReadable $reader
     * @return array|null
     * @throws \LogicException
     * @throws \Tebru\Gson\Exception\JsonSyntaxException If trying to read from non object/array
     */
    public function read(JsonReadable $reader): ?array
    {
        $token = $reader->peek();
        if ($token === JsonToken::NULL) {
            $reader->nextNull();
            return null;
        }

        $array = [];

        if ($this->numberOfGenerics > 2) {
            throw new LogicException(\sprintf('Array may not have more than 2 generic types at "%s"', $reader->getPath()));
        }

        switch ($token) {
            case JsonToken::BEGIN_OBJECT:
                $reader->beginObject();

                while ($reader->hasNext()) {
                    $name = $reader->nextName();

                    switch ($this->numberOfGenerics) {
                        // no generics specified
                        case 0:
                            // By now we know that we're deserializing a json object to an array.
                            // If there is a nested object, continue deserializing to an array,
                            // otherwise guess the type using the wildcard
                            $type = $reader->peek() === JsonToken::BEGIN_OBJECT
                                ? TypeToken::create(TypeToken::HASH)
                                : TypeToken::create(TypeToken::WILDCARD);

                            $adapter = $this->typeAdapterProvider->getAdapter($type);
                            $array[$name] = $adapter->read($reader);
                            break;
                        // generic for value specified
                        case 1:
                            $array[$name] = $this->valueTypeAdapter->read($reader);
                            break;
                        // generic for key and value specified
                        case 2:
                            if (!$this->keyType->isString() && !$this->keyType->isInteger()) {
                                throw new LogicException(\sprintf('Array keys must be strings or integers at "%s"', $reader->getPath()));
                            }

                            if ($this->keyType->isInteger()) {
                                if (!\ctype_digit($name)) {
                                    throw new JsonSyntaxException(\sprintf('Expected integer, but found string for key at "%s"', $reader->getPath()));
                                }

                                $name = (int)$name;
                            }

                            $array[$name] = $this->valueTypeAdapter->read($reader);

                            break;
                    }
                }

                $reader->endObject();

                break;
            case JsonToken::BEGIN_ARRAY:
                $reader->beginArray();

                while ($reader->hasNext()) {
                    switch ($this->numberOfGenerics) {
                        // no generics specified
                        case 0:
                        case 1:
                            $array[] = $this->valueTypeAdapter->read($reader);

                            break;
                        default:
                            throw new LogicException(\sprintf('An array may only specify a generic type for the value at "%s"', $reader->getPath()));
                    }
                }

                $reader->endArray();

                break;
            default:
                throw new JsonSyntaxException(\sprintf('Could not parse json, expected array or object but found "%s" at "%s"', $token, $reader->getPath()));
        }

        return $array;
    }

    /**
     * Write the value to the writer for the type
     *
     * @param JsonWritable $writer
     * @param array|stdClass|null $value
     * @return void
     * @throws \LogicException
     */
    public function write(JsonWritable $writer, $value): void
    {
        if (null === $value) {
            $writer->writeNull();

            return;
        }

        if ($this->numberOfGenerics > 2) {
            throw new LogicException(\sprintf('Array may not have more than 2 generic types at "%s"', $writer->getPath()));
        }

        $arrayIsObject = $this->isArrayObject($value, $this->numberOfGenerics);

        if ($arrayIsObject) {
            $writer->beginObject();
        } else {
            $writer->beginArray();
        }

        foreach ($value as $key => $item) {
            switch ($this->numberOfGenerics) {
                // no generics specified
                case 0:
                    if ($arrayIsObject) {
                        $writer->name((string)$key);
                    }

                    $adapter = $this->typeAdapterProvider->getAdapter(TypeToken::createFromVariable($item));
                    $adapter->write($writer, $item);

                    break;
                // generic for value specified
                case 1:
                    if ($arrayIsObject) {
                        $writer->name((string)$key);
                    }

                    $this->valueTypeAdapter->write($writer, $item);

                    break;
                // generic for key and value specified
                case 2:
                    $writer->name($key);
                    $this->valueTypeAdapter->write($writer, $item);

                    break;
            }
        }

        if ($arrayIsObject) {
            $writer->endObject();
        } else {
            $writer->endArray();
        }
    }

    /**
     * Returns true if the array is acting like an object
     * @param array|stdClass $array
     * @param int $numberOfGenerics
     * @return bool
     */
    private function isArrayObject($array, int $numberOfGenerics): bool
    {
        if (2 === $numberOfGenerics) {
            return true;
        }

        return \is_string(\key($array));
        return \is_string(\key(/** @scrutinizer ignore-type */ $array));
    }
}

tebru / gson-php

Pull Request — master (#44)

ArrayTypeAdapter::read() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
