PermissionsTask::execute() - Code Metrics - Inspection of "[TASK] optimize code and magallanes 3.1.0 requirem..." - teamneusta/magallanes-task-typo3 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (1439d8)

by Benjamin

created 2017-03-01 12:51 UTC

PermissionsTask::execute() A

↳ Parent: PermissionsTask

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	0

<?php
/**
 * This file is part of the teamneusta/magallanes-task-typo3 package.
 *
 * Copyright (c) 2017 neusta GmbH | Ein team neusta Unternehmen
 *
 * For the full copyright and license information, please view the LICENSE file that was distributed with this source code.
 *
 * @license http://www.opensource.org/licenses/mit-license.html  MIT License
 */
declare(strict_types=1);

namespace TeamNeusta\Magallanes\Task\TYPO3;

/**
 * Class PermissionsTask
 *
 * @author Benjamin Kluge <[email protected]>
 * @package TeamNeusta\Magallanes\Task\TYPO3
 */
class PermissionsTask extends AbstractTypo3Task
{
    /**
     * name
     *
     * @var string
     */
    protected $name = 'permissions';

    /**
     * description
     *
     * @var string
     */
    protected $description = '[TYPO3] TYPO3 permissions task';

    /**
     * permissions
     *
     * @var array
     */
    protected $permissions = [
        '/typo3conf/PackageStates.php'      => 2775,
        '/typo3conf/LocalConfiguration.php' => 2775,
    ];

    /**
     * execute
     *
     * @return bool
     */
    public function execute(): bool
    {
        $options = $this->getOptions(['web-dir' => 'web']);
        foreach ($this->permissions as $path => $permission) {
            $command = sprintf('chmod -f %s "%s"', $permission, $options['web-dir'].$path);
            $process = $this->executeCommand($command);
        }

        return $process;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }
}


1			<?php
2			/**
3			* This file is part of the teamneusta/magallanes-task-typo3 package.
4			*
5			* Copyright (c) 2017 neusta GmbH \| Ein team neusta Unternehmen
6			*
7			* For the full copyright and license information, please view the LICENSE file that was distributed with this source code.
8			*
9			* @license http://www.opensource.org/licenses/mit-license.html MIT License
10			*/
11			declare(strict_types=1);
12
13			namespace TeamNeusta\Magallanes\Task\TYPO3;
14
15			/**
16			* Class PermissionsTask
17			*
18			* @author Benjamin Kluge <[email protected]>
19			* @package TeamNeusta\Magallanes\Task\TYPO3
20			*/
21			class PermissionsTask extends AbstractTypo3Task
22			{
23			/**
24			* name
25			*
26			* @var string
27			*/
28			protected $name = 'permissions';
29
30			/**
31			* description
32			*
33			* @var string
34			*/
35			protected $description = '[TYPO3] TYPO3 permissions task';
36
37			/**
38			* permissions
39			*
40			* @var array
41			*/
42			protected $permissions = [
43			'/typo3conf/PackageStates.php' => 2775,
44			'/typo3conf/LocalConfiguration.php' => 2775,
45			];
46
47			/**
48			* execute
49			*
50			* @return bool
51			*/
52			public function execute(): bool
53			{
54			$options = $this->getOptions(['web-dir' => 'web']);
55			foreach ($this->permissions as $path => $permission) {
56			$command = sprintf('chmod -f %s "%s"', $permission, $options['web-dir'].$path);
57			$process = $this->executeCommand($command);
58			}
59
60			return $process;
			0 ignored issues – show Bug introduced 2017-02-22 09:31 UTC by Report Bug Copy Issue Report The variable `$process` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
61			}
62			}
63

teamneusta / magallanes-task-typo3

Branch — master (1439d8)

PermissionsTask::execute() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like