TddWizard\Fixtures\Customer\CustomerFixture

Complexity

Total Complexity

14

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Test Coverage

Coverage

43.9%

Importance

Changes	1
Bugs	0	Features	0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	logout()	0	8	2
A	getId()	0	3	1
A	rollback()	0	3	1
A	getDefaultBillingAddressId()	0	3	1
A	login()	0	8	2
A	getDefaultShippingAddressId()	0	3	1
A	getOtherAddressId()	0	3	1
A	getEmail()	0	3	1
A	__construct()	0	3	1
A	getNonDefaultAddressIds()	0	6	1
A	getAllAddressIds()	0	7	1
A	getConfirmation()	0	3	1

<?php

namespace TddWizard\Fixtures\Customer;

use Magento\Customer\Api\Data\AddressInterface;
use Magento\Customer\Api\Data\CustomerInterface;
use Magento\Customer\Model\Session;
use Magento\TestFramework\Helper\Bootstrap;

The type Magento\TestFramework\Helper\Bootstrap was not found. Maybe you did not declare it correctly or list all dependencies?

/**
 * Object that can be returned from customer fixture, contains ids for test expectations
 */
class CustomerFixture
{
    /**
     * @var CustomerInterface
     */
    private $customer;

    public function __construct(CustomerInterface $customer)
    {
        $this->customer = $customer;
    }

    public function getDefaultShippingAddressId(): int
    {
        return $this->customer->getDefaultShipping();

The expression return $this->customer->getDefaultShipping() returns the type null|string which is incompatible with the type-hinted return integer.

    }

    public function getDefaultBillingAddressId(): int
    {
        return $this->customer->getDefaultBilling();

The expression return $this->customer->getDefaultBilling() returns the type null|string which is incompatible with the type-hinted return integer.

    }

    public function getOtherAddressId(): int
    {
        return $this->getNonDefaultAddressIds()[0];
    }

    public function getNonDefaultAddressIds(): array
    {
        return array_values(
            array_diff(
                $this->getAllAddressIds(),
                [$this->getDefaultBillingAddressId(), $this->getDefaultShippingAddressId()]
            )
        );
    }

    public function getAllAddressIds(): array
    {
        return array_map(
            function (AddressInterface $address) {
                return $address->getId();
            },
            $this->customer->getAddresses()

It seems like $this->customer->getAddresses() can also be of type null; however, parameter $arr1 of array_map() does only seem to accept array, maybe add an additional type check?

        );
    }

    public function getId(): int
    {
        return $this->customer->getId();

The expression return $this->customer->getId() could return the type null which is incompatible with the type-hinted return integer. Consider adding an additional type-check to rule them out.

    }

    public function getConfirmation(): string
    {
        return $this->customer->getConfirmation();

The expression return $this->customer->getConfirmation() could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }

    public function getEmail(): string
    {
        return $this->customer->getEmail();
    }

    public function login(Session $session = null): void
    {
        if ($session === null) {
            $objectManager = Bootstrap::getObjectManager();
            $objectManager->removeSharedInstance(Session::class);
            $session = $objectManager->get(Session::class);
        }
        $session->setCustomerId($this->getId());
    }

    public function logout(Session $session = null): void
    {
        if ($session === null) {
            $objectManager = Bootstrap::getObjectManager();
            $session = $objectManager->get(Session::class);
        }

        $session->logout();
    }

    public function rollback(): void
    {
        CustomerFixtureRollback::create()->execute($this);
    }
}