ProductFixture::getSku() - Code Metrics - Inspection of "Add auth.json for Scrutinzer et al" - tddwizard/magento2-fixtures - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 971d31...2154ff )

by Fabian

created 2017-11-10 14:51 UTC

ProductFixture::getSku() A

↳ Parent: ProductFixture

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

namespace TddWizard\Fixtures\Catalog;

use Magento\Catalog\Api\Data\ProductInterface;

class ProductFixture
{
    /**
     * @var ProductInterface
     */
    private $product;

    public function __construct(ProductInterface $product)
    {
        $this->product = $product;
    }

    public function getId() : int
    {
        return $this->product->getId();

    }

    public function getSku() : string
    {
        return $this->product->getSku();
    }
}


1			<?php
2
3			namespace TddWizard\Fixtures\Catalog;
4
5			use Magento\Catalog\Api\Data\ProductInterface;
6
7			class ProductFixture
8			{
9			/**
10			* @var ProductInterface
11			*/
12			private $product;
13
14			public function __construct(ProductInterface $product)
15			{
16			$this->product = $product;
17			}
18
19			public function getId() : int
20			{
21			return $this->product->getId();
			0 ignored issues – show Bug Best Practice introduced 2017-11-10 15:01 UTC by Report Bug Copy Issue Report The expression `return $this->product->getId()` could return the type `null` which is incompatible with the type-hinted return `integer`. Consider adding an additional type-check to rule them out. Loading history...
22			}
23
24			public function getSku() : string
25			{
26			return $this->product->getSku();
27			}
28			}
29

tddwizard / magento2-fixtures

Push — master ( 971d31...2154ff )

ProductFixture::getSku() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like