CategoryFixture::getCategory() - Code Metrics - Inspection of "Save category with global scope via resource model" - tddwizard/magento2-fixtures - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#43)

by Fabian

created 2020-05-08 17:52 UTC

CategoryFixture::getCategory() A

↳ Parent: CategoryFixture

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	3
rs	10

<?php

namespace TddWizard\Fixtures\Catalog;

use Magento\Catalog\Api\Data\CategoryInterface;
use Magento\Catalog\Model\Category;

class CategoryFixture
{
    /**
     * @var CategoryInterface
     */
    private $category;

    /**
     * @return CategoryInterface
     */
    public function getCategory(): CategoryInterface
    {
        return $this->category;
    }

    public function __construct(CategoryInterface $category)
    {
        $this->category = $category;
    }

    public function getId() : int
    {
        return $this->category->getId();

    }

    public function getUrlKey() : string
    {
        /** @var Category $category */
        $category = $this->category;
        return $category->getUrlKey();

    }
}


1			<?php
2
3			namespace TddWizard\Fixtures\Catalog;
4
5			use Magento\Catalog\Api\Data\CategoryInterface;
6			use Magento\Catalog\Model\Category;
7
8			class CategoryFixture
9			{
10			/**
11			* @var CategoryInterface
12			*/
13			private $category;
14
15			/**
16			* @return CategoryInterface
17			*/
18			public function getCategory(): CategoryInterface
19			{
20			return $this->category;
21			}
22
23			public function __construct(CategoryInterface $category)
24			{
25			$this->category = $category;
26			}
27
28			public function getId() : int
29			{
30			return $this->category->getId();
			0 ignored issues – show Bug Best Practice introduced 2017-12-13 16:13 UTC by Report Bug Copy Issue Report The expression `return $this->category->getId()` could return the type `null` which is incompatible with the type-hinted return `integer`. Consider adding an additional type-check to rule them out. Loading history...
31			}
32
33			public function getUrlKey() : string
34			{
35			/** @var Category $category */
36			$category = $this->category;
37			return $category->getUrlKey();
			0 ignored issues – show Bug Best Practice introduced 2017-12-14 15:00 UTC by Report Bug Copy Issue Report The expression `return $category->getUrlKey()` could return the type `null` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
38			}
39			}
40

tddwizard / magento2-fixtures

Pull Request — master (#43)

CategoryFixture::getCategory() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like