Ordening::__construct() - Code Metrics - Inspection of "Aggregation class" - tbolier/php-rethink-ql - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#32)

by Timon

created 2018-02-14 10:27 UTC

Ordening::__construct() A

↳ Parent: Ordening

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	3

<?php
declare(strict_types = 1);

namespace TBolier\RethinkQL\Query;

use TBolier\RethinkQL\Message\MessageInterface;
use TBolier\RethinkQL\RethinkInterface;
use TBolier\RethinkQL\Types\Term\TermType;

class Ordening extends AbstractQuery implements OrdeningInterface
{
    /**
     * @var QueryInterface
     */
    private $query;

    /**
     * @param string $key
     * @param RethinkInterface $rethink
     * @param MessageInterface $message
     */
    public function __construct(string $key, RethinkInterface $rethink, MessageInterface $message)
    {
        parent::__construct($rethink, $message);

        $this->asc($key);
    }

    /**
     * @inheritdoc
     */
    public function asc(string $key): OrdeningInterface
    {
        $this->query = [

            TermType::ASC,
            [
                $key,
            ],
        ];

        return $this;
    }

    /**
     * @inheritdoc
     */
    public function desc(string $key): OrdeningInterface
    {
        $this->query = [

            TermType::DESC,
            [
                $key,
            ],
        ];

        return $this;
    }

    /**
     * @inheritdoc
     */
    public function toArray(): array
    {
        return $this->query;

    }
}


1			<?php
2			declare(strict_types = 1);
3
4			namespace TBolier\RethinkQL\Query;
5
6			use TBolier\RethinkQL\Message\MessageInterface;
7			use TBolier\RethinkQL\RethinkInterface;
8			use TBolier\RethinkQL\Types\Term\TermType;
9
10			class Ordening extends AbstractQuery implements OrdeningInterface
11			{
12			/**
13			* @var QueryInterface
14			*/
15			private $query;
16
17			/**
18			* @param string $key
19			* @param RethinkInterface $rethink
20			* @param MessageInterface $message
21			*/
22			public function __construct(string $key, RethinkInterface $rethink, MessageInterface $message)
23			{
24			parent::__construct($rethink, $message);
25
26			$this->asc($key);
27			}
28
29			/**
30			* @inheritdoc
31			*/
32			public function asc(string $key): OrdeningInterface
33			{
34			$this->query = [
			0 ignored issues – show Documentation Bug introduced 2018-02-14 09:28 UTC by Report Bug Copy Issue Report It seems like `array(TBolier\RethinkQL\...Type::ASC, array($key))` of type `array<integer,array<integer,string>\|integer>` is incompatible with the declared type `TBolier\RethinkQL\Query\QueryInterface` of property `$query`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
35			TermType::ASC,
36			[
37			$key,
38			],
39			];
40
41			return $this;
42			}
43
44			/**
45			* @inheritdoc
46			*/
47			public function desc(string $key): OrdeningInterface
48			{
49			$this->query = [
			0 ignored issues – show Documentation Bug introduced 2018-02-14 09:28 UTC by Report Bug Copy Issue Report It seems like `array(TBolier\RethinkQL\...ype::DESC, array($key))` of type `array<integer,array<integer,string>\|integer>` is incompatible with the declared type `TBolier\RethinkQL\Query\QueryInterface` of property `$query`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
50			TermType::DESC,
51			[
52			$key,
53			],
54			];
55
56			return $this;
57			}
58
59			/**
60			* @inheritdoc
61			*/
62			public function toArray(): array
63			{
64			return $this->query;
			0 ignored issues – show Bug Best Practice introduced 2018-02-14 10:30 UTC by Report Bug Copy Issue Report The expression `return $this->query` returns the type `TBolier\RethinkQL\Query\QueryInterface` which is incompatible with the type-hinted return `array`. Loading history...
65			}
66			}
67

tbolier / php-rethink-ql

Pull Request — master (#32)

Ordening::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like