TBolier\RethinkQL\IntegrationTest\Query\AbstractTableTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	insertDocument()	0	12	1
A	tearDown()	0	7	2
A	setUp()	0	6	2

<?php
declare(strict_types=1);

namespace TBolier\RethinkQL\IntegrationTest\Query;

use TBolier\RethinkQL\IntegrationTest\AbstractTestCase;
use TBolier\RethinkQL\Response\ResponseInterface;

abstract class AbstractTableTest extends AbstractTestCase
{
    public function setUp()
    {
        parent::setUp();

        if (!\in_array('tabletest', $this->r()->db()->tableList()->run()->getData(), true)) {

It seems like $this->r()->db()->tableList()->run()->getData() can also be of type string; however, parameter $haystack of in_array() does only seem to accept array, maybe add an additional type check?

            $this->r()->db()->tableCreate('tabletest')->run();
        }
    }

    public function tearDown()
    {
        if (\in_array('tabletest', $this->r()->db()->tableList()->run()->getData(), true)) {

It seems like $this->r()->db()->tableList()->run()->getData() can also be of type string; however, parameter $haystack of in_array() does only seem to accept array, maybe add an additional type check?

            $this->r()->db()->tableDrop('tabletest')->run();
        }

        parent::tearDown();
    }


    /**
     * @param int $documentId
     * @return ResponseInterface
     */
    protected function insertDocument(int $documentId): ResponseInterface
    {
        $res = $this->r()
            ->table('tabletest')
            ->insert([
                'id' => $documentId,
                'title' => 'Test document ' . $documentId,
                'description' => 'A document description.',
            ])
            ->run();

        return $res;

The expression return $res could return the type iterable which is incompatible with the type-hinted return TBolier\RethinkQL\Response\ResponseInterface. Consider adding an additional type-check to rule them out.

    }
}