Database::run() - Code Metrics - Inspection of "Make assertions call dynamic" - tbolier/php-rethink-ql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1e949f...87ce65 )

unknown

created 2018-01-22 13:09 UTC

Database::run() A

↳ Parent: Database

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php
declare(strict_types=1);

namespace TBolier\RethinkQL\Query;

use TBolier\RethinkQL\RethinkInterface;
use TBolier\RethinkQL\Types\Query\QueryType;
use TBolier\RethinkQL\Types\Term\TermType;

class Database implements DatabaseInterface
{
    /**T
     * @var RethinkInterface
     */
    private $rethink;

    /**
     * @var array
     */
    private $message;

    /**
     * @param RethinkInterface $rethink
     * @param MessageInterface $message
     */
    public function __construct(RethinkInterface $rethink, MessageInterface $message)
    {
        $this->rethink = $rethink;

        $message
            ->setQueryType(QueryType::START)
            ->setQuery(new Query([]));

        $this->message = $message;

    }

    /**
     * @inheritdoc
     */
    public function tableList(): DatabaseInterface
    {
        $this->message

            ->setQueryType(QueryType::START)
            ->setQuery(new Query(
                [
                    TermType::TABLE_LIST,
                ]
            ));

        return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @inheritdoc
     */
    public function tableCreate(string $name): DatabaseInterface
    {
        $this->message

            ->setQueryType(QueryType::START)
            ->setQuery(new Query([
                TermType::TABLE_CREATE,
                [
                    [
                        TermType::DATUM,
                        $name,
                    ],
                ],
            ]));

        return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @inheritdoc
     */
    public function tableDrop(string $name): DatabaseInterface
    {
        $this->message

            ->setQueryType(QueryType::START)
            ->setQuery(new Query([
                TermType::TABLE_DROP,
                [
                    [
                        TermType::DATUM,
                        $name,
                    ],
                ],
            ]));

        return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @return array
     */
    public function run(): array
    {
        return $this->rethink->connection()->run($this->message);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace TBolier\RethinkQL\Query;
5
6			use TBolier\RethinkQL\RethinkInterface;
7			use TBolier\RethinkQL\Types\Query\QueryType;
8			use TBolier\RethinkQL\Types\Term\TermType;
9
10			class Database implements DatabaseInterface
11			{
12			/**T
13			* @var RethinkInterface
14			*/
15			private $rethink;
16
17			/**
18			* @var array
19			*/
20			private $message;
21
22			/**
23			* @param RethinkInterface $rethink
24			* @param MessageInterface $message
25			*/
26			public function __construct(RethinkInterface $rethink, MessageInterface $message)
27			{
28			$this->rethink = $rethink;
29
30			$message
31			->setQueryType(QueryType::START)
32			->setQuery(new Query([]));
33
34			$this->message = $message;
			0 ignored issues – show Documentation Bug introduced 2018-01-22 13:14 UTC by Report Bug Copy Issue Report It seems like `$message` of type `object<TBolier\RethinkQL\Query\MessageInterface>` is incompatible with the declared type `array` of property `$message`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
35			}
36
37			/**
38			* @inheritdoc
39			*/
40			public function tableList(): DatabaseInterface
41			{
42			$this->message
			0 ignored issues – show Bug introduced 2018-01-22 13:14 UTC by Report Bug Copy Issue Report The method `setQueryType` cannot be called on `$this->message` (of type `array`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
43			->setQueryType(QueryType::START)
44			->setQuery(new Query(
45			[
46			TermType::TABLE_LIST,
47			]
48			));
49
50			return $this;
			0 ignored issues – show Bug Best Practice introduced 2018-01-22 13:14 UTC by Report Bug Copy Issue Report The return type of `return $this;` (`TBolier\RethinkQL\Query\Database`) is incompatible with the return type declared by the interface `TBolier\RethinkQL\Query\...aseInterface::tableList` of type `self`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
51			}
52
53			/**
54			* @inheritdoc
55			*/
56			public function tableCreate(string $name): DatabaseInterface
57			{
58			$this->message
			0 ignored issues – show Bug introduced 2018-01-22 13:14 UTC by Report Bug Copy Issue Report The method `setQueryType` cannot be called on `$this->message` (of type `array`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
59			->setQueryType(QueryType::START)
60			->setQuery(new Query([
61			TermType::TABLE_CREATE,
62			[
63			[
64			TermType::DATUM,
65			$name,
66			],
67			],
68			]));
69
70			return $this;
			0 ignored issues – show Bug Best Practice introduced 2018-01-22 13:14 UTC by Report Bug Copy Issue Report The return type of `return $this;` (`TBolier\RethinkQL\Query\Database`) is incompatible with the return type declared by the interface `TBolier\RethinkQL\Query\...eInterface::tableCreate` of type `self`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
71			}
72
73			/**
74			* @inheritdoc
75			*/
76			public function tableDrop(string $name): DatabaseInterface
77			{
78			$this->message
			0 ignored issues – show Bug introduced 2018-01-22 13:14 UTC by Report Bug Copy Issue Report The method `setQueryType` cannot be called on `$this->message` (of type `array`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
79			->setQueryType(QueryType::START)
80			->setQuery(new Query([
81			TermType::TABLE_DROP,
82			[
83			[
84			TermType::DATUM,
85			$name,
86			],
87			],
88			]));
89
90			return $this;
			0 ignored issues – show Bug Best Practice introduced 2018-01-22 13:14 UTC by Report Bug Copy Issue Report The return type of `return $this;` (`TBolier\RethinkQL\Query\Database`) is incompatible with the return type declared by the interface `TBolier\RethinkQL\Query\...aseInterface::tableDrop` of type `self`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
91			}
92
93			/**
94			* @return array
95			*/
96			public function run(): array
97			{
98			return $this->rethink->connection()->run($this->message);
			0 ignored issues – show Documentation introduced 2018-01-22 13:14 UTC by Report Bug Copy Issue Report `$this->message` is of type `array`, but the function expects a `object<TBolier\RethinkQL\Query\MessageInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
99			}
100			}
101

tbolier / php-rethink-ql

Push — master ( 1e949f...87ce65 )

Database::run() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like