TableTest::testFilterCount() - Code Metrics - Inspection of "Add framed queries & refactoring operations" - tbolier/php-rethink-ql - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#18)

by Marc

created 2018-02-07 14:15 UTC

TableTest::testFilterCount() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	21
rs	9.3142
c	0
b	0
f	0
cc	1
eloc	13
nc	1
nop	0

<?php
declare(strict_types=1);

namespace TBolier\RethinkConnect\Test\Connection;

use ArrayObject;
use TBolier\RethinkQL\Response\Cursor;
use TBolier\RethinkQL\Response\ResponseInterface;
use TBolier\RethinkQL\IntegrationTest\BaseTestCase;

class TableTest extends BaseTestCase
{
    public function setUp()
    {
        parent::setUp();

        if (!\in_array('tabletest', $this->r()->db()->tableList()->run()->getData()[0], true)) {
            $this->r()->db()->tableCreate('tabletest')->run();
        }
    }

    public function tearDown()
    {
        if (\in_array('tabletest', $this->r()->db()->tableList()->run()->getData()[0], true)) {
            $this->r()->db()->tableDrop('tabletest')->run();
        }

        parent::tearDown();
    }

    /**
     * @throws \Exception
     */
    public function testEmptyTable()
    {
        /** @var ResponseInterface $count */
        $count = $this->r()
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->table('tabletest')
            ->filter([
                [
                    'title' => 'Test document',
                ],
            ])
            ->count()
            ->run();

        $this->assertInternalType('int', $count->getData()[0]);

        $res = $this->r()
            ->table('tabletest')
            ->delete()
            ->run();

        $this->assertObStatus(['deleted' => $count->getData()[0]], $res->getData()[0]);
    }

    /**
     * @throws \Exception
     */
    public function testInsert()
    {
        $res = $this->insertDocument(1);

        $this->assertObStatus(['inserted' => 1], $res->getData()[0]);
    }

    /**
     * @throws \Exception
     */
    public function testCount()
    {
        $this->insertDocument(1);

        $res = $this->r()
            ->table('tabletest')
            ->count()
            ->run();

        $this->assertInternalType('int', $res->getData()[0]);
    }

    /**
     * @throws \Exception
     */
    public function testFilter()
    {
        $this->insertDocument(1);

        /** @var Cursor $cursor */
        $cursor = $this->r()
            ->table('tabletest')
            ->filter([
                [
                    'title' => 'Test document',
                ],
            ])
            ->run();

        $this->assertInstanceOf(\Iterator::class, $cursor);
        $this->assertInternalType('array', $cursor->current());
    }

    /**
     * @throws \Exception
     */
    public function testFilterCount()
    {
        $this->insertDocument(1);
        $this->insertDocument(2);
        $this->insertDocument(3);
        $this->insertDocument(4);
        $this->insertDocument(5);

        /** @var ResponseInterface $res */
        $res = $this->r()
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->table('tabletest')
            ->filter([
                [
                    'title' => 'Test document',
                ],
            ])
            ->count()
            ->run();

        $this->assertEquals(5, $res->getData()[0]);
    }

    /**
     * @throws \Exception
     */
    public function testUpdate()
    {
        $this->insertDocument(1);

        $this->r()
            ->table('tabletest')
            ->insert([
                [
                    'title' => 'Update document',
                ],
            ])
            ->run();

        /** @var ResponseInterface $count */
        $count = $this->r()
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->table('tabletest')
            ->filter([
                [
                    'title' => 'Update document',
                ],
            ])
            ->count()
            ->run();
        /** @var ResponseInterface $res */
        $res = $this->r()
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->table('tabletest')
            ->filter([
                [
                    'title' => 'Update document',
                ],
            ])
            ->update([
                [
                    'title' => 'Updated document',
                ],
            ])
            ->run();

        $this->assertObStatus(['replaced' => $count->getData()[0]], $res->getData()[0]);
    }

    /**
     * @throws \Exception
     */
    public function testDeleteDocument()
    {
        $this->r()
            ->table('tabletest')
            ->insert([
                [
                    'title' => 'Delete document',
                ],
            ])
            ->run();

        /** @var ResponseInterface $count */
        $count = $this->r()
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->table('tabletest')
            ->filter([
                [
                    'title' => 'Delete document',
                ],
            ])
            ->count()
            ->run();

        $this->assertInternalType('int', $count->getData()[0]);

        /** @var ResponseInterface $res */
        $res = $this->r()
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->table('tabletest')
            ->filter([
                [
                    'title' => 'Delete document',
                ],
            ])
            ->delete()
            ->run();

        $this->assertObStatus(['deleted' => $count->getData()[0]], $res->getData()[0]);
    }

    /**
     * @return void
     * @throws \Exception
     */
    public function testGet(): void
    {
        $this->r()
            ->table('tabletest')
            ->insert([
                [
                    'id' => 'foo',
                ],
            ])
            ->run();

        /** @var ResponseInterface $res */
        $res = $this->r()
            ->table('tabletest')
            ->get('foo')
            ->run();

        $this->assertEquals([0 => ['id' => 'foo']], $res->getData());
    }

    /**
     * @return void
     * @throws \Exception
     */
    public function testGetNonExistingDocument(): void
    {
        /** @var ResponseInterface $res */
        $res = $this->r()
            ->table('tabletest')
            ->get('bar')
            ->run();

        $this->assertEquals([0 => null], $res->getData());
    }

    /**
     * @param $status
     * @param $data
     * @throws \Exception
     */
    protected function assertObStatus($status, $data)
    {
        $res = [];
        $statuses = [
            'unchanged',
            'skipped',
            'replaced',
            'inserted',
            'errors',
            'deleted',
        ];
        $data = new ArrayObject($data);

        foreach ($statuses as $s) {
            $status[$s] = $status[$s] ?? 0;
        }

        $data->setFlags($data::ARRAY_AS_PROPS);

        foreach ($statuses as $s) {
            $res[$s] = $data[$s] ?? 0;
        }

        $this->assertEquals($status, $res);
    }

    /**
     * @param int $documentId
     * @return ResponseInterface
     */
    private function insertDocument(int $documentId): ResponseInterface
    {
        $res = $this->r()
            ->table('tabletest')
            ->insert([
                [
                    'documentId' => $documentId,
                    'title' => 'Test document',
                    'description' => 'My first document.',
                ],
            ])
            ->run();

        return $res;
    }
}


Pull Request — master (#18)

TableTest::testFilterCount() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			declare(strict_types=1);
3
4			namespace TBolier\RethinkConnect\Test\Connection;
5
6			use ArrayObject;
7			use TBolier\RethinkQL\Response\Cursor;
8			use TBolier\RethinkQL\Response\ResponseInterface;
9			use TBolier\RethinkQL\IntegrationTest\BaseTestCase;
10
11			class TableTest extends BaseTestCase
12			{
13			public function setUp()
14			{
15			parent::setUp();
16
17			if (!\in_array('tabletest', $this->r()->db()->tableList()->run()->getData()[0], true)) {
18			$this->r()->db()->tableCreate('tabletest')->run();
19			}
20			}
21
22			public function tearDown()
23			{
24			if (\in_array('tabletest', $this->r()->db()->tableList()->run()->getData()[0], true)) {
25			$this->r()->db()->tableDrop('tabletest')->run();
26			}
27
28			parent::tearDown();
29			}
30
31			/**
32			* @throws \Exception
33			*/
34			public function testEmptyTable()
35			{
36			/** @var ResponseInterface $count */
37			$count = $this->r()
			0 ignored issues – show Bug introduced 2018-02-07 13:42 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `TBolier\RethinkQL\Query\AbstractQuery` as the method `count()` does only exist in the following sub-classes of `TBolier\RethinkQL\Query\AbstractQuery`: `TBolier\RethinkQL\Query\...ation\AbstractOperation`, `TBolier\RethinkQL\Query\Operation\Count`, `TBolier\RethinkQL\Query\Operation\DbCreate`, `TBolier\RethinkQL\Query\Operation\DbDrop`, `TBolier\RethinkQL\Query\Operation\DbList`, `TBolier\RethinkQL\Query\Operation\Delete`, `TBolier\RethinkQL\Query\Operation\Filter`, `TBolier\RethinkQL\Query\Operation\Get`, `TBolier\RethinkQL\Query\Operation\Insert`, `TBolier\RethinkQL\Query\Operation\TableCreate`, `TBolier\RethinkQL\Query\Operation\TableDrop`, `TBolier\RethinkQL\Query\Operation\TableList`, `TBolier\RethinkQL\Query\Operation\Update`, `TBolier\RethinkQL\Query\Table`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
38			->table('tabletest')
39			->filter([

tbolier / php-rethink-ql

Pull Request — master (#18)

TableTest::testFilterCount() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like