TestJob::run() - Code Metrics - tavii/SQSJobQueueBundle - Measure and Improve Code Quality continuously with Scrutinizer

TestJob::run() A
last analyzed 2017-10-16 13:51 UTC

↳ Parent: TestJob

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php
namespace Tavii\SQSJobQueueBundle\Tests;


use Tavii\SQSJobQueueBundle\ContainerAwareJob;

class ContainerAwareJobTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @test
     */
    public function コンテナを取得することができる()
    {
        $job = new TestJob();
        $job->setKernelOptions(array(
            'kernel.root_dir' => __DIR__,
            'kernel.debug' => false,
            'kernel.environment' => 'test'
        ));

        $actual = $job->run();
        $this->assertInstanceOf('Symfony\Component\DependencyInjection\ContainerInterface', $actual);
    }

}

class TestJob extends ContainerAwareJob

{

    protected $name = 'name';

    public function run()
    {
        return $this->getContainer();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

}



1			<?php
2			namespace Tavii\SQSJobQueueBundle\Tests;
3
4
5			use Tavii\SQSJobQueueBundle\ContainerAwareJob;
6
7			class ContainerAwareJobTest extends \PHPUnit_Framework_TestCase
8			{
9			/**
10			* @test
11			*/
12			public function コンテナを取得することができる()
13			{
14			$job = new TestJob();
15			$job->setKernelOptions(array(
16			'kernel.root_dir' => __DIR__,
17			'kernel.debug' => false,
18			'kernel.environment' => 'test'
19			));
20
21			$actual = $job->run();
22			$this->assertInstanceOf('Symfony\Component\DependencyInjection\ContainerInterface', $actual);
23			}
24
25			}
26
27			class TestJob extends ContainerAwareJob
			0 ignored issues – show Coding Style Compatibility introduced 2016-03-12 17:21 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
28			{
29
30			protected $name = 'name';
31
32			public function run()
33			{
34			return $this->getContainer();
			0 ignored issues – show Bug Best Practice introduced 2016-03-12 17:21 UTC by Report Bug Copy Issue Report The return type of `return $this->getContainer();` (`Symfony\Component\Depend...tion\ContainerInterface`) is incompatible with the return type declared by the abstract method `Tavii\SQSJobQueue\Job\Job::run` of type `boolean`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
35			}
36
37			}
38
39

tavii / SQSJobQueueBundle

TestJob::run() A last analyzed 2017-10-16 13:51 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

TestJob::run() A
last analyzed 2017-10-16 13:51 UTC