Queue::delete() - Code Metrics - tavii/SQSJobQueueBundle - Measure and Improve Code Quality continuously with Scrutinizer

Queue::delete() A
last analyzed 2017-10-16 13:51 UTC

↳ Parent: Queue

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	1

<?php
namespace Tavii\SQSJobQueueBundle;

use Symfony\Component\EventDispatcher\EventDispatcher;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Tavii\SQSJobQueue\Job\JobInterface;
use Tavii\SQSJobQueue\Message\MessageInterface;
use Tavii\SQSJobQueue\Queue\QueueInterface;
use Tavii\SQSJobQueue\Queue\QueueName;
use Tavii\SQSJobQueueBundle\Event\ReceiveQueueEvent;
use Tavii\SQSJobQueueBundle\Event\SentQueueEvent;

class Queue implements QueueInterface
{

    /**
     * @var Queue
     */
    private $baseQueue;

    /**
     * @var array
     */
    private $kernelOptions;

    /**
     * @var EventDispatcher
     */
    private $dispatcher;


    /**
     * Queue constructor.
     * @param QueueInterface $baseQueue
     * @param EventDispatcherInterface $dispatcher
     * @param array $kernelOptions
     */
    public function __construct(QueueInterface $baseQueue, EventDispatcherInterface $dispatcher, array $kernelOptions)
    {
        $this->baseQueue = $baseQueue;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->kernelOptions = $kernelOptions;
        $this->dispatcher = $dispatcher;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
    }

    /**
     * {@inheritdoc}
     */
    public function receive(QueueName $queueName)
    {
        $message = $this->baseQueue->receive($queueName);
        if ($message instanceof MessageInterface) {
            $job = $message->getJob();
            if ($job instanceof ContainerAwareJob) {
                $job->setKernelOptions($this->kernelOptions);
            }
            $this->dispatcher->dispatch(SQSJobQueueEvents::QUEUE_RECEIVED, new ReceiveQueueEvent($message));
            return $message;
        }
        return null;
    }

    /**
     * {@inheritdoc}
     */
    public function send(JobInterface $job)
    {
        if ($job instanceof ContainerAwareJob) {
            $job->setKernelOptions($this->kernelOptions);
        }
        $result = $this->baseQueue->send($job);
        $this->dispatcher->dispatch(SQSJobQueueEvents::QUEUE_SENT, new SentQueueEvent($job, $result));
        return $result;
    }

    /**
     * {@inheritdoc}
     */
    public function delete(MessageInterface $message)
    {
        $result = false;
        if ($this->baseQueue->delete($message)) {
            $job = $message->getJob();
            unset($job);
            $result = true;
        }
        return $result;
    }


}

1			<?php
2			namespace Tavii\SQSJobQueueBundle;
3
4			use Symfony\Component\EventDispatcher\EventDispatcher;
5			use Symfony\Component\EventDispatcher\EventDispatcherInterface;
6			use Tavii\SQSJobQueue\Job\JobInterface;
7			use Tavii\SQSJobQueue\Message\MessageInterface;
8			use Tavii\SQSJobQueue\Queue\QueueInterface;
9			use Tavii\SQSJobQueue\Queue\QueueName;
10			use Tavii\SQSJobQueueBundle\Event\ReceiveQueueEvent;
11			use Tavii\SQSJobQueueBundle\Event\SentQueueEvent;
12
13			class Queue implements QueueInterface
14			{
15
16			/**
17			* @var Queue
18			*/
19			private $baseQueue;
20
21			/**
22			* @var array
23			*/
24			private $kernelOptions;
25
26			/**
27			* @var EventDispatcher
28			*/
29			private $dispatcher;
30
31
32			/**
33			* Queue constructor.
34			* @param QueueInterface $baseQueue
35			* @param EventDispatcherInterface $dispatcher
36			* @param array $kernelOptions
37			*/
38			public function __construct(QueueInterface $baseQueue, EventDispatcherInterface $dispatcher, array $kernelOptions)
39			{
40			$this->baseQueue = $baseQueue;
			0 ignored issues – show Documentation Bug introduced 2016-03-12 17:21 UTC by Report Bug Copy Issue Report `$baseQueue` is of type `object<Tavii\SQSJobQueue\Queue\QueueInterface>`, but the property `$baseQueue` was declared to be of type `object<Tavii\SQSJobQueueBundle\Queue>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
41			$this->kernelOptions = $kernelOptions;
42			$this->dispatcher = $dispatcher;
			0 ignored issues – show Documentation Bug introduced 2016-03-12 17:21 UTC by Report Bug Copy Issue Report `$dispatcher` is of type `object<Symfony\Component...entDispatcherInterface>`, but the property `$dispatcher` was declared to be of type `object<Symfony\Component...atcher\EventDispatcher>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
43			}
44
45			/**
46			* {@inheritdoc}
47			*/
48			public function receive(QueueName $queueName)
49			{
50			$message = $this->baseQueue->receive($queueName);
51			if ($message instanceof MessageInterface) {
52			$job = $message->getJob();
53			if ($job instanceof ContainerAwareJob) {
54			$job->setKernelOptions($this->kernelOptions);
55			}
56			$this->dispatcher->dispatch(SQSJobQueueEvents::QUEUE_RECEIVED, new ReceiveQueueEvent($message));
57			return $message;
58			}
59			return null;
60			}
61
62			/**
63			* {@inheritdoc}
64			*/
65			public function send(JobInterface $job)
66			{
67			if ($job instanceof ContainerAwareJob) {
68			$job->setKernelOptions($this->kernelOptions);
69			}
70			$result = $this->baseQueue->send($job);
71			$this->dispatcher->dispatch(SQSJobQueueEvents::QUEUE_SENT, new SentQueueEvent($job, $result));
72			return $result;
73			}
74
75			/**
76			* {@inheritdoc}
77			*/
78			public function delete(MessageInterface $message)
79			{
80			$result = false;
81			if ($this->baseQueue->delete($message)) {
82			$job = $message->getJob();
83			unset($job);
84			$result = true;
85			}
86			return $result;
87			}
88
89
90			}

tavii / SQSJobQueueBundle

Queue::delete() A last analyzed 2017-10-16 13:51 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Queue::delete() A
last analyzed 2017-10-16 13:51 UTC