Field::formCreate() - Code Metrics - Inspection of "Move table content into field helper." - taskforcedev/crud-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 02ffc1...a5dd29 )

by David

created 2016-11-17 14:25 UTC

Field::formCreate() B

↳ Parent: Field

Complexity

Conditions	5
Paths	5

Size

Total Lines	45
Code Lines	27

Duplication

Lines	39
Ratio	86.67 %

Importance

Changes

Metric	Value
dl	39
loc	45
rs	8.439
c	0
b	0
f	0
cc	5
eloc	27
nc	5
nop	1

<?php

namespace Taskforcedev\CrudApi\Helpers;

/**
 * Class Field.
 */
class Field
{
    public $crudApi;

    /**
     * Field constructor.
     *
     * @param CrudApi $crudApi
     */
    public function __construct(CrudApi $crudApi)
    {
        $this->crudApi = $crudApi;
    }

    /**
     * Determine if the field is an id field.
     *
     * @param $field
     *
     * @return bool
     */
    public function isIdField($field)
    {
        return strpos($field, '_id') === false ? false : true;
    }

    /**
     * Parse a relation field name into the relation name.
     *
     * @param string $field Field name
     *
     * @return string
     */
    public function getRelatedField($field)
    {
        $relation = str_replace('_id', '', $field);
        return $relation;
    }

    /**
     * Retrieve the models primary field for display purposes.
     *
     * @param            $item   Model to retrieve primary field of.
     * @param null|array $config CrudApi Configuration.
     *
     * @return string
     */
    public function getPrimaryField($item, $config = null)
    {
        /* If config is not overridden then load crudapi config */
        if ($config === null) {
            $config = config('crudapi');
        }
        if (!isset($config['models']['fields']['default'])) {
            $defaultField = 'name';
        } else {
            $defaultField = $config['models']['fields']['default'];
        }

        /* Get the items Class */
        $class = get_class($item);

        $stripped_class = str_replace($this->crudApi->namespace, '', $class);
        // if class starts with a \ remove it.
        if (substr($stripped_class, 0, 1) == '\\') {
            $stripped_class = substr($stripped_class, 1);
        }

        $primaryFields = $config['models']['fields']['primary'];

        if (array_key_exists($stripped_class, $primaryFields)) {
            return $primaryFields[$stripped_class];
        } else {
            //return the default
            return $defaultField;
        }
    }

    /**
     * Render fields into appropriate format for an item creation form.
     *
     * @param $fields
     *
     * @return string
     */
    public function formCreate($fields)
    {
        $output = '';

        foreach ($fields as $f) {

            $ucF = ucfirst($f);

            $input_attr = [
                'class' => 'form-control',
                'id' => 'createItem'.$f,
                'name' => $f,
            ];

            $output .= '<fieldset class="form-group">';

            $output .= '<label for="'.$input_attr['id'].'">'.$ucF.'</label>';

            if ($this->isIdField($f)) {
                $input_attr['type'] = 'select';

                $output .= '<select ';
                foreach ($input_attr as $attr => $value) {
                    $output .= "{$attr}='{$value}'";
                }

                $relation = $this->crudApi->getRelatedModel($f);
                $output .= '>';

                $output .= $this->crudApi->getRelatedOptions($relation);

                $output .= '</select>';
            } else {
                $input_attr['type'] = 'text';

                $output .= '<input ';
                foreach ($input_attr as $attr => $value) {
                    $output .= "{$attr}='{$value}'";
                }
                $output .= '>';
            }

            $output .= '</fieldset>';
        }
        return $output;
    }

    /**
     * Return fields as table headings.
     *
     * @param $fields
     *
     * @return string
     */
    public function tableHeadings($fields)
    {
        $output = '';
        foreach ($fields as $f) {
            $output .= '<th>'.ucfirst($f).'</th>';
        }
        return $output;
    }

    public function tableContent($fields, $instance)
    {
        $output = '';
        foreach ($fields as $f) {
            if ($this->fieldHelper->isIdField($f)) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
                $display = $this->crudApi->getRelatedDisplay($f);
                $output .= '<td>' . $display . '</td>';
            } else {
                $output .= '<td>' . $instance->$f . '</td>';
            }
        }
        return $output;
    }
}


1		<?php
2
3		namespace Taskforcedev\CrudApi\Helpers;
4
5		/**
6		* Class Field.
7		*/
8		class Field
9		{
10		public $crudApi;
11
12		/**
13		* Field constructor.
14		*
15		* @param CrudApi $crudApi
16		*/
17		public function __construct(CrudApi $crudApi)
18		{
19		$this->crudApi = $crudApi;
20		}
21
22		/**
23		* Determine if the field is an id field.
24		*
25		* @param $field
26		*
27		* @return bool
28		*/
29		public function isIdField($field)
30		{
31		return strpos($field, '_id') === false ? false : true;
32		}
33
34		/**
35		* Parse a relation field name into the relation name.
36		*
37		* @param string $field Field name
38		*
39		* @return string
40		*/
41		public function getRelatedField($field)
42		{
43		$relation = str_replace('_id', '', $field);
44		return $relation;
45		}
46
47		/**
48		* Retrieve the models primary field for display purposes.
49		*
50		* @param $item Model to retrieve primary field of.
51		* @param null\|array $config CrudApi Configuration.
52		*
53		* @return string
54		*/
55		public function getPrimaryField($item, $config = null)
56		{
57		/* If config is not overridden then load crudapi config */
58		if ($config === null) {
59		$config = config('crudapi');
60		}
61		if (!isset($config['models']['fields']['default'])) {
62		$defaultField = 'name';
63		} else {
64		$defaultField = $config['models']['fields']['default'];
65		}
66
67		/* Get the items Class */
68		$class = get_class($item);
69
70		$stripped_class = str_replace($this->crudApi->namespace, '', $class);
71		// if class starts with a \ remove it.
72		if (substr($stripped_class, 0, 1) == '\\') {
73		$stripped_class = substr($stripped_class, 1);
74		}
75
76		$primaryFields = $config['models']['fields']['primary'];
77
78		if (array_key_exists($stripped_class, $primaryFields)) {
79		return $primaryFields[$stripped_class];
80		} else {
81		//return the default
82		return $defaultField;
83		}
84		}
85
86		/**
87		* Render fields into appropriate format for an item creation form.
88		*
89		* @param $fields
90		*
91		* @return string
92		*/
93		public function formCreate($fields)
94		{
95		$output = '';
96
97	View Code Duplication	foreach ($fields as $f) {
		0 ignored issues – show Duplication introduced 2016-11-17 14:15 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
98		$ucF = ucfirst($f);
99
100		$input_attr = [
101		'class' => 'form-control',
102		'id' => 'createItem'.$f,
103		'name' => $f,
104		];
105
106		$output .= '<fieldset class="form-group">';
107
108		$output .= '<label for="'.$input_attr['id'].'">'.$ucF.'</label>';
109
110		if ($this->isIdField($f)) {
111		$input_attr['type'] = 'select';
112
113		$output .= '<select ';
114		foreach ($input_attr as $attr => $value) {
115		$output .= "{$attr}='{$value}'";
116		}
117
118		$relation = $this->crudApi->getRelatedModel($f);
119		$output .= '>';
120
121		$output .= $this->crudApi->getRelatedOptions($relation);
122
123		$output .= '</select>';
124		} else {
125		$input_attr['type'] = 'text';
126
127		$output .= '<input ';
128		foreach ($input_attr as $attr => $value) {
129		$output .= "{$attr}='{$value}'";
130		}
131		$output .= '>';
132		}
133
134		$output .= '</fieldset>';
135		}
136		return $output;
137		}
138
139		/**
140		* Return fields as table headings.
141		*
142		* @param $fields
143		*
144		* @return string
145		*/
146		public function tableHeadings($fields)
147		{
148		$output = '';
149		foreach ($fields as $f) {
150		$output .= '<th>'.ucfirst($f).'</th>';
151		}
152		return $output;
153		}
154
155		public function tableContent($fields, $instance)
156		{
157		$output = '';
158		foreach ($fields as $f) {
159		if ($this->fieldHelper->isIdField($f)) {
		0 ignored issues – show Bug introduced 2016-11-17 14:28 UTC by Report Bug Copy Issue Report The property `fieldHelper` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
160		$display = $this->crudApi->getRelatedDisplay($f);
161		$output .= '<td>' . $display . '</td>';
162		} else {
163		$output .= '<td>' . $instance->$f . '</td>';
164		}
165		}
166		return $output;
167		}
168		}
169

taskforcedev / crud-api

Push — master ( 02ffc1...a5dd29 )

Field::formCreate() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like