Issues in paypal_module.php (master) - Issues in master - tas2580/paypal - Measure and Improve Code Quality continuously with Scrutinizer

Issues (32)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

acp/paypal_module.php (20 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
*
* @package phpBB Extension - tas2580 Paypal
* @copyright (c) 2015 tas2580 (https://tas2580.net)
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
*
*/

namespace tas2580\paypal\acp;

class paypal_module
{
	var $u_action;
class A {
    var $property;
}

	/** @var \phpbb\user */
	protected $user;

	public function main($id, $mode)
	{
		global $config, $db, $user, $template, $table_prefix, $request, $phpbb_root_path, $phpEx;
function myFunction($a, $b) {
    // Do something
}

		$this->user = $user;
		$this->phpbb_root_path = $phpbb_root_path;
class MyClass { }

$x = new MyClass();
$x->foo = true;
		$this->php_ext = $phpEx;
class MyClass { }

$x = new MyClass();
$x->foo = true;

		$user->add_lang_ext('tas2580/paypal', 'common');

		$sql = 'SELECT *
			FROM ' . $table_prefix . 'paypal_config';
		$result = $db->sql_query($sql);
		$paypal_config = $db->sql_fetchrow($result);

		switch ($mode)
		{
			case 'settings':
				$this->tpl_name = 'acp_paypal_body';
class MyClass { }

$x = new MyClass();
$x->foo = true;
				$this->page_title = $user->lang('ACP_PAYPAL_TITLE');
class MyClass { }

$x = new MyClass();
$x->foo = true;

				add_form_key('acp_paypal');

				// delete amount
				if ($request->is_set('delete'))

				{
					$id = $request->variable('delete', 0);
					if (confirm_box(true))
					{
						$sql = 'DELETE FROM ' . $table_prefix . 'paypal_amount WHERE amount_id = ' . (int) $id;
						$result = $db->sql_query($sql);
						trigger_error($user->lang['AMOUNT_DELETED'] . adm_back_link($this->u_action));
					}
					else
					{
						confirm_box(false, $user->lang['CONFIRM_OPERATION'], build_hidden_fields(array(
							'action'	=> 'delete',
							'id'		=> $id))
						);
					}
				}

				$error = array();
				// Form is submitted
				if ($request->is_set_post('submit'))
				{
					if (!check_form_key('acp_paypal'))

					{
						trigger_error($user->lang('FORM_INVALID') . adm_back_link($this->u_action), E_USER_WARNING);
					}

					$data['paypal_email'] = $request->variable('paypal_email', '', true);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
					$data['paypal_sandbox'] = $request->variable('paypal_sandbox', 0);
					$data['paypal_currency'] = $request->variable('paypal_currency', '');
					$data['paypal_title'] = $request->variable('paypal_title', '', true);
					$data['paypal_text'] = $request->variable('paypal_text', '', true);

					// Validate user input
					$validate_array = array(
						'paypal_email'				=> array('email'),
						'paypal_title'				=> array('string', true, 0, 255),
					);

					if (!function_exists('validate_data'))
					{
						include($this->phpbb_root_path . 'includes/functions_user.' . $this->php_ext);
					}
					$error = validate_data($data, $validate_array);

					if (!sizeof($error))
					{
						$bbcode_options = 7;
						generate_text_for_storage($data['paypal_text'], $bbcode_uid, $bbcode_bitfield, $bbcode_options, true, true, true);


						$sql_data = array(
							'paypal_email'				=> $data['paypal_email'],
							'paypal_title'				=> $data['paypal_title'],
							'paypal_currency'			=> $data['paypal_currency'],
							'paypal_text'				=> $data['paypal_text'],
							'bbcode_uid'				=> $bbcode_uid,
							'bbcode_bitfield'			=> $bbcode_bitfield,
							'paypal_sandbox'			=> $data['paypal_sandbox'],
						);
						$sql = 'UPDATE ' . $table_prefix . 'paypal_config SET
							' . $db->sql_build_array('UPDATE', $sql_data);

						$db->sql_query($sql);
						trigger_error($user->lang('ACP_SAVED') . adm_back_link($this->u_action));
					}
					else
					{
						$template->assign_vars(array(
							'ERROR'						=> implode('<br />', $error),
							'U_ACTION'					=> $this->u_action,
							'PAYPAL_EMAIL'				=> $data['paypal_email'],
							'PAYPAL_TITLE'				=> $data['paypal_title'],
							'PAYPAL_SANDBOX'			=> $data['paypal_sandbox'],
							'PAYPAL_TEXT'				=> $data['paypal_text'],
							'CURRENCY_CODE'				=> $this->currency_code_select($data['paypal_currency']),
						));
					}
				}

				// Form is submitted
				if ($request->is_set_post('submit_amount'))
				{
					$add_amount = $request->variable('add_amount', 0);
					$sql_data = array(
						'amount_value'			=> $add_amount,
					);
					$sql = 'INSERT INTO ' . $table_prefix . 'paypal_amount
						' . $db->sql_build_array('INSERT', $sql_data);
					$db->sql_query($sql);
					trigger_error($user->lang('ACP_SAVED') . adm_back_link($this->u_action));
				}

				$sql = 'SELECT *
					FROM ' . $table_prefix . 'paypal_amount
					ORDER BY amount_value';
				$result = $db->sql_query($sql);
				while ($row = $db->sql_fetchrow($result))
				{
					$template->assign_block_vars('amounts', array(
						'AMOUNT'		=> number_format($row['amount_value'] / 100, 2),
						'U_DELETE'	=> $this->u_action . '&delete=' . $row['amount_id'],
					));
				}

				if (!sizeof($error))
				{
					$paypal_text = generate_text_for_edit($paypal_config['paypal_text'], $paypal_config['bbcode_uid'], $paypal_config['bbcode_bitfield']);

					$template->assign_vars(array(
						'U_ACTION'					=> $this->u_action,
						'PAYPAL_EMAIL'				=> $paypal_config['paypal_email'],
						'PAYPAL_TITLE'				=> $paypal_config['paypal_title'],
						'PAYPAL_SANDBOX'			=> $paypal_config['paypal_sandbox'],
						'PAYPAL_TEXT'				=> $paypal_text['text'],
						'CURRENCY_CODE'				=> $this->currency_code_select($paypal_config['paypal_currency']),
					));
				}

				break;

			case 'items':
				$this->tpl_name = 'acp_paypal_items_body';
				$this->page_title = $user->lang('ACP_PAYPAL_ITEMS');

				$item_id = $request->variable('item_id', 0);
				$action    = $request->variable('action', '');
				switch ($action)
				{
					case 'add':
						add_form_key('acp_paypal');
						$template->assign_vars(array(
							'ITEM_FORM_NAME'		=> $this->user->lang('ACP_ADD_ITEM'),
							'U_ACTION'				=> $this->u_action . '&amp;action=add',
							'S_FORM'				=> true,
							'ITEM_NAME'				=> $request->variable('item_name', '', true),
						));
						break;

					case 'edit':
						add_form_key('acp_paypal');
						$sql = 'SELECT *
							FROM ' . $table_prefix . 'paypal_items
							WHERE item_id = ' . (int) $item_id;
						$result = $db->sql_query($sql);
						$data = $db->sql_fetchrow($result);

						$item_text = generate_text_for_edit($data['item_text'], $data['bbcode_uid'], $data['bbcode_bitfield']);

						$template->assign_vars(array(
							'ITEM_FORM_NAME'		=> $this->user->lang('ACP_EDIT_ITEM'),
							'U_ACTION'				=> $this->u_action . '&amp;action=edit&amp;item_id=' . $data['item_id'],
							'S_FORM'				=> true,
							'ITEM_NAME'				=> $data['item_name'],
							'ITEM_TEXT'				=> $item_text['text'],
						));
						break;

					case 'delete':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

						if (confirm_box(true))
						{
							$sql = 'DELETE FROM ' . $table_prefix . 'paypal_items WHERE item_id = ' . (int) $item_id;
							$result = $db->sql_query($sql);
							trigger_error($user->lang['ITEM_DELETED'] . adm_back_link($this->u_action));
						}
						else
						{
							confirm_box(false, $user->lang['CONFIRM_OPERATION'], build_hidden_fields(array(
								'action'		=> 'delete',
								'i'				=> $id,
								'item_id'		=> $item_id))
							);
						}

						break;
				}
				switch ($action)
				{
					case 'add':
					case 'edit':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

						// Form is submitted
						if ($request->is_set_post('submit'))
						{
							if (!check_form_key('acp_paypal'))

							{
								trigger_error($user->lang('FORM_INVALID') . adm_back_link($this->u_action), E_USER_WARNING);
							}
							$data['item_name'] = $request->variable('item_name', '', true);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
							$data['item_text'] = $request->variable('item_text', '', true);

							// Validate user input
							$validate_array = array(
								'item_name'				=> array('string', false, 1, 255),
								'item_text'				=> array('string', false, 1, 99999),
							);

							if (!function_exists('validate_data'))
							{
								include($this->phpbb_root_path . 'includes/functions_user.' . $this->php_ext);
							}
							$error = validate_data($data, $validate_array);
							if (!sizeof($error))
							{
								$bbcode_options = 7;
								generate_text_for_storage($data['item_text'], $bbcode_uid, $bbcode_bitfield, $bbcode_options, true, true, true);
								$sql_data = array(
									'item_name'			=> $data['item_name'],
									'item_text'			=> $data['item_text'],
									'bbcode_uid'		=> $bbcode_uid,
									'bbcode_bitfield'	=> $bbcode_bitfield,
								);
								if ($action == 'add')
								{
									$sql = 'INSERT INTO ' . $table_prefix . 'paypal_items
										' . $db->sql_build_array('INSERT', $sql_data);
									$db->sql_query($sql);
									trigger_error($user->lang('ACP_ITEM_ADD_SUCCESS') . adm_back_link($this->u_action));
								}
								else if ($action == 'edit')
								{
									$sql = 'UPDATE ' . $table_prefix . 'paypal_items SET
										' . $db->sql_build_array('UPDATE', $sql_data) .'
										WHERE item_id = ' . (int) $item_id;
									$db->sql_query($sql);
									trigger_error($user->lang('ACP_ITEM_EDIT_SUCCESS') . adm_back_link($this->u_action));
								}
							}
							else
							{
								$template->assign_vars(array(
									'ERROR'			=> implode('<br />', $error),
									'ITEM_NAME'		=> $data['item_name'],
									'ITEM_TEXT'		=> $data['item_text'],
								));
							}
						}
						break;

					default:
						$ammount = array();
						$sql = 'SELECT item_id, donation_amount
							FROM ' . $table_prefix . 'paypal_donations
							ORDER BY item_name';
						$result = $db->sql_query($sql);
						while ($row = $db->sql_fetchrow($result))
						{
							if (isset($ammount[$row['item_id']]))
							{
								$ammount[$row['item_id']] += $row['donation_amount'];
							}
							else
							{
								$ammount[$row['item_id']] = $row['donation_amount'];
							}
						}

						$sql = 'SELECT item_name, item_id
							FROM ' . $table_prefix . 'paypal_items
							ORDER BY item_name';
						$result = $db->sql_query($sql);
						while ($row = $db->sql_fetchrow($result))
						{
							$template->assign_block_vars('items', array(
								'ITEM'		=> $row['item_name'],
								'AMMOUNT'	=> (isset($ammount[$row['item_id']]) ? number_format($ammount[$row['item_id']], 2) : '0.00') . ' ' . $paypal_config['paypal_currency'],
								'U_EDIT'	=> $this->u_action . '&amp;action=edit&amp;item_id=' . $row['item_id'],
								'U_DELETE'	=> $this->u_action . '&amp;action=delete&amp;item_id=' . $row['item_id'],
							));
						}
						$template->assign_vars(array(
								'U_ACTION'					=> $this->u_action . '&amp;action=add',
						));

						break;
				}

				break;

			case 'donations':
				$this->tpl_name = 'acp_paypal_donations_body';
				$this->page_title = $user->lang('ACP_PAYPAL_DONATIONS');

				$action    = $request->variable('action', '');
				if ($action == 'delete')

				{
					$donation_id = $request->variable('donation_id', 0);
					if (confirm_box(true))
					{
						$sql = 'DELETE FROM ' . $table_prefix . 'paypal_donations WHERE donation_id = ' . (int) $donation_id;
						$result = $db->sql_query($sql);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
						trigger_error($user->lang['DONATION_DELETED'] . adm_back_link($this->u_action));
					}
					else
					{
						confirm_box(false, $user->lang['CONFIRM_OPERATION'], build_hidden_fields(array(
							'action'		=> 'delete',
							'i'				=> $id,
							'donation_id'	=> $donation_id))
						);
					}
				}

				$sql_array = array(
					'SELECT'		=> 'd.*, u.user_id, u.username, u.user_colour, i.item_name',
					'FROM'			=> array($table_prefix . 'paypal_donations' => 'd'),
					'LEFT_JOIN'		=> array(
						array(
							'FROM'		=> array(USERS_TABLE => 'u'),
							'ON'		=> 'u.user_id = d.user_id'
						),
						array(
							'FROM'		=> array($table_prefix . 'paypal_items' => 'i'),
							'ON'		=> 'i.item_id = d.item_id'
						)
					),
					'ORDER_BY'		=> 'd.donation_time DESC',
				);
				$sql = $db->sql_build_query('SELECT', $sql_array);
				$result = $db->sql_query($sql);
				while ($row = $db->sql_fetchrow($result))
				{
					$template->assign_block_vars('donations', array(
						'USER'		=> get_username_string('full', $row['user_id'], $row['username'], $row['user_colour']),
						'ITEM'		=> $row['item_name'],
						//'USER'		=> $row['item_name'],

						'TIME'		=> $this->user->format_date($row['donation_time']),
						'AMOUNT'	=> number_format($row['donation_amount'], 2) . ' ' . $paypal_config['paypal_currency'],
						'U_DELETE'	=> $this->u_action . '&amp;action=delete&amp;donation_id=' . $row['donation_id'],
					));
				}
				$template->assign_vars(array(
					'S_CURL'					=> function_exists('curl_init'),
				));
				break;
		}
	}

	private function currency_code_select($sel)
	{
		global $user;
function myFunction($a, $b) {
    // Do something
}
		$codes = array(
			'AUD'	=> $user->lang('DONATION_AUD'),
			'CAD'	=> $user->lang('DONATION_CAD'),
			'CHF'		=> $user->lang('DONATION_CHF'),
			'CZK'		=> $user->lang('DONATION_CZK'),
			'DKK'		=> $user->lang('DONATION_DKK'),
			'EUR'		=> $user->lang('DONATION_EUR'),
			'GBP'	=> $user->lang('DONATION_GBP'),
			'HKD'	=> $user->lang('DONATION_HKD'),
			'HUF'		=> $user->lang('DONATION_HUF'),
			'ILS'		=> $user->lang('DONATION_ILS'),
			'JPY'		=> $user->lang('DONATION_JPY'),
			'MXN'	=> $user->lang('DONATION_MXN'),
			'NOK'	=> $user->lang('DONATION_NOK'),
			'NZD'	=> $user->lang('DONATION_NZD'),
			'PLN'		=> $user->lang('DONATION_PLN'),
			'SEK'		=> $user->lang('DONATION_SEK'),
			'SGD'	=> $user->lang('DONATION_SGD'),
			'USD'	=> $user->lang('DONATION_USD'),
		);

		$retrun = '';
		foreach ($codes as $value => $title)

		{
			$selected = ($value == $sel) ? ' selected="selected"' : '';
			$retrun .= '<option value="' . $value . '"' . $selected . '>' . $title . '</option>';
		}
		return $retrun;
	}
}


Issues (32)

Security Analysis no request data

acp/paypal_module.php (20 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/**
3			*
4			* @package phpBB Extension - tas2580 Paypal
5			* @copyright (c) 2015 tas2580 (https://tas2580.net)
6			* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
7			*
8			*/
9
10			namespace tas2580\paypal\acp;
11
12			class paypal_module
13			{
14			var $u_action;
			0 ignored issues – show Coding Style introduced 2016-05-19 23:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The visibility should be declared for property `$u_action`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
15
16			/** @var \phpbb\user */
17			protected $user;
18
19			public function main($id, $mode)
20			{
21			global $config, $db, $user, $template, $table_prefix, $request, $phpbb_root_path, $phpEx;
			0 ignored issues – show Compatibility Best Practice introduced 2016-05-19 23:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
22
23			$this->user = $user;
24			$this->phpbb_root_path = $phpbb_root_path;
			0 ignored issues – show Bug introduced 2016-05-19 23:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `phpbb_root_path` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25			$this->php_ext = $phpEx;
			0 ignored issues – show Bug introduced 2016-05-19 23:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `php_ext` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26
27			$user->add_lang_ext('tas2580/paypal', 'common');
28
29			$sql = 'SELECT *
30			FROM ' . $table_prefix . 'paypal_config';
31			$result = $db->sql_query($sql);
32			$paypal_config = $db->sql_fetchrow($result);
33
34			switch ($mode)
35			{
36			case 'settings':

tas2580 / paypal

Issues (32)

Security Analysis no request data

acp/paypal_module.php (20 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like