Issues in functional.php - New Issues - Inspection of "Rewritten most of the functions to made them more..." - tarsana/functional - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by Amine

created 2017-01-05 14:48 UTC

performance/scripts/functional.php (12 issues)

Labels

Severity

Minor 12

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1			<?php
2			require __DIR__.'/../../vendor/autoload.php';
3
4			use Tarsana\Functional as F;
5			use Tarsana\Functional\Stream;
6
7			Stream::operation('read', 'String -> String', 'file_get_contents');
8			Stream::operation('write', 'String -> String -> Any', 'file_put_contents');
9			Stream::operation('trim', 'String -> String');
10			Stream::operation('countValues', 'List\|Array -> Array', 'array_count_values');
11
12			// Stream::of(__DIR__.'/../tests/10k-words.input.txt')
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-05 11:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
13			Stream::of('php://stdin')
			0 ignored issues – show Documentation Bug introduced 2017-01-05 11:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `read` does not exist on `object<Tarsana\Functional\Stream>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
14			->read() // ' lorem, ipsum ...'
15			->regReplace('/[^a-zA-Z0-9]+/', ' ') // ' lorem ipsum ...'
16			->trim() // 'lorem ipsum ...'
17			->split(' ') // ['lorem', 'ipsum', ...]
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-05 11:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
18			->countValues() // ['lorem' => 2, 'ipsum' => 3, ...]
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-05 11:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `62%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
19			->toPairs() // [['lorem', 2], ['ipsum', 3], ...]
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-05 11:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
20			->groupBy(F\get(1)) // [2 => [['lorem', 2], ...], 3 => [['ipsum', 3], ...]]
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-05 11:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
21			->map(F\map(F\get(0))) // [2 => ['lorem', 'foo', ...], 3 => ['ipsum', ...]]
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-05 11:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `68%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
22			->map(F\sort(function($w1, $w2) { // [2 => ['foo', 'lorem', ...], 3 => ['bar', 'ipsum', ...]]
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-05 11:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `68%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
23			return strcmp($w1, $w2) < 0;
24			}))
25			->toPairs() // [[2, ['foo', 'lorem', ...]], [3, ['bar', 'ipsum', ...]], ...]
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-05 11:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
26			->sort(function($pair1, $pair2) { // [[3, ['bar', 'ipsum', ...]], [2, ['foo', 'lorem', ...]], ...]
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-05 11:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
27			return F\get(0, $pair2) < F\get(0, $pair1);
28			})
29			->map(function($pair) { // ['3: bar, ipsum, ...', '2: foo, lipsum, ...']
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-05 11:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
30			return F\get(0, $pair) . ': ' . F\join(', ', F\get(1, $pair));
31			})
32			->join("\n")
33			// ->write(__DIR__.'/../tests/output.txt')
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-05 11:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
34			->write('php://stdout')
35			->result();
36

tarsana / functional

Pull Request — master (#3)

performance/scripts/functional.php (12 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like