Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php namespace Tarsana\Command\Examples\Tests; |
||
7 | class RepeatCommandTest extends CommandTestCase { |
||
8 | |||
9 | public function test_it_repeats_word_three_times() |
||
10 | { |
||
11 | $this->command(new RepeatCommand, ['foo']) |
||
12 | ->argsEqual((object) [ |
||
13 | 'word' => 'foo', |
||
14 | 'count' => 3 |
||
15 | ]) |
||
16 | ->optionsEqual([ |
||
17 | '--upper' => false |
||
18 | ]) |
||
19 | ->printsExactly("foofoofoo<br>"); |
||
20 | } |
||
21 | |||
22 | View Code Duplication | public function test_it_repeats_word_n_times() |
|
34 | |||
35 | View Code Duplication | public function test_it_repeats_word_n_times_uppercase() |
|
47 | |||
48 | View Code Duplication | public function test_it_runs_interatively() |
|
61 | |||
62 | } |
||
63 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.