CommandTestCase::command() - Code Metrics - Inspection of "Full rewriting of the library" - tarsana/command - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by Amine

created 2017-09-02 17:49 UTC

CommandTestCase::command() A

↳ Parent: CommandTestCase

Complexity

Conditions	1
Paths	1

Size

Total Lines	22
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	22
rs	9.2
c	0
b	0
f	0
cc	1
eloc	16
nc	1
nop	4

<?php namespace Tarsana\Tester;

use PHPUnit\Framework\TestCase;
use Tarsana\Command\Command;
use Tarsana\Command\Console\Console;
use Tarsana\Command\Interfaces\Console\TransformerInterface;
use Tarsana\IO\Filesystem;
use Tarsana\IO\Filesystem\Adapters\Memory;
use Tarsana\IO\Resource\Buffer;

class Transformer implements TransformerInterface {
    public function transform(string $text) : string
    {
        return $text;
    }
    public function alias(string $name, string $value) : Transformer

    {
        return $this;
    }
}

class CommandTestCase extends TestCase {


    protected $fs;
    protected $cmd;
    protected $stdout;
    protected $stderr;

    public function setUp() {
        $adapter = new Memory;
        $adapter->mkdir('.', 0777, true);
        $this->fs = new Filesystem('.', $adapter);
    }

    public function command(
        Command $command, array $args = [],
        array $options = [], bool $rawArgs = true
    ) {
        $console = (new Console)
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->stdin(new Buffer)
            ->stdout(new Buffer)
            ->stderr(new Buffer)
            ->outTransformer(new Transformer);

        $this->fs->dir($command->fs()->path(), true);

        $command->console($console)
                ->fs($this->fs)
                ->run($args, $options, $rawArgs);

        $this->cmd    = $command;
        $this->stdout = $console->stdout()->read();
        $this->stderr = $console->stderr()->read();

        return $this;
    }

    public function prints(string $text) {
        $this->assertTrue(
            false !== strpos($this->stdout, $text),
            "Failed asserting that '{$this->stdout}' Contains '{$text}'"
        );
        return $this;
    }

    public function printsExactly(string $text) {
        $this->assertEquals($text, $this->stdout);
        return $this;
    }

    public function printsError(string $text) {
        $this->assertTrue(
            false !== strpos($this->stderr, $text),
            "Failed asserting that '{$this->stderr}' Contains '{$text}'"
        );
        return $this;
    }

    public function argsEqual($args) {
        $this->assertEquals($args, $this->cmd->args());
        return $this;
    }

    public function optionsEqual($options) {
        $this->assertEquals($options, $this->cmd->options());
        return $this;
    }
}


1			<?php namespace Tarsana\Tester;
2
3			use PHPUnit\Framework\TestCase;
4			use Tarsana\Command\Command;
5			use Tarsana\Command\Console\Console;
6			use Tarsana\Command\Interfaces\Console\TransformerInterface;
7			use Tarsana\IO\Filesystem;
8			use Tarsana\IO\Filesystem\Adapters\Memory;
9			use Tarsana\IO\Resource\Buffer;
10
11			class Transformer implements TransformerInterface {
12			public function transform(string $text) : string
13			{
14			return $text;
15			}
16			public function alias(string $name, string $value) : Transformer
			0 ignored issues – show Unused Code introduced 2017-09-02 17:31 UTC by Report Bug Copy Issue Report The parameter `$name` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-09-02 17:31 UTC by Report Bug Copy Issue Report The parameter `$value` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
17			{
18			return $this;
19			}
20			}
21
22			class CommandTestCase extends TestCase {
			0 ignored issues – show Coding Style Compatibility introduced 2017-09-02 17:31 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
23
24			protected $fs;
25			protected $cmd;
26			protected $stdout;
27			protected $stderr;
28
29			public function setUp() {
30			$adapter = new Memory;
31			$adapter->mkdir('.', 0777, true);
32			$this->fs = new Filesystem('.', $adapter);
33			}
34
35			public function command(
36			Command $command, array $args = [],
37			array $options = [], bool $rawArgs = true
38			) {
39			$console = (new Console)
			0 ignored issues – show Bug introduced 2017-09-02 17:31 UTC by Report Bug Copy Issue Report The method `stdout` does only exist in `Tarsana\Command\Console\Console`, but not in `Tarsana\IO\Resource\Reader`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
40			->stdin(new Buffer)
41			->stdout(new Buffer)
42			->stderr(new Buffer)
43			->outTransformer(new Transformer);
44
45			$this->fs->dir($command->fs()->path(), true);
46
47			$command->console($console)
48			->fs($this->fs)
49			->run($args, $options, $rawArgs);
50
51			$this->cmd = $command;
52			$this->stdout = $console->stdout()->read();
53			$this->stderr = $console->stderr()->read();
54
55			return $this;
56			}
57
58			public function prints(string $text) {
59			$this->assertTrue(
60			false !== strpos($this->stdout, $text),
61			"Failed asserting that '{$this->stdout}' Contains '{$text}'"
62			);
63			return $this;
64			}
65
66			public function printsExactly(string $text) {
67			$this->assertEquals($text, $this->stdout);
68			return $this;
69			}
70
71			public function printsError(string $text) {
72			$this->assertTrue(
73			false !== strpos($this->stderr, $text),
74			"Failed asserting that '{$this->stderr}' Contains '{$text}'"
75			);
76			return $this;
77			}
78
79			public function argsEqual($args) {
80			$this->assertEquals($args, $this->cmd->args());
81			return $this;
82			}
83
84			public function optionsEqual($options) {
85			$this->assertEquals($options, $this->cmd->options());
86			return $this;
87			}
88			}
89

tarsana / command

Pull Request — master (#3)

CommandTestCase::command() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like