tarlepp / symfony-flex-backend

src/Security/RolesService.php

<?php
declare(strict_types = 1);
/**
 * /src/Security/RolesService.php
 *
 * @author TLe, Tarmo Leppänen <tarmo.leppanen@pinja.com>
 */

namespace App\Security;

use App\Enum\Role;
use App\Security\Interfaces\RolesServiceInterface;
use BackedEnum;
use Symfony\Component\Security\Core\Role\RoleHierarchyInterface;
use function array_map;
use function array_unique;
use function array_values;
use function mb_strtolower;

/**
 * Class RolesService
 *
 * @package App\Security
 * @author TLe, Tarmo Leppänen <tarmo.leppanen@pinja.com>
 */
class RolesService implements RolesServiceInterface
{
    public function __construct(
        private readonly RoleHierarchyInterface $roleHierarchy,
    ) {
    }

    public function getRoles(): array
    {
        return array_map(static fn (BackedEnum $enum): string => $enum->value, Role::cases());

Accessing value on the interface BackedEnum suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function getRoleLabel(string $role): string
    {
        $enum = Role::tryFrom($role);

        return $enum instanceof Role
            ? $enum->label()
            : 'Unknown - ' . $role;
    }

    public function getShort(string $role): string
    {
        $enum = Role::tryFrom($role);

        return $enum instanceof Role
            ? mb_strtolower($enum->name)

The property name does not seem to exist on App\Enum\Role.

            : 'Unknown - ' . $role;
    }

    public function getInheritedRoles(array $roles): array
    {
        return array_values(array_unique($this->roleHierarchy->getReachableRoleNames($roles)));
    }
}