tarfin-labs / netgsm

src/NetgsmChannel.php

<?php

namespace TarfinLabs\Netgsm;

use Exception;
use GuzzleHttp\Exception\GuzzleException;
use Illuminate\Notifications\Notification;
use TarfinLabs\Netgsm\Exceptions\IncorrectPhoneNumberFormatException;
use TarfinLabs\Netgsm\Sms\AbstractNetgsmMessage;

class NetgsmChannel
{
    protected $netgsm;

    public function __construct(Netgsm $netgsm)
    {
        $this->netgsm = $netgsm;
    }

    /**
     * Send the given notification.
     *
     * @param              $notifiable
     * @param Notification $notification
     * @throws Exceptions\CouldNotSendNotification
     * @throws GuzzleException
     * @throws IncorrectPhoneNumberFormatException
     * @throws Exception
     */
    public function send($notifiable, Notification $notification)
    {
        $message = $notification->toNetgsm($notifiable);

The method toNetgsm() does not exist on Illuminate\Notifications\Notification.

        if (! $message instanceof AbstractNetgsmMessage) {
            throw new Exception(trans('netgsm::errors.invalid_netgsm_message'));

It seems like trans('netgsm::errors.invalid_netgsm_message') can also be of type array and array; however, parameter $message of Exception::__construct() does only seem to accept string, maybe add an additional type check?

        }

        if (! $message->getRecipients()) {
            $phone = $notifiable->routeNotificationFor('Netgsm');
            $message->setRecipients($phone);
        }

        $this->netgsm->sendSms($message);
    }
}