Cleaner::validateOptions() - Code Metrics - Inspection of "options validation test" - tarantool-php/symfony-lock - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d9c8cf...7342b9 )

by Dmitry

created 2020-06-24 11:54 UTC

Cleaner::validateOptions() A

↳ Parent: Cleaner

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	7
c	0
b	0
f	0
nc	3
nop	0
dl	0
loc	11
ccs	8
cts	8
cp	1
crap	3
rs	10

<?php

namespace Tarantool\SymfonyLock;

use Tarantool\Client\Client;
use InvalidArgumentException;

class Cleaner
{
    use OptionalConstructor;

    /**
     * Dropped rows counter limit
     */
    protected int $limit = 100;

    /**
     * Space name
     */
    protected string $space = 'lock';

    protected function validateOptions()
    {
        if ($this->limit <= 0) {
            $message = sprintf(
                'Limit expects a strictly positive. Got %d.',
                $this->limit
            );
            throw new InvalidArgumentException($message);
        }
        if ($this->space == '') {
            throw new InvalidArgumentException("Space should be defined");
        }
    }

    public function process(): int
    {
        $script = <<<LUA
        local limit, timestamp = ...
        local counter = 0
        box.begin()
        box.space.$this->space.index.expire:pairs()
            :take_while(function(tuple) return counter < limit end)
            :take_while(function(tuple) return tuple.expire <= timestamp end)
            :each(function(tuple)
                box.space.$this->space:delete( tuple.key )
                counter = counter + 1
            end)
        box.commit()
        return counter
        LUA;

        [$counter] = $this->client->evaluate($script, $this->limit, microtime(true));

        return $counter;
    }
}


1		<?php
2
3		namespace Tarantool\SymfonyLock;
4
5		use Tarantool\Client\Client;
6		use InvalidArgumentException;
7
8		class Cleaner
9		{
10		use OptionalConstructor;
11
12		/**
13		* Dropped rows counter limit
14		*/
15		protected int $limit = 100;
16
17		/**
18		* Space name
19		*/
20		protected string $space = 'lock';
21
22	4	protected function validateOptions()
23		{
24	4	if ($this->limit <= 0) {
25	1	$message = sprintf(
26	1	'Limit expects a strictly positive. Got %d.',
27	1	$this->limit
28		);
29	1	throw new InvalidArgumentException($message);
30		}
31	3	if ($this->space == '') {
32	1	throw new InvalidArgumentException("Space should be defined");
33		}
34	2	}
35
36	2	public function process(): int
37		{
38		$script = <<<LUA
39	2	local limit, timestamp = ...
40		local counter = 0
41		box.begin()
42	2	box.space.$this->space.index.expire:pairs()
43		:take_while(function(tuple) return counter < limit end)
44		:take_while(function(tuple) return tuple.expire <= timestamp end)
45		:each(function(tuple)
46	2	box.space.$this->space:delete( tuple.key )
47		counter = counter + 1
48		end)
49		box.commit()
50		return counter
51		LUA;
52
53	2	[$counter] = $this->client->evaluate($script, $this->limit, microtime(true));
54
55	2	return $counter;
56		}
57		}
58

tarantool-php / symfony-lock

Push — master ( d9c8cf...7342b9 )

Cleaner::validateOptions() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like