Schema::getSpaceName() - Code Metrics - Inspection of "cleanup composer file, added property guard" - tarantool-php/mapper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (eb6d5f)

by Dmitry

created 2016-04-04 18:53 UTC

Schema::getSpaceName() A

↳ Parent: Schema

Complexity

Conditions	4
Paths	6

Size

Total Lines	14
Code Lines	8

Duplication

Lines	14
Ratio	100 %

Code Coverage

Tests	4
CRAP Score	8.1239

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	14
loc	14
ccs	4
cts	11
cp	0.3636
rs	9.2
cc	4
eloc	8
nc	6
nop	1
crap	8.1239

<?php

namespace Tarantool\Mapper\Schema;

use Tarantool\Client;
use Tarantool\Mapper\Contracts;
use Tarantool\Schema\Space;
use Tarantool\Schema\Index;

class Schema implements Contracts\Schema
{
    protected $client;
    protected $spaceSpace;
    protected $indexSpace;
    protected $spaceId = [];

    public function __construct(Client $client)
    {
        $this->client = $client;

        $this->spaceSpace = $client->getSpace('_vspace');
        $this->indexSpace = $client->getSpace('_vindex');
    }

    public function getSpaceId($space)

    {
        if (!array_key_exists($space, $this->spaceId)) {
            $response = $this->spaceSpace->select([$space], Index::SPACE_NAME);
            $data = $response->getData();
            if (!empty($data)) {
                $this->spaceId[$space] = $data[0][0];
            }
        }
        if (array_key_exists($space, $this->spaceId)) {
            return $this->spaceId[$space];
        }
    }

    public function getSpaceName($spaceId)

    {
        if (!in_array($spaceId, $this->spaceId)) {
            $response = $this->spaceSpace->select([$spaceId], 0);
            $data = $response->getData();
            if (!empty($data)) {
                $this->spaceId[$data[0][2]] = $spaceId;
            }
        }

        if (in_array($spaceId, $this->spaceId)) {
            return array_search($spaceId, $this->spaceId);
        }
    }

    public function hasSpace($space)
    {
        return $this->getSpaceId($space) !== null;
    }

    public function createSpace($space)
    {
        $this->client->evaluate("box.schema.space.create('$space')");
    }

    public function hasIndex($space, $index)
    {
        $spaceId = $this->getSpaceId($space);
        $response = $this->indexSpace->select([$spaceId, $index], Index::INDEX_NAME);

        return !empty($response->getData());
    }

    public function listIndexes($space)
    {
        $result = [];
        $response = $this->indexSpace->select([$this->getSpaceId($space)], Index::INDEX_NAME);

        foreach ($response->getData() as $row) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $result[$row[2]] = [];
            foreach ($row[5] as $f) {
                $result[$row[2]][] = $f[0];
            }
        }

        return $result;
    }

    public function createIndex($space, $index, array $arguments)
    {
        $config = [];
        foreach ($arguments as $k => $v) {
            if (is_array($v)) {
                // convert to lua array
                $v = str_replace(['[', ']'], ['{', '}'], json_encode($v));
            }
            if (is_bool($v)) {
                $v = $v ? 'true' : 'false';
            }
            $config[] = $k.' = '.$v;
        }
        $config = '{'.implode(', ', $config).'}';
        $this->client->evaluate("box.space.$space:create_index('$index', $config)");
    }
}


1			<?php
2
3			namespace Tarantool\Mapper\Schema;
4
5			use Tarantool\Client;
6			use Tarantool\Mapper\Contracts;
7			use Tarantool\Schema\Space;
8			use Tarantool\Schema\Index;
9
10			class Schema implements Contracts\Schema
11			{
12			protected $client;
13			protected $spaceSpace;
14			protected $indexSpace;
15			protected $spaceId = [];
16
17	22		public function __construct(Client $client)
18			{
19	22		$this->client = $client;
20
21	22		$this->spaceSpace = $client->getSpace('_vspace');
22	22		$this->indexSpace = $client->getSpace('_vindex');
23	22		}
24
25	22	View Code Duplication	public function getSpaceId($space)
			0 ignored issues – show Duplication introduced 2016-04-04 18:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
26			{
27	22		if (!array_key_exists($space, $this->spaceId)) {
28	22		$response = $this->spaceSpace->select([$space], Index::SPACE_NAME);
29	22		$data = $response->getData();
30	22		if (!empty($data)) {
31	22		$this->spaceId[$space] = $data[0][0];
32	22		}
33	22		}
34	22		if (array_key_exists($space, $this->spaceId)) {
35	22		return $this->spaceId[$space];
36			}
37	22		}
38
39	1	View Code Duplication	public function getSpaceName($spaceId)
			0 ignored issues – show Duplication introduced 2016-04-04 18:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
40			{
41	1		if (!in_array($spaceId, $this->spaceId)) {
42			$response = $this->spaceSpace->select([$spaceId], 0);
43			$data = $response->getData();
44			if (!empty($data)) {
45			$this->spaceId[$data[0][2]] = $spaceId;
46			}
47			}
48
49	1		if (in_array($spaceId, $this->spaceId)) {
50	1		return array_search($spaceId, $this->spaceId);
51			}
52			}
53
54	22		public function hasSpace($space)
55			{
56	22		return $this->getSpaceId($space) !== null;
57			}
58
59	22		public function createSpace($space)
60			{
61	22		$this->client->evaluate("box.schema.space.create('$space')");
62	22		}
63
64	22		public function hasIndex($space, $index)
65			{
66	22		$spaceId = $this->getSpaceId($space);
67	22		$response = $this->indexSpace->select([$spaceId, $index], Index::INDEX_NAME);
68
69	22		return !empty($response->getData());
70			}
71
72	22		public function listIndexes($space)
73			{
74	22		$result = [];
75	22		$response = $this->indexSpace->select([$this->getSpaceId($space)], Index::INDEX_NAME);
76
77	22		foreach ($response->getData() as $row) {
			0 ignored issues – show Bug introduced 2016-04-04 18:16 UTC by Report Bug Copy Issue Report The expression `$response->getData()` of type `null\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
78	22		$result[$row[2]] = [];
79	22		foreach ($row[5] as $f) {
80	22		$result[$row[2]][] = $f[0];
81	22		}
82	22		}
83
84	22		return $result;
85			}
86
87	22		public function createIndex($space, $index, array $arguments)
88			{
89	22		$config = [];
90	22		foreach ($arguments as $k => $v) {
91	22		if (is_array($v)) {
92			// convert to lua array
93	22		$v = str_replace(['[', ']'], ['{', '}'], json_encode($v));
94	22		}
95	22		if (is_bool($v)) {
96	22		$v = $v ? 'true' : 'false';
97	22		}
98	22		$config[] = $k.' = '.$v;
99	22		}
100	22		$config = '{'.implode(', ', $config).'}';
101	22		$this->client->evaluate("box.space.$space:create_index('$index', $config)");
102	22		}
103			}
104

tarantool-php / mapper

Branch — master (eb6d5f)

Schema::getSpaceName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like