Entity::__call() - Code Metrics - Inspection of "type convertion check added" - tarantool-php/mapper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 229d8c...e7f8de )

by Dmitry

created 2016-12-28 11:03 UTC

Entity::__call() A

↳ Parent: Entity

Complexity

Conditions	4
Paths	4

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	0
cts	10
cp	0
rs	9.2
c	0
b	0
f	0
cc	4
eloc	8
nc	4
nop	2
crap	20

<?php

namespace Tarantool\Mapper\Entities;

use LogicException;

class Entity implements \Tarantool\Mapper\Contracts\Entity
{
    private $id;


    public function __construct(array $data = null)
    {
        if ($data) {
            $this->update($data);
        }
    }

    public function update($data)
    {
        foreach ($data as $k => $v) {
            $this->$k = $v;
        }
    }

    public function __set($key, $value)
    {
        if ($key == 'id' && $this->getId()) {
            throw new LogicException('Id property is readonly');
        }

        $this->$key = $value;
    }

    public function __get($key)
    {
        if (property_exists($this, $key)) {
            return $this->$key;
        }
    }

    /**
     * @return int
     */
    public function getId()
    {
        return $this->__get('id');
    }

    /**
     * @return Entity
     */
    public function setId($id)
    {
        $this->__set('id', $id);

        return $this;
    }

    /**
     * @return array
     */
    public function toArray($recursive = false)
    {
        $array = [];
        foreach ($this as $k => $v) {

            $array[$k] = $v;
            if ($v instanceof Contracts\Entity) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
                $array[$k] = $v->toArray($recursive);
            }
        }

        return $array;
    }

    public function __call($name, $params)
    {
        if(strlen($name) > 3) {
            $property = substr($name, 3);
            $property[0] = strtolower($property[0]);
            if(strpos($name, 'get') === 0) {
                return $this->__get($property);
            }
            if(strpos($name, 'set') === 0) {
                return $this->__set($property, $params[0]);
            }
        }
    }
}


1		<?php
2
3		namespace Tarantool\Mapper\Entities;
4
5		use LogicException;
6
7		class Entity implements \Tarantool\Mapper\Contracts\Entity
8		{
9		private $id;
		0 ignored issues – show Unused Code introduced 2016-05-14 11:49 UTC by Report Bug Copy Issue Report The property `$id` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
10
11	1	public function __construct(array $data = null)
12		{
13	1	if ($data) {
14	1	$this->update($data);
15	1	}
16	1	}
17
18	1	public function update($data)
19		{
20	1	foreach ($data as $k => $v) {
21	1	$this->$k = $v;
22	1	}
23	1	}
24
25	1	public function __set($key, $value)
26		{
27	1	if ($key == 'id' && $this->getId()) {
28	1	throw new LogicException('Id property is readonly');
29		}
30
31	1	$this->$key = $value;
32	1	}
33
34	1	public function __get($key)
35		{
36	1	if (property_exists($this, $key)) {
37	1	return $this->$key;
38		}
39		}
40
41		/**
42		* @return int
43		*/
44	1	public function getId()
45		{
46	1	return $this->__get('id');
47		}
48
49		/**
50		* @return Entity
51		*/
52	1	public function setId($id)
53		{
54	1	$this->__set('id', $id);
55
56	1	return $this;
57		}
58
59		/**
60		* @return array
61		*/
62		public function toArray($recursive = false)
63		{
64		$array = [];
65		foreach ($this as $k => $v) {
		0 ignored issues – show Bug introduced 2016-08-01 16:55 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Tarantool\Mapper\Entities\Entity>` is not traversable. Loading history...
66		$array[$k] = $v;
67		if ($v instanceof Contracts\Entity) {
		0 ignored issues – show Bug introduced 2016-06-21 20:59 UTC by Report Bug Copy Issue Report The class `Tarantool\Mapper\Entities\Contracts\Entity` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
68		$array[$k] = $v->toArray($recursive);
69		}
70		}
71
72		return $array;
73		}
74
75		public function __call($name, $params)
76		{
77		if(strlen($name) > 3) {
78		$property = substr($name, 3);
79		$property[0] = strtolower($property[0]);
80		if(strpos($name, 'get') === 0) {
81		return $this->__get($property);
82		}
83		if(strpos($name, 'set') === 0) {
84		return $this->__set($property, $params[0]);
85		}
86		}
87		}
88		}
89

tarantool-php / mapper

Push — master ( 229d8c...e7f8de )

Entity::__call() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like