Tarantool\Mapper\Client

Complexity

Total Complexity

6

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

75%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	connect()	0	9	1
A	sendRequest()	0	9	1
A	log()	0	6	2
A	setLogging()	0	4	1
A	getLog()	0	4	1

<?php

namespace Tarantool\Mapper;

use Tarantool\Client\Connection\Connection;
use Tarantool\Client\Client as OriginalClient;
use Tarantool\Client\Request\Request;

class Client extends OriginalClient
{
    private $logging = true;
    private $log = [];

    public function connect()
    {
        $start = microtime(1);

        $result = parent::connect();

Are you sure the assignment to $result is correct as parent::connect() (which targets Tarantool\Client\Client::connect()) seems to always return null.

        $this->log($start, Connection::class);

        return $result;
    }

    public function sendRequest(Request $request)
    {
        $start = microtime(1);
        $response = parent::sendRequest($request);

        $this->log($start, get_class($request), $request->getBody(), $response->getData());

It seems like $response->getData() targeting Tarantool\Client\Response::getData() can also be of type null; however, Tarantool\Mapper\Client::log() does only seem to accept array, maybe add an additional type check?

        return $response;
    }

    private function log($start, $class, $request = [], $response = [])
    {
        if ($this->logging) {
            $this->log[] = new Event(microtime(1) - $start, $class, $request, $response);
        }
    }

    public function setLogging($logging)
    {
        $this->logging = $logging;
    }

    public function getLog()
    {
        return $this->log;
    }
}