Entity::__call() - Code Metrics - Inspection of "entity.sync shortcut" - tarantool-php/mapper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cc5af7...6c15a2 )

by Dmitry

created 2020-02-05 12:54 UTC

Entity::__call() B

↳ Parent: Entity

Complexity

Conditions	11
Paths	8

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	36
rs	7.3166
c	0
b	0
f	0
cc	11
nc	8
nop	2

How to fix Complexity

<?php

declare(strict_types=1);

namespace Tarantool\Mapper;

use BadMethodCallException;
use Exception;
use Tarantool\Mapper\Plugin\Annotation;

class Entity
{
    private $_repository;

    public function __construct(Repository $repository)
    {
        $this->_repository = $repository;
    }

    public function getRepository() : Repository
    {
        return $this->_repository;
    }

    public function save() : Entity
    {
        return $this->getRepository()->save($this);
    }

    public function __call($name, $arguments)
    {
        if (strpos($name, 'get') === 0) {
            $property = lcfirst(substr($name, 3));
            $mapper = $this->getRepository()->getMapper();
            if (property_exists($this, $property)) {
                $reference = $this->getRepository()->getSpace()->getReference($property);
                if ($reference) {
                    return $mapper->findOrFail($reference, [
                        'id' => $this->$property,
                    ]);
                }
            } else if(strpos($property, 'Collection') !== false) {
                $property = substr($property, 0, -10);
                $targetSpace = $mapper->getSchema()->toUnderscore($property);
                if ($mapper->getSchema()->hasSpace($targetSpace)) {
                    $localSpace = $this->getRepository()->getSpace()->getName();
                    $candidates = [];
                    foreach ($mapper->getSchema()->getSpace($targetSpace)->getFormat() as $row) {
                        if (array_key_exists('reference', $row) && $row['reference'] == $localSpace) {
                            $candidates[] = $row['name'];
                        }
                    }
                    if (count($candidates) == 1) {
                        return $mapper->find($targetSpace, [
                            $candidates[0] => $this->id
class MyClass { }

$x = new MyClass();
$x->foo = true;
                        ]);
                    }
                    if (count($candidates) > 1) {
                        throw new Exception("Multiple references from $targetSpace to $localSpace");
                    }
                }
            }
        }
        throw new BadMethodCallException("Call to undefined method ". get_class($this).'::'.$name);
    }

    public function sync() : Entity
    {
        return $this->getRepository()->sync($this->id);
    }

    public function __debugInfo()
    {
        $info = get_object_vars($this);

        unset($info['_repository']);

        if (array_key_exists('app', $info) && is_object($info['app'])) {
            unset($info['app']);
        }

        return $info;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Tarantool\Mapper;
6
7			use BadMethodCallException;
8			use Exception;
9			use Tarantool\Mapper\Plugin\Annotation;
10
11			class Entity
12			{
13			private $_repository;
14
15			public function __construct(Repository $repository)
16			{
17			$this->_repository = $repository;
18			}
19
20			public function getRepository() : Repository
21			{
22			return $this->_repository;
23			}
24
25			public function save() : Entity
26			{
27			return $this->getRepository()->save($this);
28			}
29
30			public function __call($name, $arguments)
31			{
32			if (strpos($name, 'get') === 0) {
33			$property = lcfirst(substr($name, 3));
34			$mapper = $this->getRepository()->getMapper();
35			if (property_exists($this, $property)) {
36			$reference = $this->getRepository()->getSpace()->getReference($property);
37			if ($reference) {
38			return $mapper->findOrFail($reference, [
39			'id' => $this->$property,
40			]);
41			}
42			} else if(strpos($property, 'Collection') !== false) {
43			$property = substr($property, 0, -10);
44			$targetSpace = $mapper->getSchema()->toUnderscore($property);
45			if ($mapper->getSchema()->hasSpace($targetSpace)) {
46			$localSpace = $this->getRepository()->getSpace()->getName();
47			$candidates = [];
48			foreach ($mapper->getSchema()->getSpace($targetSpace)->getFormat() as $row) {
49			if (array_key_exists('reference', $row) && $row['reference'] == $localSpace) {
50			$candidates[] = $row['name'];
51			}
52			}
53			if (count($candidates) == 1) {
54			return $mapper->find($targetSpace, [
55			$candidates[0] => $this->id
			0 ignored issues – show Bug introduced 2017-12-11 07:53 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
56			]);
57			}
58			if (count($candidates) > 1) {
59			throw new Exception("Multiple references from $targetSpace to $localSpace");
60			}
61			}
62			}
63			}
64			throw new BadMethodCallException("Call to undefined method ". get_class($this).'::'.$name);
65			}
66
67			public function sync() : Entity
68			{
69			return $this->getRepository()->sync($this->id);
70			}
71
72			public function __debugInfo()
73			{
74			$info = get_object_vars($this);
75
76			unset($info['_repository']);
77
78			if (array_key_exists('app', $info) && is_object($info['app'])) {
79			unset($info['app']);
80			}
81
82			return $info;
83			}
84			}
85

tarantool-php / mapper

Push — master ( cc5af7...6c15a2 )

Entity::__call() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like