Tarantool\Mapper\Schema\Schema

Complexity

Total Complexity

23

Size/Duplication

Total Lines	119
Duplicated Lines	22.69 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

98.72%

Importance

Changes	13
Bugs	0	Features	2

10 Methods

Rating	Name	Duplication	Size	Complexity
A	hasSpace()	0	4	1
A	createSpace()	0	4	1
A	dropSpace()	0	5	1
A	hasIndex()	0	7	1
A	dropIndex()	0	8	1
A	__construct()	0	12	2
A	getSpaceId()	13	13	4
A	listIndexes()	0	14	3
B	createIndex()	0	21	5
A	getSpaceName()	14	14	4

<?php

namespace Tarantool\Mapper\Schema;

use Tarantool\Client;
use Tarantool\Mapper\Contracts;
use Tarantool\Schema\Space;
use Tarantool\Schema\Index;

class Schema implements Contracts\Schema
{
    protected $client;
    protected $spaceSpace;
    protected $indexSpace;
    protected $spaceId = [];

    public function __construct(Client $client)
    {
        $this->client = $client;

        $this->spaceSpace = $client->getSpace('_vspace');
        $this->indexSpace = $client->getSpace('_vindex');
        $spaces = $this->spaceSpace->select([])->getData();
        foreach ($spaces as $row) {

The expression $spaces of type null|array is not guaranteed to be traversable. How about adding an additional type check?

            list($id, $sys, $name) = $row;

The assignment to $sys is unused. Consider omitting it like so list($first,,$third).

            $this->spaceId[$name] = $id;
        }
    }

    public function getSpaceId($space)

This method seems to be duplicated in your project.

    {
        if (!array_key_exists($space, $this->spaceId)) {
            $response = $this->spaceSpace->select([$space], Index::SPACE_NAME);
            $data = $response->getData();
            if (!empty($data)) {
                $this->spaceId[$space] = $data[0][0];
            }
        }
        if (array_key_exists($space, $this->spaceId)) {
            return $this->spaceId[$space];
        }
    }

    public function getSpaceName($spaceId)

This method seems to be duplicated in your project.

    {
        if (!in_array($spaceId, $this->spaceId)) {
            $response = $this->spaceSpace->select([$spaceId], 0);
            $data = $response->getData();
            if (!empty($data)) {
                $this->spaceId[$data[0][2]] = $spaceId;
            }
        }

        if (in_array($spaceId, $this->spaceId)) {
            return array_search($spaceId, $this->spaceId);
        }
    }

    public function hasSpace($space)
    {
        return $this->getSpaceId($space) !== null;
    }

    public function createSpace($space)
    {
        $this->client->evaluate("box.schema.space.create('$space')");
    }

    public function dropSpace($space)
    {
        $this->client->evaluate('box.schema.space.drop('.$this->getSpaceId($space).')');
        unset($this->spaceId[$space]);
    }

    public function hasIndex($space, $index)
    {
        $spaceId = $this->getSpaceId($space);
        $response = $this->indexSpace->select([$spaceId, $index], Index::INDEX_NAME);

        return !empty($response->getData());
    }

    public function listIndexes($space)
    {
        $result = [];
        $response = $this->indexSpace->select([$this->getSpaceId($space)], Index::INDEX_NAME);

        foreach ($response->getData() as $row) {

The expression $response->getData() of type null|array is not guaranteed to be traversable. How about adding an additional type check?

            $result[$row[2]] = [];
            foreach ($row[5] as $f) {
                $result[$row[2]][] = $f[0];
            }
        }

        return $result;
    }

    public function createIndex($space, $index, array $arguments)
    {
        $config = [];
        foreach ($arguments as $k => $v) {
            if (is_array($v)) {
                // convert to lua array
                $v = str_replace(['[', ']'], ['{', '}'], json_encode($v));
            }
            if (is_bool($v)) {
                $v = $v ? 'true' : 'false';
            }
            $config[] = $k.' = '.$v;
        }
        $config = '{'.implode(', ', $config).'}';
        $this->client->evaluate("box.space.$space:create_index('$index', $config)");

        $schema = $this->client->getSpace(Space::VINDEX);
        $response = $schema->select([$this->getSpaceId($space), $index], Index::INDEX_NAME);

        return $response->getData()[0][1];
    }

    public function dropIndex($spaceId, $index)
    {
        $space = $this->client->getSpace('_vindex');
        $row = $space->select([$spaceId, $index])->getData();
        $spaceName = $this->getSpaceName($spaceId);
        $indexName = $row[0][2];
        $this->client->evaluate("box.space.$spaceName.index.$indexName:drop{}");
    }
}