tarantool-php / jobqueue

src/Console/Command/Command.php

<?php

namespace Tarantool\JobQueue\Console\Command;

use Symfony\Component\Console\Command\Command as BaseCommand;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\Question;
use Tarantool\JobQueue\DefaultConfigFactory;

class Command extends BaseCommand
{
    private const DEFAULT_HOST = '127.0.0.1';
    private const DEFAULT_PORT = 3301;
    private const ENV_USER = 'TNT_JOBQUEUE_USER';
    private const ENV_PASSWORD = 'TNT_JOBQUEUE_PASSWORD';

    protected function configure(): void
    {
        $this
            ->addArgument('queue', InputArgument::REQUIRED)
            ->addOption('host', 'H', InputOption::VALUE_REQUIRED, '', self::DEFAULT_HOST)
            ->addOption('port', 'p', InputOption::VALUE_REQUIRED, '', self::DEFAULT_PORT)
            ->addOption('socket', 's', InputOption::VALUE_REQUIRED)
            ->addOption('user', 'u', InputOption::VALUE_REQUIRED)
            ->addOption('config', 'c', InputOption::VALUE_REQUIRED)
        ;
    }

    final protected function createConfigFactory(InputInterface $input, OutputInterface $output): DefaultConfigFactory
    {
        $customConfigPath = $input->getOption('config');
        if (null !== $customConfigPath && !is_readable($customConfigPath)) {

It seems like $customConfigPath can also be of type string[]; however, parameter $filename of is_readable() does only seem to accept string, maybe add an additional type check?

            throw new \RuntimeException("The given configuration file '$customConfigPath' does not exist or it's not readable.");
        }

        $configFactory = $customConfigPath ? include $customConfigPath : new DefaultConfigFactory();

        if (null !== $socket = $input->getOption('socket')) {
            $configFactory->setConnectionUri("unix://$socket");
        } elseif ((false !== $input->getParameterOption('--host')) || !$configFactory->getConnectionUri()) {
            $uri = sprintf('tcp://%s:%s', $input->getOption('host'), $input->getOption('port'));

It seems like $input->getOption('host') can also be of type string[]; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

            $configFactory->setConnectionUri($uri);
        }

        $queueName = $input->getArgument('queue');
        $configFactory->setQueueName($queueName);

It seems like $queueName can also be of type null and string[]; however, parameter $name of Tarantool\JobQueue\DefaultConfigFactory::setQueueName() does only seem to accept string, maybe add an additional type check?

        $user = $input->getOption('user') ?: getenv(self::ENV_USER);
        if ($user) {
            if (!$password = getenv(self::ENV_PASSWORD)) {
                $helper = $this->getHelper('question');
                $question = new Question('Password: ');
                $question->setHidden(true);
                $question->setHiddenFallback(false);
                $password = $helper->ask($input, $output, $question);
            }

            $configFactory->setCredentials($user, $password);
        }

        return $configFactory;
    }
}