Passed
Pull Request — master (#62)
by Eugene
12:23 queued 08:14
created

PurePacker::pack()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 10
Code Lines 7

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 8
CRAP Score 1.0013

Importance

Changes 2
Bugs 0 Features 0
Metric Value
eloc 7
c 2
b 0
f 0
dl 0
loc 10
ccs 8
cts 9
cp 0.8889
rs 10
cc 1
nc 1
nop 2
crap 1.0013
1
<?php
2
3
/**
4
 * This file is part of the Tarantool Client package.
5
 *
6
 * (c) Eugene Leonovich <[email protected]>
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
declare(strict_types=1);
13
14
namespace Tarantool\Client\Packer;
15
16
use MessagePack\BufferUnpacker;
17
use MessagePack\Packer;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Tarantool\Client\Packer\Packer. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
18
use Tarantool\Client\Keys;
19
use Tarantool\Client\Packer\Packer as ClientPacker;
20
use Tarantool\Client\Request\Request;
21
use Tarantool\Client\Response;
22
23
final class PurePacker implements ClientPacker
24
{
25
    private $packer;
26
    private $unpacker;
27
28 138
    public function __construct(?Packer $packer = null, ?BufferUnpacker $unpacker = null)
29
    {
30 138
        $this->packer = $packer ?: new Packer();
31 138
        $this->unpacker = $unpacker ?: new BufferUnpacker();
32 138
    }
33
34 114
    public function pack(Request $request, int $sync) : string
35
    {
36 114
        $packet = $this->packer->packMapHeader(2).
37 114
            $this->packer->packInt(Keys::CODE).
38 114
            $this->packer->packInt($request->getType()).
39 114
            $this->packer->packInt(Keys::SYNC).
40 114
            $this->packer->packInt($sync).
41 114
            $this->packer->packMap($request->getBody());
42
43 114
        return PacketLength::pack(\strlen($packet)).$packet;
44
    }
45
46 99
    public function unpack(string $data) : Response
47
    {
48 99
        $unpacker = $this->unpacker->withBuffer($data);
49
50 99
        return new Response($unpacker->unpackMap(),
51
            static function () use ($unpacker) {
52 92
                return $unpacker->unpackMap();
53 97
            }
54
        );
55
    }
56
}
57