PhpUnitCompat::expectExceptionMessageMatches() - Code Metrics - Inspection of "Update test to not use the deprecated assertRegExp..." - tarantool-php/client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 672d79...cc1862 )

by Eugene

created 2020-08-23 00:44 UTC

PhpUnitCompat::expectExceptionMessageMatches() A

↳ Parent: PhpUnitCompat

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	1
dl	0
loc	6
rs	10
c	0
b	0
f	0

<?php

/**
 * This file is part of the tarantool/client package.
 *
 * (c) Eugene Leonovich <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Tarantool\Client\Tests;

/**
 * Compatibility layer for legacy PHPUnit versions.
 */
trait PhpUnitCompat
{
    /**
     * TestCase::expectExceptionMessageRegExp() is deprecated since PHPUnit 8.4.
     */
    public function expectExceptionMessageMatches(string $regularExpression) : void

    {
        is_callable('parent::expectExceptionMessageMatches')
            ? parent::expectExceptionMessageMatches(...func_get_args())
            : parent::expectExceptionMessageRegExp(...func_get_args());
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Assert::assertRegExp() is deprecated since PHPUnit 9.1.
     */
    public static function assertMatchesRegularExpression(string $pattern, string $string, string $message = '') : void

    {
        is_callable('parent::assertMatchesRegularExpression')
            ? parent::assertMatchesRegularExpression(...func_get_args())
            : parent::assertRegExp(...func_get_args());
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1			<?php
2
3			/**
4			* This file is part of the tarantool/client package.
5			*
6			* (c) Eugene Leonovich <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace Tarantool\Client\Tests;
15
16			/**
17			* Compatibility layer for legacy PHPUnit versions.
18			*/
19			trait PhpUnitCompat
20			{
21			/**
22			* TestCase::expectExceptionMessageRegExp() is deprecated since PHPUnit 8.4.
23			*/
24			public function expectExceptionMessageMatches(string $regularExpression) : void
			0 ignored issues – show Unused Code introduced 2020-08-23 00:51 UTC by Report Bug Copy Issue Report The parameter `$regularExpression` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
25			{
26			is_callable('parent::expectExceptionMessageMatches')
27			? parent::expectExceptionMessageMatches(...func_get_args())
28			: parent::expectExceptionMessageRegExp(...func_get_args());
			0 ignored issues – show Comprehensibility Bug introduced 2020-08-23 00:51 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`expectExceptionMessageRegExp()` instead of `expectExceptionMessageMatches()`). Are you sure this is correct? If so, you might want to change this to `$this->expectExceptionMessageRegExp()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
29			}
30
31			/**
32			* Assert::assertRegExp() is deprecated since PHPUnit 9.1.
33			*/
34			public static function assertMatchesRegularExpression(string $pattern, string $string, string $message = '') : void
			0 ignored issues – show Unused Code introduced 2020-08-23 00:51 UTC by Report Bug Copy Issue Report The parameter `$pattern` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2020-08-23 00:51 UTC by Report Bug Copy Issue Report The parameter `$string` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2020-08-23 00:51 UTC by Report Bug Copy Issue Report The parameter `$message` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
35			{
36			is_callable('parent::assertMatchesRegularExpression')
37			? parent::assertMatchesRegularExpression(...func_get_args())
38			: parent::assertRegExp(...func_get_args());
			0 ignored issues – show Comprehensibility Bug introduced 2020-08-23 00:51 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`assertRegExp()` instead of `assertMatchesRegularExpression()`). Are you sure this is correct? If so, you might want to change this to `$this->assertRegExp()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
39			}
40			}
41

tarantool-php / client

Push — master ( 672d79...cc1862 )

PhpUnitCompat::expectExceptionMessageMatches() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like