Client::getSpaceIdByName() - Code Metrics - Inspection of "WIP: Drop php versions < 7.1, do refactoring, add..." - tarantool-php/client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#37)

by Eugene

created 2019-03-30 23:46 UTC

Client::getSpaceIdByName() A

↳ Parent: Client

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2.5

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	3
cts	6
cp	0.5
rs	9.9
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2.5

<?php

declare(strict_types=1);

/*
 * This file is part of the Tarantool Client package.
 *
 * (c) Eugene Leonovich <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tarantool\Client;

use Tarantool\Client\Connection\StreamConnection;
use Tarantool\Client\Exception\RequestFailed;
use Tarantool\Client\Handler\DefaultHandler;
use Tarantool\Client\Handler\Handler;
use Tarantool\Client\Handler\MiddlewareHandler;
use Tarantool\Client\Middleware\AuthMiddleware;
use Tarantool\Client\Middleware\Middleware;
use Tarantool\Client\Middleware\RetryMiddleware;
use Tarantool\Client\Packer\PurePacker;
use Tarantool\Client\Request\Call;
use Tarantool\Client\Request\Evaluate;
use Tarantool\Client\Request\Execute;
use Tarantool\Client\Request\Ping;
use Tarantool\Client\Schema\Index;
use Tarantool\Client\Schema\Space;

final class Client
{
    private $handler;
    private $spaces = [];

    public function __construct(Handler $handler)
    {
        $this->handler = $handler;
    }

    public static function fromDefaults() : self
    {
        return new self(new DefaultHandler(
            new StreamConnection(),
            new PurePacker()
        ));
    }

    public static function fromOptions(array $options) : self
    {
        $connectionOptions = [];

        if (isset($options['connect_timeout'])) {
            $connectionOptions['connect_timeout'] = $options['connect_timeout'];
        }
        if (isset($options['socket_timeout'])) {
            $connectionOptions['socket_timeout'] = $options['socket_timeout'];
        }
        if (isset($options['tcp_nodelay'])) {
            $connectionOptions['tcp_nodelay'] = $options['tcp_nodelay'];
        }

        $handler = new DefaultHandler(
            new StreamConnection($options['uri'] ?? StreamConnection::DEFAULT_URI, $connectionOptions),
            new PurePacker()
        );

        if (isset($options['username'])) {
            $handler = new MiddlewareHandler(
                new AuthMiddleware($options['username'], $options['password'] ?? ''),
                $handler
            );
        }
        if (isset($options['max_retries'])) {
            $handler = new MiddlewareHandler(
                RetryMiddleware::linear($options['max_retries']),
                $handler
            );
        }

        return new self($handler);
    }

    public static function fromDsn(string $dsn) : self
    {
        $dsn = Dsn::parse($dsn);

        return self::fromOptions([
            'uri' => $dsn->getConnectionUri(),
            'connect_timeout' => $dsn->getInt('connect_timeout'),
            'socket_timeout' => $dsn->getInt('socket_timeout'),
            'tcp_nodelay' => $dsn->getBool('tcp_nodelay'),
            'username' => $dsn->getUsername(),
            'password' => $dsn->getPassword(),
            'max_retries' => $dsn->getInt('max_retries'),
        ]);
    }

    public function withMiddleware(Middleware $middleware, Middleware ...$middlewares) : self
    {
        $new = clone $this;
        $new->handler = new MiddlewareHandler($middleware, $this->handler);

        if ($middlewares) {

            $new->handler = MiddlewareHandler::create($new->handler, $middlewares);
        }

        return $new;
    }

    public function getHandler() : Handler
    {
        return $this->handler;
    }

    public function ping() : void
    {
        $this->handler->handle(new Ping());
    }

    public function getSpace(string $spaceName) : Space
    {
        if (isset($this->spaces[$spaceName])) {
            return $this->spaces[$spaceName];
        }

        $spaceId = $this->getSpaceIdByName($spaceName);

        return $this->spaces[$spaceName] = $this->spaces[$spaceId] = new Space($this->handler, $spaceId);
    }

    public function getSpaceById(int $spaceId) : Space
    {
        if (isset($this->spaces[$spaceId])) {
            return $this->spaces[$spaceId];
        }

        return $this->spaces[$spaceId] = new Space($this->handler, $spaceId);
    }

    public function call(string $funcName, ...$args) : array
    {
        $request = new Call($funcName, $args);

        return $this->handler->handle($request)->getBodyField(IProto::DATA);
    }

    public function executeQuery(string $sql, array $params = []) : SqlQueryResult
    {
        $request = new Execute($sql, $params);
        $response = $this->handler->handle($request);

        return new SqlQueryResult(
            $response->getBodyField(IProto::DATA),
            $response->getBodyField(IProto::METADATA)
        );
    }

    public function executeUpdate(string $sql, array $params = []) : int
    {
        $request = new Execute($sql, $params);

        return $this->handler->handle($request)->getBodyField(IProto::SQL_INFO)[0];
    }

    public function evaluate(string $expr, ...$args) : array
    {
        $request = new Evaluate($expr, $args);

        return $this->handler->handle($request)->getBodyField(IProto::DATA);
    }

    public function flushSpaces() : void
    {
        $this->spaces = [];
    }

    private function getSpaceIdByName(string $spaceName) : int
    {
        $schema = $this->getSpaceById(Space::VSPACE_ID);
        $data = $schema->select([$spaceName], Index::SPACE_NAME);

        if (empty($data)) {
            throw RequestFailed::unknownSpace($spaceName);
        }

        return $data[0][0];
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/*
6		* This file is part of the Tarantool Client package.
7		*
8		* (c) Eugene Leonovich <[email protected]>
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace Tarantool\Client;
15
16		use Tarantool\Client\Connection\StreamConnection;
17		use Tarantool\Client\Exception\RequestFailed;
18		use Tarantool\Client\Handler\DefaultHandler;
19		use Tarantool\Client\Handler\Handler;
20		use Tarantool\Client\Handler\MiddlewareHandler;
21		use Tarantool\Client\Middleware\AuthMiddleware;
22		use Tarantool\Client\Middleware\Middleware;
23		use Tarantool\Client\Middleware\RetryMiddleware;
24		use Tarantool\Client\Packer\PurePacker;
25		use Tarantool\Client\Request\Call;
26		use Tarantool\Client\Request\Evaluate;
27		use Tarantool\Client\Request\Execute;
28		use Tarantool\Client\Request\Ping;
29		use Tarantool\Client\Schema\Index;
30		use Tarantool\Client\Schema\Space;
31
32		final class Client
33		{
34		private $handler;
35		private $spaces = [];
36
37	52	public function __construct(Handler $handler)
38		{
39	52	$this->handler = $handler;
40	52	}
41
42		public static function fromDefaults() : self
43		{
44		return new self(new DefaultHandler(
45		new StreamConnection(),
46		new PurePacker()
47		));
48		}
49
50		public static function fromOptions(array $options) : self
51		{
52		$connectionOptions = [];
53
54		if (isset($options['connect_timeout'])) {
55		$connectionOptions['connect_timeout'] = $options['connect_timeout'];
56		}
57		if (isset($options['socket_timeout'])) {
58		$connectionOptions['socket_timeout'] = $options['socket_timeout'];
59		}
60		if (isset($options['tcp_nodelay'])) {
61		$connectionOptions['tcp_nodelay'] = $options['tcp_nodelay'];
62		}
63
64		$handler = new DefaultHandler(
65		new StreamConnection($options['uri'] ?? StreamConnection::DEFAULT_URI, $connectionOptions),
66		new PurePacker()
67		);
68
69		if (isset($options['username'])) {
70		$handler = new MiddlewareHandler(
71		new AuthMiddleware($options['username'], $options['password'] ?? ''),
72		$handler
73		);
74		}
75		if (isset($options['max_retries'])) {
76		$handler = new MiddlewareHandler(
77		RetryMiddleware::linear($options['max_retries']),
78		$handler
79		);
80		}
81
82		return new self($handler);
83		}
84
85		public static function fromDsn(string $dsn) : self
86		{
87		$dsn = Dsn::parse($dsn);
88
89		return self::fromOptions([
90		'uri' => $dsn->getConnectionUri(),
91		'connect_timeout' => $dsn->getInt('connect_timeout'),
92		'socket_timeout' => $dsn->getInt('socket_timeout'),
93		'tcp_nodelay' => $dsn->getBool('tcp_nodelay'),
94		'username' => $dsn->getUsername(),
95		'password' => $dsn->getPassword(),
96		'max_retries' => $dsn->getInt('max_retries'),
97		]);
98		}
99
100		public function withMiddleware(Middleware $middleware, Middleware ...$middlewares) : self
101		{
102		$new = clone $this;
103		$new->handler = new MiddlewareHandler($middleware, $this->handler);
104
105		if ($middlewares) {
		0 ignored issues – show Bug Best Practice introduced 2019-03-22 18:16 UTC by Report Bug Copy Issue Report The expression `$middlewares` of type `Tarantool\Client\Middleware\Middleware[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
106		$new->handler = MiddlewareHandler::create($new->handler, $middlewares);
107		}
108
109		return $new;
110		}
111
112	4	public function getHandler() : Handler
113		{
114	4	return $this->handler;
115		}
116
117	46	public function ping() : void
118		{
119	46	$this->handler->handle(new Ping());
120		}
121
122	2	public function getSpace(string $spaceName) : Space
123		{
124	2	if (isset($this->spaces[$spaceName])) {
125		return $this->spaces[$spaceName];
126		}
127
128	2	$spaceId = $this->getSpaceIdByName($spaceName);
129
130		return $this->spaces[$spaceName] = $this->spaces[$spaceId] = new Space($this->handler, $spaceId);
131		}
132
133	2	public function getSpaceById(int $spaceId) : Space
134		{
135	2	if (isset($this->spaces[$spaceId])) {
136		return $this->spaces[$spaceId];
137		}
138
139	2	return $this->spaces[$spaceId] = new Space($this->handler, $spaceId);
140		}
141
142		public function call(string $funcName, ...$args) : array
143		{
144		$request = new Call($funcName, $args);
145
146		return $this->handler->handle($request)->getBodyField(IProto::DATA);
147		}
148
149		public function executeQuery(string $sql, array $params = []) : SqlQueryResult
150		{
151		$request = new Execute($sql, $params);
152		$response = $this->handler->handle($request);
153
154		return new SqlQueryResult(
155		$response->getBodyField(IProto::DATA),
156		$response->getBodyField(IProto::METADATA)
157		);
158		}
159
160		public function executeUpdate(string $sql, array $params = []) : int
161		{
162		$request = new Execute($sql, $params);
163
164		return $this->handler->handle($request)->getBodyField(IProto::SQL_INFO)[0];
165		}
166
167	2	public function evaluate(string $expr, ...$args) : array
168		{
169	2	$request = new Evaluate($expr, $args);
170
171	2	return $this->handler->handle($request)->getBodyField(IProto::DATA);
172		}
173
174		public function flushSpaces() : void
175		{
176		$this->spaces = [];
177		}
178
179	2	private function getSpaceIdByName(string $spaceName) : int
180		{
181	2	$schema = $this->getSpaceById(Space::VSPACE_ID);
182	2	$data = $schema->select([$spaceName], Index::SPACE_NAME);
183
184		if (empty($data)) {
185		throw RequestFailed::unknownSpace($spaceName);
186		}
187
188		return $data[0][0];
189		}
190		}
191

tarantool-php / client

Pull Request — master (#37)

Client::getSpaceIdByName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like