MiddlewareHandlerTest::testCreateMiddlewareExecutesInFifoOrder() - Code Metrics - Inspection of "Allow to prepend middleware" - tarantool-php/client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ee6bc9...3f15df )

by Eugene

created 2020-10-05 19:19 UTC

testCreateMiddlewareExecutesInFifoOrder() A

↳ Parent: MiddlewareHandlerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	11
rs	9.9
c	0
b	0
f	0

<?php

/**
 * This file is part of the tarantool/client package.
 *
 * (c) Eugene Leonovich <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Tarantool\Client\Tests\Unit\Handler;

use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use Tarantool\Client\Handler\Handler;
use Tarantool\Client\Handler\MiddlewareHandler;
use Tarantool\Client\Request\Request;
use Tarantool\Client\Tests\SpyMiddleware;
use Tarantool\PhpUnit\Client\TestDoubleClient;

final class MiddlewareHandlerTest extends TestCase
{
    use TestDoubleClient;

    /**
     * @var Request|MockObject
     */
    private $request;

    /**
     * @var Handler|MockObject
     */
    private $handler;

    protected function setUp() : void
    {
        $this->request = $this->createMock(Request::class);
        $this->handler = $this->createDummyClient()->getHandler();
    }

    public function testCreateMiddlewareExecutesInFifoOrder() : void
    {
        $trace = new \ArrayObject();
        $middleware1 = SpyMiddleware::fromTraceId(1, $trace);
        $middleware2 = SpyMiddleware::fromTraceId(2, $trace);

        $handler = MiddlewareHandler::create($this->handler, [$middleware1, $middleware2]);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $handler->handle($this->request);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        self::assertSame([1, 2], $trace->getArrayCopy());
    }

    public function testCreateAppendsMiddleware() : void
    {
        $trace = new \ArrayObject();
        $middleware1 = SpyMiddleware::fromTraceId(1, $trace);
        $middleware2 = SpyMiddleware::fromTraceId(2, $trace);

        $handler = MiddlewareHandler::create($this->handler, [$middleware1]);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $handler = MiddlewareHandler::create($handler, [$middleware2]);
        $handler->handle($this->request);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        self::assertSame([1, 2], $trace->getArrayCopy());
    }

    public function testCreatePrependsMiddleware() : void
    {
        $trace = new \ArrayObject();
        $middleware1 = SpyMiddleware::fromTraceId(1, $trace);
        $middleware2 = SpyMiddleware::fromTraceId(2, $trace);

        $handler = MiddlewareHandler::create($this->handler, [$middleware1]);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $handler = MiddlewareHandler::create($handler, [$middleware2], true);
        $handler->handle($this->request);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        self::assertSame([2, 1], $trace->getArrayCopy());
    }

    public function testMiddlewareRemainsAfterExecution() : void
    {
        $middleware = SpyMiddleware::fromTraceId(1);

        $handler = MiddlewareHandler::create($this->handler, [$middleware]);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $handler->handle($this->request);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $handler->handle($this->request);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        self::assertSame([1, 1], $middleware->getTraceLogArray());
    }
}


1			<?php
2
3			/**
4			* This file is part of the tarantool/client package.
5			*
6			* (c) Eugene Leonovich <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace Tarantool\Client\Tests\Unit\Handler;
15
16			use PHPUnit\Framework\MockObject\MockObject;
17			use PHPUnit\Framework\TestCase;
18			use Tarantool\Client\Handler\Handler;
19			use Tarantool\Client\Handler\MiddlewareHandler;
20			use Tarantool\Client\Request\Request;
21			use Tarantool\Client\Tests\SpyMiddleware;
22			use Tarantool\PhpUnit\Client\TestDoubleClient;
23
24			final class MiddlewareHandlerTest extends TestCase
25			{
26			use TestDoubleClient;
27
28			/**
29			* @var Request\|MockObject
30			*/
31			private $request;
32
33			/**
34			* @var Handler\|MockObject
35			*/
36			private $handler;
37
38			protected function setUp() : void
39			{
40			$this->request = $this->createMock(Request::class);
41			$this->handler = $this->createDummyClient()->getHandler();
42			}
43
44			public function testCreateMiddlewareExecutesInFifoOrder() : void
45			{
46			$trace = new \ArrayObject();
47			$middleware1 = SpyMiddleware::fromTraceId(1, $trace);
48			$middleware2 = SpyMiddleware::fromTraceId(2, $trace);
49
50			$handler = MiddlewareHandler::create($this->handler, [$middleware1, $middleware2]);
			0 ignored issues – show Bug introduced 2020-10-05 19:21 UTC by Report Bug Copy Issue Report It seems like `$this->handler` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Tarantool\Client\Handler...lewareHandler::create()` does only seem to accept `object<Tarantool\Client\Handler\Handler>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
51			$handler->handle($this->request);
			0 ignored issues – show Bug introduced 2020-03-19 00:26 UTC by Report Bug Copy Issue Report It seems like `$this->request` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Tarantool\Client\Handler\Handler::handle()` does only seem to accept `object<Tarantool\Client\Request\Request>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
52
53			self::assertSame([1, 2], $trace->getArrayCopy());
54			}
55
56			public function testCreateAppendsMiddleware() : void
57			{
58			$trace = new \ArrayObject();
59			$middleware1 = SpyMiddleware::fromTraceId(1, $trace);
60			$middleware2 = SpyMiddleware::fromTraceId(2, $trace);
61
62			$handler = MiddlewareHandler::create($this->handler, [$middleware1]);
			0 ignored issues – show Bug introduced 2020-10-05 19:21 UTC by Report Bug Copy Issue Report It seems like `$this->handler` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Tarantool\Client\Handler...lewareHandler::create()` does only seem to accept `object<Tarantool\Client\Handler\Handler>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
63			$handler = MiddlewareHandler::create($handler, [$middleware2]);
64			$handler->handle($this->request);
			0 ignored issues – show Bug introduced 2020-10-05 19:21 UTC by Report Bug Copy Issue Report It seems like `$this->request` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Tarantool\Client\Handler\Handler::handle()` does only seem to accept `object<Tarantool\Client\Request\Request>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
65
66			self::assertSame([1, 2], $trace->getArrayCopy());
67			}
68
69			public function testCreatePrependsMiddleware() : void
70			{
71			$trace = new \ArrayObject();
72			$middleware1 = SpyMiddleware::fromTraceId(1, $trace);
73			$middleware2 = SpyMiddleware::fromTraceId(2, $trace);
74
75			$handler = MiddlewareHandler::create($this->handler, [$middleware1]);
			0 ignored issues – show Bug introduced 2020-10-05 19:21 UTC by Report Bug Copy Issue Report It seems like `$this->handler` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Tarantool\Client\Handler...lewareHandler::create()` does only seem to accept `object<Tarantool\Client\Handler\Handler>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
76			$handler = MiddlewareHandler::create($handler, [$middleware2], true);
77			$handler->handle($this->request);
			0 ignored issues – show Bug introduced 2020-10-05 19:21 UTC by Report Bug Copy Issue Report It seems like `$this->request` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Tarantool\Client\Handler\Handler::handle()` does only seem to accept `object<Tarantool\Client\Request\Request>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
78
79			self::assertSame([2, 1], $trace->getArrayCopy());
80			}
81
82			public function testMiddlewareRemainsAfterExecution() : void
83			{
84			$middleware = SpyMiddleware::fromTraceId(1);
85
86			$handler = MiddlewareHandler::create($this->handler, [$middleware]);
			0 ignored issues – show Bug introduced 2020-10-05 19:21 UTC by Report Bug Copy Issue Report It seems like `$this->handler` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Tarantool\Client\Handler...lewareHandler::create()` does only seem to accept `object<Tarantool\Client\Handler\Handler>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
87			$handler->handle($this->request);
			0 ignored issues – show Bug introduced 2020-03-19 00:26 UTC by Report Bug Copy Issue Report It seems like `$this->request` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Tarantool\Client\Handler\Handler::handle()` does only seem to accept `object<Tarantool\Client\Request\Request>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
88			$handler->handle($this->request);
			0 ignored issues – show Bug introduced 2020-03-19 00:26 UTC by Report Bug Copy Issue Report It seems like `$this->request` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Tarantool\Client\Handler\Handler::handle()` does only seem to accept `object<Tarantool\Client\Request\Request>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
89
90			self::assertSame([1, 1], $middleware->getTraceLogArray());
91			}
92			}
93

tarantool-php / client

Push — master ( ee6bc9...3f15df )

testCreateMiddlewareExecutesInFifoOrder() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like