ExecuteTest::provideScanQuery() - Code Metrics - Inspection of "Tarantool 3.0 SQL breaking change compatibility" - tarantool-php/client - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#84)

unknown
created 2023-06-07 11:25 UTC
ExecuteTest::provideScanQuery() A

↳ Parent: ExecuteTest
Complexity

Conditions	2
Paths	2
Size

Total Lines	13
Code Lines	3
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	2
eloc	3
c	0
b	0
f	0
nc	2
nop	0
dl	0
loc	13
rs	10
<?php

/**
 * This file is part of the tarantool/client package.
 *
 * (c) Eugene Leonovich <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Tarantool\Client\Tests\Integration\Requests;

require __DIR__.'/../../../examples/bootstrap.php';

use Tarantool\Client\Keys;
use Tarantool\Client\Tests\Integration\ClientBuilder;
use Tarantool\Client\Tests\Integration\TestCase;

/**
 * @requires Tarantool >=2
 *
 * @sql DROP TABLE IF EXISTS exec_query
 * @sql CREATE TABLE exec_query (id INTEGER PRIMARY KEY, name VARCHAR(50))
 * @sql INSERT INTO exec_query VALUES (1, 'A'), (2, 'B')
 */
final class ExecuteTest extends TestCase
{
    private function provideScanQuery() : string
    {
        /**
         * SEQSCAN keyword is explicitly allowing to use seqscan:
         * https://github.com/tarantool/tarantool/commit/77648827326ad268ec0ffbcd620c2371b65ef2b4
         * It was introduced in Tarantool 2.11.0-rc1. If compat.sql_seq_scan_default set to "new"
         * (default value since 3.0), query returns error when trying to scan without keyword.
         */
        if (server_version_at_least('2.11', $this->client)) {
        if (server_version_at_least('2.11', /** @scrutinizer ignore-type */ $this->client)) {
            return 'SELECT * FROM SEQSCAN exec_query';
        }

        return 'SELECT * FROM exec_query';
    }

    /**
     * @sql DROP TABLE IF EXISTS exec_update
     * @sql CREATE TABLE exec_update (id INTEGER PRIMARY KEY AUTOINCREMENT, name VARCHAR(50))
     */
    public function testExecuteInsertsRows() : void
    {
        $response = $this->client->execute(
        $response = $this->client->execute(
            'INSERT INTO exec_update VALUES (5, :name1), (null, :name2)',
            [':name1' => 'A'], [':name2' => 'B']
        );

        $expectedSqlInfo = [
            Keys::SQL_INFO_ROW_COUNT => 2,
            Keys::SQL_INFO_AUTO_INCREMENT_IDS => [6],
        ];

        self::assertSame($expectedSqlInfo, $response->getBodyField(Keys::SQL_INFO));
    }

    public function testExecuteFetchesAllRows() : void
    {
        $response = $this->client->execute(self::provideScanQuery());
        $response = $this->client->execute(self::/** @scrutinizer ignore-call */ provideScanQuery());

        self::assertSame([[1, 'A'], [2, 'B']], $response->getBodyField(Keys::DATA));
    }

    /**
     * @sql DROP TABLE IF EXISTS exec_update
     * @sql CREATE TABLE exec_update (id INTEGER PRIMARY KEY, name VARCHAR(50))
     */
    public function testExecuteUpdateInsertsRows() : void
    {
        $result = $this->client->executeUpdate(
            'INSERT INTO exec_update VALUES (1, :name1), (2, :name2)',
            [':name1' => 'A'], [':name2' => 'B']
        );

        self::assertSame([], $result->getAutoincrementIds());
        self::assertSame(2, $result->count());
    }

    /**
     * @sql DROP TABLE IF EXISTS exec_update
     * @sql CREATE TABLE exec_update (id INTEGER PRIMARY KEY AUTOINCREMENT, name VARCHAR(50))
     */
    public function testExecuteUpdateInsertsRowsWithAutoIncrementedIds() : void
    {
        $result = $this->client->executeUpdate("INSERT INTO exec_update VALUES (100, 'A'), (null, 'B'), (120, 'C'), (null, 'D')");

        self::assertSame([101, 121], $result->getAutoincrementIds());
        self::assertSame(4, $result->count());
    }

    /**
     * @sql DROP TABLE IF EXISTS exec_update
     * @sql CREATE TABLE exec_update (id INTEGER PRIMARY KEY, name VARCHAR(50))
     * @sql INSERT INTO exec_update VALUES (1, 'A'), (2, 'B')
     */
    public function testExecuteUpdateUpdatesRow() : void
    {
        $result = $this->client->executeUpdate('UPDATE exec_update SET name = ? WHERE id = ?', 'BB', 2);

        self::assertSame([], $result->getAutoincrementIds());
        self::assertSame(1, $result->count());
    }

    public function testExecuteQueryFetchesAllRows() : void
    {
        $result = $this->client->executeQuery(self::provideScanQuery());
        $result = $this->client->executeQuery(self::/** @scrutinizer ignore-call */ provideScanQuery());

        self::assertSame([[1, 'A'], [2, 'B']], $result->getData());
        self::assertSame(2, $result->count());
    }

    public function testExecuteQueryFetchesOneRow() : void
    {
        $result = $this->client->executeQuery('SELECT * FROM exec_query WHERE id = 1');

        self::assertSame([[1, 'A']], $result->getData());
        self::assertSame(1, $result->count());
    }

    public function testExecuteQueryFetchesNoRows() : void
    {
        $result = $this->client->executeQuery('SELECT * FROM exec_query WHERE id = -1');

        self::assertSame([], $result->getData());
        self::assertSame(0, $result->count());
    }

    public function testExecuteQueryBindsPositionalParameters() : void
    {
        $result = $this->client->executeQuery('SELECT ?, ?', 2, 'B');

        self::assertSame([[2, 'B']], $result->getData());
        self::assertSame(1, $result->count());
    }

    public function testExecuteQueryBindsNamedParameters() : void
    {
        $result = $this->client->executeQuery('SELECT :id, :name', [':name' => 'B'], [':id' => 2]);

        self::assertSame([[2, 'B']], $result->getData());
        self::assertSame(1, $result->count());
    }

    public function testExecuteQueryBindsMixedParameters() : void
    {
        $result = $this->client->executeQuery('SELECT ?, :name', 2, [':name' => 'B']);

        self::assertSame([[2, 'B']], $result->getData());
        self::assertSame(1, $result->count());
    }

    /**
     * @see https://github.com/tarantool/tarantool/issues/4782
     */
    public function testExecuteQueryBindsMixedParametersAndSubstitutesPositionalOnes() : void
    {
        $result = $this->client->executeQuery('SELECT :id, ?', 'B', [':id' => 2]);

        self::assertSame([[2, null]], $result->getData());
        self::assertSame(1, $result->count());
    }

    public function testSqlQueryResultHoldsMetadata() : void
    {
        $client = ClientBuilder::createFromEnv()->build();

        $response = $client->executeQuery(self::provideScanQuery());
        $response = $client->executeQuery(self::/** @scrutinizer ignore-call */ provideScanQuery());

        self::assertSame([[
            Keys::METADATA_FIELD_NAME => 'ID',
            Keys::METADATA_FIELD_TYPE => 'integer',
        ], [
            Keys::METADATA_FIELD_NAME => 'NAME',
            Keys::METADATA_FIELD_TYPE => 'string',
        ]], $response->getMetadata());
    }

    /**
     * @requires Tarantool >=2.6
     *
     * @sql DROP TABLE IF EXISTS %target_method%
     * @sql CREATE TABLE %target_method% (id INTEGER PRIMARY KEY AUTOINCREMENT, name VARCHAR(50) COLLATE "unicode_ci")
     */
    public function testSqlQueryResultHoldsExtendedMetadata() : void
    {
        $client = ClientBuilder::createFromEnv()->build();
        $client->execute('SET SESSION "sql_full_metadata" = true');

        $tableName = $this->resolvePlaceholders('%target_method%');

        /**
         * SEQSCAN keyword is explicitly allowing to use seqscan:
         * https://github.com/tarantool/tarantool/commit/77648827326ad268ec0ffbcd620c2371b65ef2b4
         * It was introduced in Tarantool 2.11.0-rc1. If compat.sql_seq_scan_default set to "new"
         * (default value since 3.0), query returns error when trying to scan without keyword.
         */
        if (server_version_at_least('2.11', $this->client)) {
        if (server_version_at_least('2.11', /** @scrutinizer ignore-type */ $this->client)) {
            $scan_query = "SELECT id, name as full_name FROM SEQSCAN $tableName";
        } else {
            $scan_query = "SELECT id, name as full_name FROM $tableName";
        }
        $response = $client->executeQuery($scan_query);

        self::assertSame([[
            Keys::METADATA_FIELD_NAME => 'ID',
            Keys::METADATA_FIELD_TYPE => 'integer',
            Keys::METADATA_FIELD_IS_NULLABLE => false,
            Keys::METADATA_FIELD_IS_AUTOINCREMENT => true,
            Keys::METADATA_FIELD_SPAN => 'id',
        ], [
            Keys::METADATA_FIELD_NAME => 'FULL_NAME',
            Keys::METADATA_FIELD_TYPE => 'string',
            Keys::METADATA_FIELD_COLL => 'unicode_ci',
            Keys::METADATA_FIELD_IS_NULLABLE => true,
            Keys::METADATA_FIELD_SPAN => 'name',
        ]], $response->getMetadata());
    }
}

tarantool-php / client

Pull Request — master (#84)

ExecuteTest::provideScanQuery() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like
