Issues in TenantUserHandler.php (master) - Issues in master - tahoelimited/multi-tenancy-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (33)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Handler/TenantUserHandler.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


namespace Tahoe\Bundle\MultiTenancyBundle\Handler;


use Doctrine\ORM\EntityManager;
use Tahoe\Bundle\MultiTenancyBundle\Factory\TenantUserFactory;
use Tahoe\Bundle\MultiTenancyBundle\Model\InvitationInterface;
use Tahoe\Bundle\MultiTenancyBundle\Model\MultiTenantTenantInterface;
use Tahoe\Bundle\MultiTenancyBundle\Model\MultiTenantUserInterface;
use Tahoe\Bundle\MultiTenancyBundle\Repository\TenantUserRepository;

/**
 * Class TenantUserHandler
 *
 * @author Konrad Podgórski <[email protected]>
 */
class TenantUserHandler
{

    /**
     * @var EntityManager
     */
    protected $entityManager;
    /**
     * @var TenantUserRepository
     */
    protected $tenantUserRepository;
    /**
     * @var TenantUserFactory
     */
    protected $tenantUserFactory;

    function __construct($entityManager, $tenantUserFactory, $tenantUserRepository)

    {
        $this->entityManager = $entityManager;
        $this->tenantUserFactory = $tenantUserFactory;
        $this->tenantUserRepository = $tenantUserRepository;
    }

    /**
     * @param MultiTenantUserInterface         $user
     * @param MultiTenantTenantInterface $tenant
     * @param array                            $roles
     *
     * @return \Tahoe\Bundle\MultiTenancyBundle\Entity\TenantUser
     * @throws \Exception
     */
    public function addUserToTenant(
        MultiTenantUserInterface $user,
        MultiTenantTenantInterface $tenant,
        $roles = array()
    ) {
        $tenantUser = $this->tenantUserRepository->findOneBy(
            array(
                'tenant' => $tenant,
                'user' => $user
            )
        );

        if ($tenantUser) {
            // user is already a member of this tenant

            throw new \Exception(sprintf('User is already a member of given tenant'));
        }

        $tenantUser = $this->tenantUserFactory->createNew();
        $tenantUser->setUser($user);
        $tenantUser->setTenant($tenant);

        $tenantUser->setRoles($roles);

        $this->entityManager->persist($tenantUser);

        return $tenantUser;
    }

    /**
     * @param MultiTenantUserInterface         $user
     * @param MultiTenantTenantInterface $tenant
     *
     * @return bool
     * @throws \Exception
     */
    public function removeUserFromTenant(
        MultiTenantUserInterface $user,
        MultiTenantTenantInterface $tenant
    ) {
        $tenantUser = $this->tenantUserRepository->findOneBy(
            array(
                'tenant' => $tenant,
                'user' => $user
            )
        );

        if ($tenantUser) {
            $this->entityManager->remove($tenantUser);
            $this->entityManager->flush();

            return true;
        }

        throw new \Exception(sprintf('User is not a member of given tenant'));
    }

    public function addRoleToUserInTenant(

        $role,
        MultiTenantUserInterface $user,
        MultiTenantTenantInterface $tenant)
    {
        $tenantUser = $this->tenantUserRepository->findOneBy(
            array(
                'tenant' => $tenant,
                'user' => $user
            )
        );

        if ($tenantUser) {

            if (false === $tenantUser->hasRole($role)) {
                $tenantUser->addRole($role);
            }

            $this->entityManager->persist($tenantUser);
            $this->entityManager->flush();

            return true;
        }

        throw new \Exception(sprintf('User with id %d is not a member of tenant with id %d' , $user->getId(), $tenant->getId()));

    }

    public function removeRoleFromUserInTenant(

        $role,
        MultiTenantUserInterface $user,
        MultiTenantTenantInterface $tenant)
    {
        $tenantUser = $this->tenantUserRepository->findOneBy(
            array(
                'tenant' => $tenant,
                'user' => $user
            )
        );

        if ($tenantUser) {

            if ($tenantUser->hasRole($role)) {
                $tenantUser->removeRole($role);
            }

            $this->entityManager->persist($tenantUser);
            $this->entityManager->flush();

            return true;
        }

        throw new \Exception(sprintf('User with id %d is not a member of tenant with id %d' , $user->getId(), $tenant->getId()));

    }
}


1		<?php
2
3
4		namespace Tahoe\Bundle\MultiTenancyBundle\Handler;
5
6
7		use Doctrine\ORM\EntityManager;
8		use Tahoe\Bundle\MultiTenancyBundle\Factory\TenantUserFactory;
9		use Tahoe\Bundle\MultiTenancyBundle\Model\InvitationInterface;
10		use Tahoe\Bundle\MultiTenancyBundle\Model\MultiTenantTenantInterface;
11		use Tahoe\Bundle\MultiTenancyBundle\Model\MultiTenantUserInterface;
12		use Tahoe\Bundle\MultiTenancyBundle\Repository\TenantUserRepository;
13
14		/**
15		* Class TenantUserHandler
16		*
17		* @author Konrad Podgórski <[email protected]>
18		*/
19		class TenantUserHandler
20		{
21
22		/**
23		* @var EntityManager
24		*/
25		protected $entityManager;
26		/**
27		* @var TenantUserRepository
28		*/
29		protected $tenantUserRepository;
30		/**
31		* @var TenantUserFactory
32		*/
33		protected $tenantUserFactory;
34
35		function __construct($entityManager, $tenantUserFactory, $tenantUserRepository)
		0 ignored issues – show Best Practice introduced 2016-01-18 22:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
36		{
37		$this->entityManager = $entityManager;
38		$this->tenantUserFactory = $tenantUserFactory;
39		$this->tenantUserRepository = $tenantUserRepository;
40		}
41
42		/**
43		* @param MultiTenantUserInterface $user
44		* @param MultiTenantTenantInterface $tenant
45		* @param array $roles
46		*
47		* @return \Tahoe\Bundle\MultiTenancyBundle\Entity\TenantUser
48		* @throws \Exception
49		*/
50		public function addUserToTenant(
51		MultiTenantUserInterface $user,
52		MultiTenantTenantInterface $tenant,
53		$roles = array()
54		) {
55		$tenantUser = $this->tenantUserRepository->findOneBy(
56		array(
57		'tenant' => $tenant,
58		'user' => $user
59		)
60		);
61
62		if ($tenantUser) {
63		// user is already a member of this tenant
64
65		throw new \Exception(sprintf('User is already a member of given tenant'));
66		}
67
68		$tenantUser = $this->tenantUserFactory->createNew();
69		$tenantUser->setUser($user);
70		$tenantUser->setTenant($tenant);
		0 ignored issues – show Compatibility introduced 2016-01-18 22:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$tenant` of type `object<Tahoe\Bundle\Mult...iTenantTenantInterface>` is not a sub-type of `object<Tahoe\Bundle\Mult...cyBundle\Entity\Tenant>`. It seems like you assume a concrete implementation of the interface `Tahoe\Bundle\MultiTenanc...tiTenantTenantInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
71		$tenantUser->setRoles($roles);
72
73		$this->entityManager->persist($tenantUser);
74
75		return $tenantUser;
76		}
77
78		/**
79		* @param MultiTenantUserInterface $user
80		* @param MultiTenantTenantInterface $tenant
81		*
82		* @return bool
83		* @throws \Exception
84		*/
85		public function removeUserFromTenant(
86		MultiTenantUserInterface $user,
87		MultiTenantTenantInterface $tenant
88		) {
89		$tenantUser = $this->tenantUserRepository->findOneBy(
90		array(
91		'tenant' => $tenant,
92		'user' => $user
93		)
94		);
95
96		if ($tenantUser) {
97		$this->entityManager->remove($tenantUser);
98		$this->entityManager->flush();
99
100		return true;
101		}
102
103		throw new \Exception(sprintf('User is not a member of given tenant'));
104		}
105
106	View Code Duplication	public function addRoleToUserInTenant(
		0 ignored issues – show Duplication introduced 2016-01-18 22:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
107		$role,
108		MultiTenantUserInterface $user,
109		MultiTenantTenantInterface $tenant)
110		{
111		$tenantUser = $this->tenantUserRepository->findOneBy(
112		array(
113		'tenant' => $tenant,
114		'user' => $user
115		)
116		);
117
118		if ($tenantUser) {
119
120		if (false === $tenantUser->hasRole($role)) {
121		$tenantUser->addRole($role);
122		}
123
124		$this->entityManager->persist($tenantUser);
125		$this->entityManager->flush();
126
127		return true;
128		}
129
130		throw new \Exception(sprintf('User with id %d is not a member of tenant with id %d' , $user->getId(), $tenant->getId()));
		0 ignored issues – show Bug introduced 2016-01-18 22:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getId()` does not seem to exist on `object<Tahoe\Bundle\Mult...ltiTenantUserInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
131		}
132
133	View Code Duplication	public function removeRoleFromUserInTenant(
		0 ignored issues – show Duplication introduced 2016-01-18 22:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
134		$role,
135		MultiTenantUserInterface $user,
136		MultiTenantTenantInterface $tenant)
137		{
138		$tenantUser = $this->tenantUserRepository->findOneBy(
139		array(
140		'tenant' => $tenant,
141		'user' => $user
142		)
143		);
144
145		if ($tenantUser) {
146
147		if ($tenantUser->hasRole($role)) {
148		$tenantUser->removeRole($role);
149		}
150
151		$this->entityManager->persist($tenantUser);
152		$this->entityManager->flush();
153
154		return true;
155		}
156
157		throw new \Exception(sprintf('User with id %d is not a member of tenant with id %d' , $user->getId(), $tenant->getId()));
		0 ignored issues – show Bug introduced 2016-01-18 22:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getId()` does not seem to exist on `object<Tahoe\Bundle\Mult...ltiTenantUserInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
158		}
159		}
160

tahoelimited / multi-tenancy-bundle

Issues (33)

Security Analysis not enabled

Handler/TenantUserHandler.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like