Issues in InvitationHandler.php (master) - Issues in master - tahoelimited/multi-tenancy-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (33)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Handler/InvitationHandler.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


namespace Tahoe\Bundle\MultiTenancyBundle\Handler;


use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityRepository;
use Tahoe\Bundle\MultiTenancyBundle\Factory\InvitationFactory;
use Tahoe\Bundle\MultiTenancyBundle\Model\InvitationInterface;
use Tahoe\Bundle\MultiTenancyBundle\Repository\InvitationRepository;

/**
 * Class InvitationHandler
 *
 * @author Konrad Podgórski <[email protected]>
 */
class InvitationHandler
{

    /**
     * @var EntityManager
     */
    protected $entityManager;
    /**
     * @var InvitationFactory
     */
    protected $invitationFactory;
    /**
     * @var InvitationRepository
     */
    protected $invitationRepository;
    /**
     * @var EntityRepository
     */
    protected $userRepository;
    /**
     * @var TenantUserHandler
     */
    protected $tenantUserHandler;

    /**
     * @param $entityManager
     * @param $invitationFactory
     * @param $invitationRepository
     * @param $tenantUserHandler
     * @param $userRepository
     */
    function __construct(

        $entityManager,
        $invitationFactory,
        $invitationRepository,
        $tenantUserHandler,
        $userRepository
    ) {
        $this->entityManager = $entityManager;
        $this->invitationFactory = $invitationFactory;
        $this->invitationRepository = $invitationRepository;
        $this->tenantUserHandler = $tenantUserHandler;
        $this->userRepository = $userRepository;
    }

    public function acceptInvitationById($invitationId)

    {
        $invitation = $this->invitationRepository->find($invitationId);

        if ($invitation === null) {
            throw new \Exception(sprintf(
                'Invitation with id %d doesn\'t exist. Maybe it\'s from different tenant?',
                $invitationId
            ));
        }

        return $this->acceptInvitation($invitation);
    }

    /**
     * @param InvitationInterface $invitation
     *
     * @return \Tahoe\Bundle\MultiTenancyBundle\Entity\TenantUser
     */
    public function acceptInvitation(InvitationInterface $invitation)
    {
        $user = $this->userRepository->findOneBy(array('emailCanonical' => $invitation->getEmail()));

        $tenant = $invitation->getTenant();

        $tenantUser = $this->tenantUserHandler->addUserToTenant($user, $tenant);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->entityManager->flush();

        $this->delete($invitation, true);

        return $tenantUser;
    }

    public function delete($invitation, $withFlush = false)
    {
        $this->entityManager->remove($invitation);

        if ($withFlush) {
            $this->entityManager->flush();
        }
    }

    public function rejectInvitationById($invitationId)

    {
        $invitation = $this->invitationRepository->find($invitationId);

        if ($invitation === null) {
            throw new \Exception(sprintf(
                'Invitation with id %d doesn\'t exist. Maybe it\'s from different tenant?',
                $invitationId
            ));
        }

        return $this->rejectInvitation($invitation);
    }

    public function rejectInvitation(InvitationInterface $invitation)
    {
        $this->delete($invitation, true);

        return true;
    }
}

1		<?php
2
3
4		namespace Tahoe\Bundle\MultiTenancyBundle\Handler;
5
6
7		use Doctrine\ORM\EntityManager;
8		use Doctrine\ORM\EntityRepository;
9		use Tahoe\Bundle\MultiTenancyBundle\Factory\InvitationFactory;
10		use Tahoe\Bundle\MultiTenancyBundle\Model\InvitationInterface;
11		use Tahoe\Bundle\MultiTenancyBundle\Repository\InvitationRepository;
12
13		/**
14		* Class InvitationHandler
15		*
16		* @author Konrad Podgórski <[email protected]>
17		*/
18		class InvitationHandler
19		{
20
21		/**
22		* @var EntityManager
23		*/
24		protected $entityManager;
25		/**
26		* @var InvitationFactory
27		*/
28		protected $invitationFactory;
29		/**
30		* @var InvitationRepository
31		*/
32		protected $invitationRepository;
33		/**
34		* @var EntityRepository
35		*/
36		protected $userRepository;
37		/**
38		* @var TenantUserHandler
39		*/
40		protected $tenantUserHandler;
41
42		/**
43		* @param $entityManager
44		* @param $invitationFactory
45		* @param $invitationRepository
46		* @param $tenantUserHandler
47		* @param $userRepository
48		*/
49		function __construct(
		0 ignored issues – show Best Practice introduced 2016-01-18 22:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
50		$entityManager,
51		$invitationFactory,
52		$invitationRepository,
53		$tenantUserHandler,
54		$userRepository
55		) {
56		$this->entityManager = $entityManager;
57		$this->invitationFactory = $invitationFactory;
58		$this->invitationRepository = $invitationRepository;
59		$this->tenantUserHandler = $tenantUserHandler;
60		$this->userRepository = $userRepository;
61		}
62
63	View Code Duplication	public function acceptInvitationById($invitationId)
		0 ignored issues – show Duplication introduced 2016-01-18 22:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		{
65		$invitation = $this->invitationRepository->find($invitationId);
66
67		if ($invitation === null) {
68		throw new \Exception(sprintf(
69		'Invitation with id %d doesn\'t exist. Maybe it\'s from different tenant?',
70		$invitationId
71		));
72		}
73
74		return $this->acceptInvitation($invitation);
75		}
76
77		/**
78		* @param InvitationInterface $invitation
79		*
80		* @return \Tahoe\Bundle\MultiTenancyBundle\Entity\TenantUser
81		*/
82		public function acceptInvitation(InvitationInterface $invitation)
83		{
84		$user = $this->userRepository->findOneBy(array('emailCanonical' => $invitation->getEmail()));
85
86		$tenant = $invitation->getTenant();
87
88		$tenantUser = $this->tenantUserHandler->addUserToTenant($user, $tenant);
		0 ignored issues – show Documentation introduced 2016-01-18 22:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$user` is of type `object\|null`, but the function expects a `object<Tahoe\Bundle\Mult...ltiTenantUserInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
89
90		$this->entityManager->flush();
91
92		$this->delete($invitation, true);
93
94		return $tenantUser;
95		}
96
97		public function delete($invitation, $withFlush = false)
98		{
99		$this->entityManager->remove($invitation);
100
101		if ($withFlush) {
102		$this->entityManager->flush();
103		}
104		}
105
106	View Code Duplication	public function rejectInvitationById($invitationId)
		0 ignored issues – show Duplication introduced 2016-01-18 22:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
107		{
108		$invitation = $this->invitationRepository->find($invitationId);
109
110		if ($invitation === null) {
111		throw new \Exception(sprintf(
112		'Invitation with id %d doesn\'t exist. Maybe it\'s from different tenant?',
113		$invitationId
114		));
115		}
116
117		return $this->rejectInvitation($invitation);
118		}
119
120		public function rejectInvitation(InvitationInterface $invitation)
121		{
122		$this->delete($invitation, true);
123
124		return true;
125		}
126		}

tahoelimited / multi-tenancy-bundle

Issues (33)

Security Analysis not enabled

Handler/InvitationHandler.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like