Tahoe\Bundle\MultiTenancyBundle\Service\TenantAwareRouter

Complexity

Total Complexity

7

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	1	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
B	generateUrl()	0	26	6

<?php


namespace Tahoe\Bundle\MultiTenancyBundle\Service;

use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\Routing\Router;
use Tahoe\Bundle\MultiTenancyBundle\Model\MultiTenantTenantInterface;

/**
 * Class TenantAwareRouter that cares about tenants! :-)
 *
 * @author Konrad Podgórski <konrad.podgorski@gmail.com>
 */
class TenantAwareRouter
{
    const ABSOLUTE_URL_FALSE = false;
    /**
     * @var RequestStack
     */
    protected $requestStack;
    /**
     * @var string
     */
    protected $domain;
    /**
     * @var Router
     */
    protected $router;

    protected $strategy;

    protected $redirectRoute;

    function __construct($requestStack, $domain , $router, $strategy, $route = '')

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->requestStack = $requestStack;
        $this->domain = $domain;
        $this->router = $router;
        $this->strategy = $strategy;
        $this->redirectRoute = $route;
    }

    /**
     * @param MultiTenantTenantInterface $tenant
     * @param string                           $name

There is no parameter named $name. Was it maybe removed?

     * @param array                            $parameters
     *
     * @return string
     */
    public function generateUrl(MultiTenantTenantInterface $tenant, $parameters = array())
    {
        $url = '';

$url is not used, you could remove the assignment.

        $name = $this->redirectRoute;

        if ($this->strategy == TenantResolver::STRATEGY_TENANT_AWARE_SUBDOMAIN ) {
            $scheme = $this->requestStack->getCurrentRequest()->getScheme();
            $requestPort = $this->requestStack->getCurrentRequest()->getPort();

            $host = $scheme . '://' . $tenant->getSubdomain() . '.' . $this->domain;

            $port = '';
            if ('http' === $scheme && 80 != $requestPort) {
                $port = ':'.$requestPort;
            } elseif ('https' === $scheme && 443 != $requestPort) {
                $port = ':'.$requestPort;
            }

            $url = $host . $port;
            $url .= $this->router->generate($name, $parameters, self::ABSOLUTE_URL_FALSE);

self::ABSOLUTE_URL_FALSE is of type boolean, but the function expects a integer.

            return $url;
        } else {
            return $this->router->generate($name, $parameters);
        }
    }
}