RedirectController - Code Metrics - tadcka/RoutingBundle - Measure and Improve Code Quality continuously with Scrutinizer

RedirectController A
last analyzed 2016-05-17 14:25 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
wmc	6
c	2
b	0
f	1
lcom	1
cbo	5
dl	0
loc	56
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	redirectAction()	0	22	5

<?php

/*
 * This file is part of the Tadcka package.
 *
 * (c) Tadas Gliaubicas <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tadcka\Bundle\RoutingBundle\Controller;

use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\Routing\RouterInterface;
use Tadcka\Component\Routing\Model\Manager\RedirectRouteManagerInterface;

/**
 * @author Tadas Gliaubicas <[email protected]>
 *
 * @since 8/28/14 12:23 PM
 */
class RedirectController
{
    /**
     * @var RedirectRouteManagerInterface
     */
    private $redirectRouteManager;

    /**
     * @var RouterInterface
     */
    private $router;

    /**
     * Constructor.
     *
     * @param RedirectRouteManagerInterface $redirectRouteManager
     * @param RouterInterface $router
     */
    public function __construct(RedirectRouteManagerInterface $redirectRouteManager, RouterInterface $router)
    {
        $this->router = $router;
        $this->redirectRouteManager = $redirectRouteManager;
    }

    /**
     * Action to redirect based on a RedirectRouteInterface route.
     *
     * @param string $redirectRouteName
     *
     * @return RedirectResponse
     *
     * @throws NotFoundHttpException
     */
    public function redirectAction($redirectRouteName)
    {
        $redirectRoute = $this->redirectRouteManager->findByName($redirectRouteName);
        if (null === $redirectRoute) {
            throw new NotFoundHttpException();
        }

        $url = $redirectRoute->getUri();

        if (!$url) {
            $routeTarget = $redirectRoute->getRouteTarget();
            if (null !== $routeTarget) {
                $url = $this->router->generate($routeTarget, $redirectRoute->getParameters(), true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            } else {
                $url = $this->router->generate($redirectRoute->getRouteName(), $redirectRoute->getParameters(), true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }
        }

        $status = $redirectRoute->isPermanent() ? 301 : 302;

        return new RedirectResponse($url, $status);
    }
}


1			<?php
2
3			/*
4			* This file is part of the Tadcka package.
5			*
6			* (c) Tadas Gliaubicas <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Tadcka\Bundle\RoutingBundle\Controller;
13
14			use Symfony\Component\HttpFoundation\RedirectResponse;
15			use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
16			use Symfony\Component\Routing\RouterInterface;
17			use Tadcka\Component\Routing\Model\Manager\RedirectRouteManagerInterface;
18
19			/**
20			* @author Tadas Gliaubicas <[email protected]>
21			*
22			* @since 8/28/14 12:23 PM
23			*/
24			class RedirectController
25			{
26			/**
27			* @var RedirectRouteManagerInterface
28			*/
29			private $redirectRouteManager;
30
31			/**
32			* @var RouterInterface
33			*/
34			private $router;
35
36			/**
37			* Constructor.
38			*
39			* @param RedirectRouteManagerInterface $redirectRouteManager
40			* @param RouterInterface $router
41			*/
42			public function __construct(RedirectRouteManagerInterface $redirectRouteManager, RouterInterface $router)
43			{
44			$this->router = $router;
45			$this->redirectRouteManager = $redirectRouteManager;
46			}
47
48			/**
49			* Action to redirect based on a RedirectRouteInterface route.
50			*
51			* @param string $redirectRouteName
52			*
53			* @return RedirectResponse
54			*
55			* @throws NotFoundHttpException
56			*/
57			public function redirectAction($redirectRouteName)
58			{
59			$redirectRoute = $this->redirectRouteManager->findByName($redirectRouteName);
60			if (null === $redirectRoute) {
61			throw new NotFoundHttpException();
62			}
63
64			$url = $redirectRoute->getUri();
65
66			if (!$url) {
67			$routeTarget = $redirectRoute->getRouteTarget();
68			if (null !== $routeTarget) {
69			$url = $this->router->generate($routeTarget, $redirectRoute->getParameters(), true);
			0 ignored issues – show Documentation introduced 2016-04-16 10:05 UTC by Report Bug Copy Issue Report `$routeTarget` is of type `object<Tadcka\Component\...g\Model\RouteInterface>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2016-04-16 10:05 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
70			} else {
71			$url = $this->router->generate($redirectRoute->getRouteName(), $redirectRoute->getParameters(), true);
			0 ignored issues – show Documentation introduced 2016-04-16 10:05 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
72			}
73			}
74
75			$status = $redirectRoute->isPermanent() ? 301 : 302;
76
77			return new RedirectResponse($url, $status);
78			}
79			}
80

tadcka / RoutingBundle

RedirectController A last analyzed 2016-05-17 14:25 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

RedirectController A
last analyzed 2016-05-17 14:25 UTC