ValuesTrait - Code Metrics - tacone/pipes - Measure and Improve Code Quality continuously with Scrutinizer

ValuesTrait A
last analyzed 2015-12-11 15:06 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	2
Bugs	1	Features	2

Metric	Value
wmc	2
c	2
b	1
f	2
lcom	0
cbo	2
dl	0
loc	24
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	values()	0	4	1
A	toValues()	0	4	1

<?php

namespace Pipes\Filter;

trait ValuesTrait
{
    /**
     * Returns all the elements, reindexes the keys (0,1,2,..,n).
     *
     * Use this to avoid key collisions.
     *
     * @return \Pipes\Pipe
     */
    public function values()
    {
        return $this->chainWith(new \Pipes\Iterator\ValuesIterator($this->getIterator()));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /*
     * Discards the keys, returns an indexed array.
     *
     * Shortcut for <code>p($iterator)->values->toArray();</code>
     */
    public function toValues()
    {
        return $this->values()->toArray();
    }
}


1			<?php
2
3			namespace Pipes\Filter;
4
5			trait ValuesTrait
6			{
7			/**
8			* Returns all the elements, reindexes the keys (0,1,2,..,n).
9			*
10			* Use this to avoid key collisions.
11			*
12			* @return \Pipes\Pipe
13			*/
14			public function values()
15			{
16			return $this->chainWith(new \Pipes\Iterator\ValuesIterator($this->getIterator()));
			0 ignored issues – show Bug introduced 2015-12-11 14:38 UTC by Report Bug Copy Issue Report It seems like `getIterator()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2015-12-11 14:38 UTC by Report Bug Copy Issue Report It seems like `chainWith()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17			}
18
19			/*
20			* Discards the keys, returns an indexed array.
21			*
22			* Shortcut for <code>p($iterator)->values->toArray();</code>
23			*/
24			public function toValues()
25			{
26			return $this->values()->toArray();
27			}
28			}
29

tacone / pipes

GitHub Access Token became invalid

ValuesTrait A last analyzed 2015-12-11 15:06 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

ValuesTrait A
last analyzed 2015-12-11 15:06 UTC