Pipes\Filter\MapTrait

Complexity

Total Complexity

6

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	7
Bugs	2	Features	2

1 Method

Rating	Name	Duplication	Size	Complexity
B	map()	0	32	6

<?php

namespace Pipes\Filter;

use Pipes\Concept\Emittable;

trait MapTrait
{
    /**
     * Tranforms each element into something else using a callback
     * (rough equivalent of array_map()).
     *
     * The callback should return the new element.
     *
     * To also change the key, return<code>p()->emit($key,$value)</code>
     * <code>
     * p()->map(function ($value, $key, $iterator) {
     *     return p()->emit($key.'_new', $value);
     * });
     *
     *
     * @param callable $callback

There is no parameter named $callback. Did you maybe mean $______callback?

     *
     * @return \Pipes\Pipe
     */
    public function map(callable $______callback)
    {
        $iterator = $this->getIterator();

It seems like getIterator() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $pipe = $this;

        if (!is_array($______callback)) {
            $reflectionFunction = new \ReflectionFunction($______callback);
        } else {
            $reflectionFunction = new \ReflectionMethod($______callback[0], $______callback[1]);
        }

        if ($reflectionFunction->isGenerator()) {
            $generator = $______callback;
        } else {
            $generator = function ($iterator) use ($pipe, $______callback) {
                foreach ($iterator as $key => $value) {
                    //                yield $key => $pipe->executeCallback($______callback, true, $value, $key, $iterator);

66% of this comment could be valid code. Did you maybe forget this after debugging?

                    $value = $pipe->executeCallback($______callback, true, $value, $key, $iterator);

It seems like executeCallback() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                    if ($value instanceof Emittable) {
                        if ($value->hasKey()) {
                            $key = $value->getKey();
                        }
                        $value = $value->getValue();
                    }
                    yield $key => $value;
                }
            };
        }

        return $this->chainWith($generator($iterator));

It seems like chainWith() must be provided by classes using this trait. How about adding it as abstract method to this trait?

//        return $this->chainWith(new \Pipes\Iterator\MapIterator($this->toIterator(), $callback));

69% of this comment could be valid code. Did you maybe forget this after debugging?

    }
}