LimitTrait - Code Metrics - tacone/pipes - Measure and Improve Code Quality continuously with Scrutinizer

LimitTrait A
last analyzed 2015-12-11 15:06 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	6
Bugs	2	Features	1

Metric	Value
wmc	4
c	6
b	2
f	1
lcom	0
cbo	0
dl	0
loc	31
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	limit()	0	15	4

<?php

namespace Pipes\Filter;

trait LimitTrait
{
    /**
     * Return only a subset of items. Behaves similarly to MYSQL's
     * "LIMIT" clause.
     * (internally uses \LimitIterator).
     *
     *  <code>p()->limit(5)</code> will return only the first five elements.
     *  <code>p()->limit(2, 5)</code> will skip 2 element, and return the next 5.
     *
     * @param $boundary1
     * @param bool $boundary2
     *
     * @return \Pipes\Pipe
     */
    public function limit($boundary1, $boundary2 = false)
    {
        if (func_num_args() == 1 || $boundary2 === false) {
            $offset = 0;
            $count = $boundary1;
        } else {
            $offset = $boundary1;
            $count = $boundary2;
        }
        if (!$count) {
            return $this->chainWith(new \ArrayIterator([]));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        return $this->chainWith(new \LimitIterator($this->toIterator(), $offset, $count));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace Pipes\Filter;
4
5			trait LimitTrait
6			{
7			/**
8			* Return only a subset of items. Behaves similarly to MYSQL's
9			* "LIMIT" clause.
10			* (internally uses \LimitIterator).
11			*
12			* <code>p()->limit(5)</code> will return only the first five elements.
13			* <code>p()->limit(2, 5)</code> will skip 2 element, and return the next 5.
14			*
15			* @param $boundary1
16			* @param bool $boundary2
17			*
18			* @return \Pipes\Pipe
19			*/
20			public function limit($boundary1, $boundary2 = false)
21			{
22			if (func_num_args() == 1 \|\| $boundary2 === false) {
23			$offset = 0;
24			$count = $boundary1;
25			} else {
26			$offset = $boundary1;
27			$count = $boundary2;
28			}
29			if (!$count) {
30			return $this->chainWith(new \ArrayIterator([]));
			0 ignored issues – show Bug introduced 2015-12-11 14:38 UTC by Report Bug Copy Issue Report It seems like `chainWith()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31			}
32
33			return $this->chainWith(new \LimitIterator($this->toIterator(), $offset, $count));
			0 ignored issues – show Bug introduced 2015-12-11 14:38 UTC by Report Bug Copy Issue Report It seems like `toIterator()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2015-12-11 14:38 UTC by Report Bug Copy Issue Report It seems like `chainWith()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34			}
35			}
36

tacone / pipes

GitHub Access Token became invalid

LimitTrait A last analyzed 2015-12-11 15:06 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like

LimitTrait A
last analyzed 2015-12-11 15:06 UTC