FilterTrait - Code Metrics - tacone/pipes - Measure and Improve Code Quality continuously with Scrutinizer

FilterTrait A
last analyzed 2015-12-11 15:06 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	4
Bugs	2	Features	1

Metric	Value
wmc	1
c	4
b	2
f	1
lcom	0
cbo	0
dl	0
loc	18
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	filter()	0	4	1

<?php

namespace Pipes\Filter;

trait FilterTrait
{
    /**
     * Filters elements with a callback
     * (internally uses \CallbackFilterIterator).
     *
     * Only the elements for which the callback evaluates to TRUE
     * will be used
     *
     * @param callable $callback
     *
     * @return \Pipes\Pipe
     */
    public function filter(callable $callback)
    {
        return $this->chainWith(new \CallbackFilterIterator($this->toIterator(), $callback));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace Pipes\Filter;
4
5			trait FilterTrait
6			{
7			/**
8			* Filters elements with a callback
9			* (internally uses \CallbackFilterIterator).
10			*
11			* Only the elements for which the callback evaluates to TRUE
12			* will be used
13			*
14			* @param callable $callback
15			*
16			* @return \Pipes\Pipe
17			*/
18			public function filter(callable $callback)
19			{
20			return $this->chainWith(new \CallbackFilterIterator($this->toIterator(), $callback));
			0 ignored issues – show Bug introduced 2015-12-11 14:38 UTC by Report Bug Copy Issue Report It seems like `toIterator()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2015-12-11 14:38 UTC by Report Bug Copy Issue Report It seems like `chainWith()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21			}
22			}
23

tacone / pipes

GitHub Access Token became invalid

FilterTrait A last analyzed 2015-12-11 15:06 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like

FilterTrait A
last analyzed 2015-12-11 15:06 UTC