Completed
Push — master ( 706d4d...7d1021 )
by max
02:05
created

VersionResolverFactory   A

Complexity

Total Complexity 1

Size/Duplication

Total Lines 17
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 2

Importance

Changes 1
Bugs 0 Features 1
Metric Value
wmc 1
c 1
b 0
f 1
lcom 0
cbo 2
dl 0
loc 17
rs 10

1 Method

Rating   Name   Duplication   Size   Complexity  
A createService() 0 7 1
1
<?php
2
3
namespace T4web\Migrations\Service;
4
5
use Zend\ServiceManager\FactoryInterface;
6
use Zend\ServiceManager\ServiceLocatorInterface;
7
use T4web\Migrations\Config;
8
use T4web\Migrations\MigrationVersion\Table;
9
10
class VersionResolverFactory implements FactoryInterface
11
{
12
13
    /**
14
     * Create service
15
     *
16
     * @param ServiceLocatorInterface $serviceLocator
17
     * @return mixed
18
     */
19
    public function createService(ServiceLocatorInterface $serviceLocator)
20
    {
21
        return new VersionResolver(
22
            $serviceLocator->get(Config::class),
0 ignored issues
show
Documentation introduced by
$serviceLocator->get(\T4...grations\Config::class) is of type object|array, but the function expects a object<T4web\Migrations\Config>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
23
            $serviceLocator->get(Table::class)
24
        );
25
    }
26
}
27