InMemoryRepository - Code Metrics - Inspection of "Update InMemoryRepository.php" - t4web/Infrastructure - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b0bc78...fffed2 )

by Dmitriy

created 2017-01-27 09:47 UTC

InMemoryRepository B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	360
Duplicated Lines	21.94 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

Metric	Value
wmc	38
lcom	1
cbo	6
dl	79
loc	360
rs	8.3999
c	0
b	0
f	0

18 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	15	1
B	add()	0	31	3
A	remove()	0	15	2
C	find()	17	38	7
A	findById()	0	7	1
C	findMany()	16	34	7
A	count()	0	11	2
A	createCriteria()	0	4	1
A	toIdentityMap()	0	5	1
A	isEntityChanged()	0	5	1
A	getEvent()	9	9	2
A	triggerCreate()	15	15	3
A	triggerDelete()	11	11	1
A	triggerChanges()	0	5	1
A	triggerPreChanges()	0	5	1
A	triggerAttributesChange()	11	11	2
A	getEntityChangeEventName()	0	4	1
A	getAttributeChangeEventName()	0	4	1

How to fix Duplicated Code

<?php

namespace T4webInfrastructure;

use ArrayObject;
use Zend\EventManager\EventManagerInterface;
use Zend\EventManager\Event;
use T4webDomainInterface\Infrastructure\CriteriaInterface;
use T4webDomainInterface\Infrastructure\RepositoryInterface;
use T4webDomainInterface\EntityInterface;
use T4webDomainInterface\EntityFactoryInterface;
use T4webInfrastructure\Event\EntityChangedEvent;

class InMemoryRepository implements RepositoryInterface
{
    /**
     * @var string
     */
    protected $entityName;

    /**
     * @var string
     */
    protected $collectionClass;

    /**
     * @var CriteriaFactory
     */
    protected $criteriaFactory;

    /**
     * @var EntityFactoryInterface
     */
    protected $entityFactory;

    /**
     * @var ArrayObject
     */
    protected $identityMap;

    /**
     * @var ArrayObject
     */
    protected $identityMapOriginal;

    /**
     * @var EventManagerInterface
     */
    protected $eventManager;

    /**
     * @var EntityChangedEvent
     */
    protected $event;

    protected $primaryKey = 1;

    /**
     * @param string $entityName
     * @param string $collectionClass
     * @param CriteriaFactory $criteriaFactory
     * @param EntityFactoryInterface $entityFactory
     * @param EventManagerInterface $eventManager
     */
    public function __construct(
        $entityName,
        $collectionClass,
        CriteriaFactory $criteriaFactory,
        EntityFactoryInterface $entityFactory,
        EventManagerInterface $eventManager
    ) {
        $this->entityName = $entityName;
        $this->collectionClass = $collectionClass;
        $this->criteriaFactory = $criteriaFactory;
        $this->entityFactory = $entityFactory;
        $this->identityMap = new ArrayObject();
        $this->identityMapOriginal = new ArrayObject();
        $this->eventManager = $eventManager;
    }

    /**
     * @param EntityInterface $entity
     * @return EntityInterface|int|null
     */
    public function add(EntityInterface $entity)
    {
        $id = $entity->getId();

        if ($this->identityMap->offsetExists((int)$id)) {
            $e = $this->getEvent();
            $originalEntity = $this->identityMapOriginal->offsetGet($entity->getId());
            $e->setOriginalEntity($originalEntity);
            $e->setChangedEntity($entity);

            $this->triggerPreChanges($e);

            $this->toIdentityMap($entity);

            $this->triggerChanges($e);
            $this->triggerAttributesChange($e);

            return 1;
        } else {
            if (empty($id)) {
                $id = $this->primaryKey++;
                $entity->populate(compact('id'));
            }

            $this->toIdentityMap($entity);

            $this->triggerCreate($entity);
        }

        return $entity;
    }

    /**
     * @param EntityInterface $entity
     * @return int|null
     */
    public function remove(EntityInterface $entity)
    {
        $id = $entity->getId();

        if ($this->identityMap->offsetExists((int)$id)) {
            $this->identityMap->offsetUnset($id);
            $result = 1;
        } else {
            $result = 0;
        }

        $this->triggerDelete($entity);

        return $result;
    }

    /**
     * @param CriteriaInterface|array $criteria
     * @return EntityInterface|null
     */
    public function find($criteria)
    {
        if (is_array($criteria)) {
            $criteria = $this->createCriteria($criteria);
        }

        $callbacks = $criteria->getQuery();

        $result = null;
        /** @var EntityInterface $entity */
        foreach ($this->identityMap as $entity) {


            $data = $entity->extract();
            $isSatisfied = true;

            foreach ($callbacks as $callback) {
                if (!$callback($data)) {
                    $isSatisfied = false;
                    break 1;
                }
            }

            if ($isSatisfied) {
                $result = $entity;
                break;
            }
        }

        if (is_null($result)) {
            return;
        }

        $entity = $result;

        $this->toIdentityMap($entity);

        return $entity;
    }

    /**
     * @param mixed $id
     * @return EntityInterface|null
     */
    public function findById($id)
    {
        $criteria = $this->createCriteria();
        $criteria->equalTo('id', $id);

        return $this->find($criteria);
    }

    /**
     * @param CriteriaInterface|array $criteria
     * @return EntityInterface[]
     */
    public function findMany($criteria)
    {
        if (is_array($criteria)) {
            $criteria = $this->createCriteria($criteria);
        }

        $callbacks = $criteria->getQuery();

        $entities = new $this->collectionClass;

        /** @var EntityInterface $entity */
        foreach ($this->identityMap as $entity) {


            $data = $entity->extract();
            $isSatisfied = true;

            foreach ($callbacks as $callback) {
                if (!$callback($data)) {
                    $isSatisfied = false;
                    break 1;
                }
            }

            if ($isSatisfied) {
                $entities->offsetSet($entity->getId(), $entity);
            }
        }

        foreach ($entities as $entity) {
            $this->toIdentityMap($entity);
        }

        return $entities;
    }

    /**
     * @param CriteriaInterface|array $criteria
     * @return int
     */
    public function count($criteria)
    {
        if (is_array($criteria)) {
            $criteria = $this->createCriteria($criteria);
        }

        /** @var ArrayObject $entities */
        $entities = $this->findMany($criteria);

        return $entities->count();
    }

    /**
     * @param array $filter
     * @return CriteriaInterface
     */
    public function createCriteria(array $filter = [])
    {
        return $this->criteriaFactory->buildInMemory($this->entityName, $filter);
    }

    /**
     * @param EntityInterface $entity
     */
    protected function toIdentityMap(EntityInterface $entity)
    {
        $this->identityMap->offsetSet($entity->getId(), $entity);
        $this->identityMapOriginal->offsetSet($entity->getId(), clone $entity);
    }

    /**
     * @param EntityInterface $changedEntity
     * @return bool
     */
    protected function isEntityChanged(EntityInterface $changedEntity)
    {
        $originalEntity = $this->identityMapOriginal->offsetGet($changedEntity->getId());
        return $changedEntity != $originalEntity;
    }

    /**
     * @return EntityChangedEvent
     */
    protected function getEvent()

    {
        if (null === $this->event) {
            $this->event = new EntityChangedEvent();
            $this->event->setTarget($this);
        }

        return $this->event;
    }

    /**
     * @param EntityInterface $createdEntity
     */
    protected function triggerCreate(EntityInterface &$createdEntity)

    {
        $this->eventManager->addIdentifiers(get_class($createdEntity));

        $event = new Event(
            sprintf('entity:%s:created', get_class($createdEntity)),
            $this,
            ['entity' => $createdEntity]
        );
        $this->eventManager->trigger($event);

        if ($event->getParam('entity') && $event->getParam('entity') instanceof EntityInterface) {
            $createdEntity = $event->getParam('entity');
        }
    }

    /**
     * @param EntityInterface $deletedEntity
     */
    protected function triggerDelete(EntityInterface $deletedEntity)

    {
        $this->eventManager->addIdentifiers(get_class($deletedEntity));

        $event = new Event(
            sprintf('entity:%s:deleted', get_class($deletedEntity)),
            $this,
            ['entity' => $deletedEntity]
        );
        $this->eventManager->trigger($event);
    }

    /**
     * @param EntityChangedEvent $e
     */
    protected function triggerChanges(EntityChangedEvent $e)
    {
        $changedEntity = $e->getChangedEntity();
        $this->eventManager->trigger($this->getEntityChangeEventName($changedEntity), $this, $e);
    }

    /**
     * @param EntityChangedEvent $e
     */
    protected function triggerPreChanges(EntityChangedEvent $e)
    {
        $changedEntity = $e->getChangedEntity();
        $this->eventManager->trigger($this->getEntityChangeEventName($changedEntity).':pre', $this, $e);
    }

    /**
     * @param EntityChangedEvent $e
     */
    protected function triggerAttributesChange(EntityChangedEvent $e)

    {
        $changedEntity = $e->getChangedEntity();

        $originalAttrs = $e->getOriginalEntity()->extract();
        $changedAttrs = $changedEntity->extract();

        foreach (array_keys(array_diff_assoc($originalAttrs, $changedAttrs)) as $attribute) {
            $this->eventManager->trigger($this->getAttributeChangeEventName($changedEntity, $attribute), $this, $e);
        }
    }

    /**
     * @param EntityInterface $changedEntity
     * @return string
     */
    protected function getEntityChangeEventName(EntityInterface $changedEntity)
    {
        return sprintf('entity:%s:changed', get_class($changedEntity));
    }

    /**
     * @param EntityInterface $changedEntity
     * @param $attributeName
     * @return string
     */
    protected function getAttributeChangeEventName(EntityInterface $changedEntity, $attributeName)
    {
        return sprintf('attribute:%s:%s:changed', get_class($changedEntity), $attributeName);
    }
}


1		<?php
2
3		namespace T4webInfrastructure;
4
5		use ArrayObject;
6		use Zend\EventManager\EventManagerInterface;
7		use Zend\EventManager\Event;
8		use T4webDomainInterface\Infrastructure\CriteriaInterface;
9		use T4webDomainInterface\Infrastructure\RepositoryInterface;
10		use T4webDomainInterface\EntityInterface;
11		use T4webDomainInterface\EntityFactoryInterface;
12		use T4webInfrastructure\Event\EntityChangedEvent;
13
14		class InMemoryRepository implements RepositoryInterface
15		{
16		/**
17		* @var string
18		*/
19		protected $entityName;
20
21		/**
22		* @var string
23		*/
24		protected $collectionClass;
25
26		/**
27		* @var CriteriaFactory
28		*/
29		protected $criteriaFactory;
30
31		/**
32		* @var EntityFactoryInterface
33		*/
34		protected $entityFactory;
35
36		/**
37		* @var ArrayObject
38		*/
39		protected $identityMap;
40
41		/**
42		* @var ArrayObject
43		*/
44		protected $identityMapOriginal;
45
46		/**
47		* @var EventManagerInterface
48		*/
49		protected $eventManager;
50
51		/**
52		* @var EntityChangedEvent
53		*/
54		protected $event;
55
56		protected $primaryKey = 1;
57
58		/**
59		* @param string $entityName
60		* @param string $collectionClass
61		* @param CriteriaFactory $criteriaFactory
62		* @param EntityFactoryInterface $entityFactory
63		* @param EventManagerInterface $eventManager
64		*/
65		public function __construct(
66		$entityName,
67		$collectionClass,
68		CriteriaFactory $criteriaFactory,
69		EntityFactoryInterface $entityFactory,
70		EventManagerInterface $eventManager
71		) {
72		$this->entityName = $entityName;
73		$this->collectionClass = $collectionClass;
74		$this->criteriaFactory = $criteriaFactory;
75		$this->entityFactory = $entityFactory;
76		$this->identityMap = new ArrayObject();
77		$this->identityMapOriginal = new ArrayObject();
78		$this->eventManager = $eventManager;
79		}
80
81		/**
82		* @param EntityInterface $entity
83		* @return EntityInterface\|int\|null
84		*/
85		public function add(EntityInterface $entity)
86		{
87		$id = $entity->getId();
88
89		if ($this->identityMap->offsetExists((int)$id)) {
90		$e = $this->getEvent();
91		$originalEntity = $this->identityMapOriginal->offsetGet($entity->getId());
92		$e->setOriginalEntity($originalEntity);
93		$e->setChangedEntity($entity);
94
95		$this->triggerPreChanges($e);
96
97		$this->toIdentityMap($entity);
98
99		$this->triggerChanges($e);
100		$this->triggerAttributesChange($e);
101
102		return 1;
103		} else {
104		if (empty($id)) {
105		$id = $this->primaryKey++;
106		$entity->populate(compact('id'));
107		}
108
109		$this->toIdentityMap($entity);
110
111		$this->triggerCreate($entity);
112		}
113
114		return $entity;
115		}
116
117		/**
118		* @param EntityInterface $entity
119		* @return int\|null
120		*/
121		public function remove(EntityInterface $entity)
122		{
123		$id = $entity->getId();
124
125		if ($this->identityMap->offsetExists((int)$id)) {
126		$this->identityMap->offsetUnset($id);
127		$result = 1;
128		} else {
129		$result = 0;
130		}
131
132		$this->triggerDelete($entity);
133
134		return $result;
135		}
136
137		/**
138		* @param CriteriaInterface\|array $criteria
139		* @return EntityInterface\|null
140		*/
141		public function find($criteria)
142		{
143		if (is_array($criteria)) {
144		$criteria = $this->createCriteria($criteria);
145		}
146
147		$callbacks = $criteria->getQuery();
148
149		$result = null;
150		/** @var EntityInterface $entity */
151	View Code Duplication	foreach ($this->identityMap as $entity) {
		0 ignored issues – show Duplication introduced 2017-01-27 09:50 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
152
153		$data = $entity->extract();
154		$isSatisfied = true;
155
156		foreach ($callbacks as $callback) {
157		if (!$callback($data)) {
158		$isSatisfied = false;
159		break 1;
160		}
161		}
162
163		if ($isSatisfied) {
164		$result = $entity;
165		break;
166		}
167		}
168
169		if (is_null($result)) {
170		return;
171		}
172
173		$entity = $result;
174
175		$this->toIdentityMap($entity);
176
177		return $entity;
178		}
179
180		/**
181		* @param mixed $id
182		* @return EntityInterface\|null
183		*/
184		public function findById($id)
185		{
186		$criteria = $this->createCriteria();
187		$criteria->equalTo('id', $id);
188
189		return $this->find($criteria);
190		}
191
192		/**
193		* @param CriteriaInterface\|array $criteria
194		* @return EntityInterface[]
195		*/
196		public function findMany($criteria)
197		{
198		if (is_array($criteria)) {
199		$criteria = $this->createCriteria($criteria);
200		}
201
202		$callbacks = $criteria->getQuery();
203
204		$entities = new $this->collectionClass;
205
206		/** @var EntityInterface $entity */
207	View Code Duplication	foreach ($this->identityMap as $entity) {
		0 ignored issues – show Duplication introduced 2017-01-27 09:50 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
208
209		$data = $entity->extract();
210		$isSatisfied = true;
211
212		foreach ($callbacks as $callback) {
213		if (!$callback($data)) {
214		$isSatisfied = false;
215		break 1;
216		}
217		}
218
219		if ($isSatisfied) {
220		$entities->offsetSet($entity->getId(), $entity);
221		}
222		}
223
224		foreach ($entities as $entity) {
225		$this->toIdentityMap($entity);
226		}
227
228		return $entities;
229		}
230
231		/**
232		* @param CriteriaInterface\|array $criteria
233		* @return int
234		*/
235		public function count($criteria)
236		{
237		if (is_array($criteria)) {
238		$criteria = $this->createCriteria($criteria);
239		}
240
241		/** @var ArrayObject $entities */
242		$entities = $this->findMany($criteria);
243
244		return $entities->count();
245		}
246
247		/**
248		* @param array $filter
249		* @return CriteriaInterface
250		*/
251		public function createCriteria(array $filter = [])
252		{
253		return $this->criteriaFactory->buildInMemory($this->entityName, $filter);
254		}
255
256		/**
257		* @param EntityInterface $entity
258		*/
259		protected function toIdentityMap(EntityInterface $entity)
260		{
261		$this->identityMap->offsetSet($entity->getId(), $entity);
262		$this->identityMapOriginal->offsetSet($entity->getId(), clone $entity);
263		}
264
265		/**
266		* @param EntityInterface $changedEntity
267		* @return bool
268		*/
269		protected function isEntityChanged(EntityInterface $changedEntity)
270		{
271		$originalEntity = $this->identityMapOriginal->offsetGet($changedEntity->getId());
272		return $changedEntity != $originalEntity;
273		}
274
275		/**
276		* @return EntityChangedEvent
277		*/
278	View Code Duplication	protected function getEvent()
		0 ignored issues – show Duplication introduced 2017-01-22 10:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
279		{
280		if (null === $this->event) {
281		$this->event = new EntityChangedEvent();
282		$this->event->setTarget($this);
283		}
284
285		return $this->event;
286		}
287
288		/**
289		* @param EntityInterface $createdEntity
290		*/
291	View Code Duplication	protected function triggerCreate(EntityInterface &$createdEntity)
		0 ignored issues – show Duplication introduced 2017-01-22 10:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
292		{
293		$this->eventManager->addIdentifiers(get_class($createdEntity));
294
295		$event = new Event(
296		sprintf('entity:%s:created', get_class($createdEntity)),
297		$this,
298		['entity' => $createdEntity]
299		);
300		$this->eventManager->trigger($event);
301
302		if ($event->getParam('entity') && $event->getParam('entity') instanceof EntityInterface) {
303		$createdEntity = $event->getParam('entity');
304		}
305		}
306
307		/**
308		* @param EntityInterface $deletedEntity
309		*/
310	View Code Duplication	protected function triggerDelete(EntityInterface $deletedEntity)
		0 ignored issues – show Duplication introduced 2017-01-22 10:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
311		{
312		$this->eventManager->addIdentifiers(get_class($deletedEntity));
313
314		$event = new Event(
315		sprintf('entity:%s:deleted', get_class($deletedEntity)),
316		$this,
317		['entity' => $deletedEntity]
318		);
319		$this->eventManager->trigger($event);
320		}
321
322		/**
323		* @param EntityChangedEvent $e
324		*/
325		protected function triggerChanges(EntityChangedEvent $e)
326		{
327		$changedEntity = $e->getChangedEntity();
328		$this->eventManager->trigger($this->getEntityChangeEventName($changedEntity), $this, $e);
329		}
330
331		/**
332		* @param EntityChangedEvent $e
333		*/
334		protected function triggerPreChanges(EntityChangedEvent $e)
335		{
336		$changedEntity = $e->getChangedEntity();
337		$this->eventManager->trigger($this->getEntityChangeEventName($changedEntity).':pre', $this, $e);
338		}
339
340		/**
341		* @param EntityChangedEvent $e
342		*/
343	View Code Duplication	protected function triggerAttributesChange(EntityChangedEvent $e)
		0 ignored issues – show Duplication introduced 2017-01-22 10:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
344		{
345		$changedEntity = $e->getChangedEntity();
346
347		$originalAttrs = $e->getOriginalEntity()->extract();
348		$changedAttrs = $changedEntity->extract();
349
350		foreach (array_keys(array_diff_assoc($originalAttrs, $changedAttrs)) as $attribute) {
351		$this->eventManager->trigger($this->getAttributeChangeEventName($changedEntity, $attribute), $this, $e);
352		}
353		}
354
355		/**
356		* @param EntityInterface $changedEntity
357		* @return string
358		*/
359		protected function getEntityChangeEventName(EntityInterface $changedEntity)
360		{
361		return sprintf('entity:%s:changed', get_class($changedEntity));
362		}
363
364		/**
365		* @param EntityInterface $changedEntity
366		* @param $attributeName
367		* @return string
368		*/
369		protected function getAttributeChangeEventName(EntityInterface $changedEntity, $attributeName)
370		{
371		return sprintf('attribute:%s:%s:changed', get_class($changedEntity), $attributeName);
372		}
373		}
374

t4web / Infrastructure

Push — master ( b0bc78...fffed2 )

InMemoryRepository B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

18 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like