TextFileFactory::createService()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 7
Code Lines 4

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 7
rs 9.4285
c 0
b 0
f 0
cc 1
eloc 4
nc 1
nop 1
1
<?php
2
3
namespace T4web\Cron\Log;
4
5
use Zend\ServiceManager\ServiceLocatorInterface;
6
use Zend\ServiceManager\FactoryInterface;
7
use T4web\Cron\Config;
8
9
class TextFileFactory implements FactoryInterface
10
{
11
    /**
12
     * Create service
13
     *
14
     * @param ServiceLocatorInterface $serviceLocator
15
     * @return TextFile
16
     */
17
    public function createService(ServiceLocatorInterface $serviceLocator)
18
    {
19
        return new TextFile(
20
            new FileSystem(),
21
            $serviceLocator->get(Config::class)
0 ignored issues
show
Documentation introduced by
$serviceLocator->get(\T4web\Cron\Config::class) is of type object|array, but the function expects a object<T4web\Cron\Config>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
22
        );
23
    }
24
}
25