T4web\Cron\Listener\SaveReport

Complexity

Total Complexity

2

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	__invoke()	0	14	1

<?php

namespace T4web\Cron\Listener;

use T4web\Cron\JobEndedEvent;
use T4web\Cron\Log\LoggerInterface;

class SaveReport
{
    /**
     * @var LoggerInterface
     */
    private $logger;

    public function __construct(LoggerInterface $logger)
    {
        $this->logger = $logger;
    }

    public function __invoke(JobEndedEvent $e)
    {
        $report = $e->getReport();

        $this->logger->log(
            $e->getJob()->getId(),
            $report->getStartTime(),
            $report->getEndTime(),
            $report->isSuccessful(),

It seems like $report->isSuccessful() targeting Cron\Report\JobReport::isSuccessful() can also be of type null; however, T4web\Cron\Log\LoggerInterface::log() does only seem to accept boolean, maybe add an additional type check?

            $report->getOutput(),
            $report->getError()
        );

    }
}