AuthenticatorFactory::createService()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 7
Code Lines 4

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
c 1
b 0
f 0
dl 0
loc 7
rs 9.4285
cc 1
eloc 4
nc 1
nop 1
1
<?php
2
3
namespace T4web\Authentication\Service;
4
5
use Zend\ServiceManager\ServiceLocatorInterface;
6
use Zend\ServiceManager\FactoryInterface;
7
use Zend\Authentication\Adapter\AdapterInterface;
8
use Zend\Authentication\AuthenticationService;
9
10
class AuthenticatorFactory implements FactoryInterface
11
{
12
    /**
13
     * @param ServiceLocatorInterface $serviceLocator
14
     * @return Authenticator
15
     */
16
    public function createService(ServiceLocatorInterface $serviceLocator)
17
    {
18
        return new Authenticator(
19
            new AuthenticationService(),
20
            $serviceLocator->get(AdapterInterface::class)
0 ignored issues
show
Documentation introduced by
$serviceLocator->get(\Ze...dapterInterface::class) is of type object|array, but the function expects a object<Zend\Authenticati...apter\AdapterInterface>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
21
        );
22
    }
23
}
24