IndexController::loginFormAction() - Code Metrics - t4web/Authentication - Measure and Improve Code Quality continuously with Scrutinizer

IndexController::loginFormAction() B
last analyzed 2016-09-05 08:08 UTC

↳ Parent: IndexController

Complexity

Conditions	5
Paths	4

Size

Total Lines	25
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	7
Bugs	1	Features	0

Metric	Value
c	7
b	1
f	0
dl	0
loc	25
rs	8.439
cc	5
eloc	15
nc	4
nop	0

<?php

namespace T4web\Authentication\Controller\User;

use Zend\Mvc\Controller\AbstractActionController;
use Zend\View\Model\ViewModel;
use Zend\Mvc\Controller\Plugin\Redirect;
use T4web\Authentication\Service\InteractiveAuth;

class IndexController extends AbstractActionController
{
    /**
     * @var InteractiveAuth
     */
    private $auth;

    /**
     * @var Redirect
     */
    private $redirect;

    /**
     * @var string
     */
    private $redirectToUrl;

    /**
     * IndexController constructor.
     *
     * @param InteractiveAuth $auth
     * @param Redirect        $redirect
     * @param string          $redirectToUrl
     */
    public function __construct(
        InteractiveAuth $auth,
        Redirect $redirect,
        $redirectToUrl = '/'
    )
    {
        $this->auth = $auth;
        $this->redirect = $redirect;
        $this->redirectToUrl = $redirectToUrl;
    }

    public function loginFormAction()
    {
        if (!$this->getRequest()->isPost()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return;
        }

        $username = $this->getRequest()->getPost('username');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $password = $this->getRequest()->getPost('password');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        
        if (empty($username) || empty($password)) {
            $view = new ViewModel();
            $view->errorMessage = 'User name or pass cannot be empty.';
            return $view;
        }

        $result = $this->auth->login($username, $password);

        if (!$result->isValid()) {
            $view = new ViewModel();
            $view->errorMessage = $result->getMessages()[0];
            return $view;
        }

        return $this->redirect->toUrl($this->redirectToUrl);
    }

    public function logoutAction()
    {
        $this->auth->logout();
        return $this->redirect->toUrl($this->redirectToUrl);
    }
}


1			<?php
2
3			namespace T4web\Authentication\Controller\User;
4
5			use Zend\Mvc\Controller\AbstractActionController;
6			use Zend\View\Model\ViewModel;
7			use Zend\Mvc\Controller\Plugin\Redirect;
8			use T4web\Authentication\Service\InteractiveAuth;
9
10			class IndexController extends AbstractActionController
11			{
12			/**
13			* @var InteractiveAuth
14			*/
15			private $auth;
16
17			/**
18			* @var Redirect
19			*/
20			private $redirect;
21
22			/**
23			* @var string
24			*/
25			private $redirectToUrl;
26
27			/**
28			* IndexController constructor.
29			*
30			* @param InteractiveAuth $auth
31			* @param Redirect $redirect
32			* @param string $redirectToUrl
33			*/
34			public function __construct(
35			InteractiveAuth $auth,
36			Redirect $redirect,
37			$redirectToUrl = '/'
38			)
39			{
40			$this->auth = $auth;
41			$this->redirect = $redirect;
42			$this->redirectToUrl = $redirectToUrl;
43			}
44
45			public function loginFormAction()
46			{
47			if (!$this->getRequest()->isPost()) {
			0 ignored issues – show Bug introduced 2016-02-23 08:02 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Zend\Stdlib\RequestInterface` as the method `isPost()` does only exist in the following implementations of said interface: `Zend\Http\PhpEnvironment\Request`, `Zend\Http\Request`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
48			return;
49			}
50
51			$username = $this->getRequest()->getPost('username');
			0 ignored issues – show Bug introduced 2016-02-23 08:02 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Zend\Stdlib\RequestInterface` as the method `getPost()` does only exist in the following implementations of said interface: `Zend\Http\PhpEnvironment\Request`, `Zend\Http\Request`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
52			$password = $this->getRequest()->getPost('password');
			0 ignored issues – show Bug introduced 2016-02-23 08:02 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Zend\Stdlib\RequestInterface` as the method `getPost()` does only exist in the following implementations of said interface: `Zend\Http\PhpEnvironment\Request`, `Zend\Http\Request`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
53
54			if (empty($username) \|\| empty($password)) {
55			$view = new ViewModel();
56			$view->errorMessage = 'User name or pass cannot be empty.';
57			return $view;
58			}
59
60			$result = $this->auth->login($username, $password);
61
62			if (!$result->isValid()) {
63			$view = new ViewModel();
64			$view->errorMessage = $result->getMessages()[0];
65			return $view;
66			}
67
68			return $this->redirect->toUrl($this->redirectToUrl);
69			}
70
71			public function logoutAction()
72			{
73			$this->auth->logout();
74			return $this->redirect->toUrl($this->redirectToUrl);
75			}
76			}
77

t4web / Authentication

IndexController::loginFormAction() B last analyzed 2016-09-05 08:08 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

IndexController::loginFormAction() B
last analyzed 2016-09-05 08:08 UTC