Issues in LeagueController.php (master) - Issues in master - t2t2/draft - Measure and Improve Code Quality continuously with Scrutinizer

Issues (103)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/controllers/LeagueController.php (18 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

use Illuminate\Support\Collection;
class GraphMovie {
namespace YourVendor;

class YourClass { }
	public $earnings;
	private $earliest = NULL;
	public function __construct() {
		$this->earnings = new Collection();
	}
	public function addEarning($date,$earning) {
		$this->earnings->put($date,$earning);
		if (($this->earliest != NULL && $date < $this->earliest) || $this->earliest == NULL) {
			$this->earliest = $date;
		}
	}
	public function sort() {
		$this->earnings->sortBy(function($role){return $role;});
	}
	public function getEarningForDate($date) {
		//No data yet
		if(count($this->earnings)==0) {
			return 0;
		}
		//Data exists
		if($this->earnings->contains($date)) {
			return $this->earnings->get($date);
		}
		
		//Before earliest data
		//if ($this->earliest != NULL && $date < $this->earliest) {

		//	return 0;
		//}
		
		//Gap somewhere. Iterate through earnings and find the 
		//Assume sorted
		$retval = 0;
		foreach ($this->earnings->keys() as $checkdate) {
			if ($checkdate > $date) {
				return $retval; //Return the entry before this 
			}
			$retval = $this->earnings->get($checkdate);
		}
		
		//?
		return $retval;
	}
}
class LeagueController extends PageController {
namespace YourVendor;

class YourClass { }


	/**
	 * Leagues list page
	 */
	public function index() {
		$search = Input::all();

		// Generate seasons array, also default season.
		$seasons_list = [];
		$seasons = Config::get('draft.seasons');
		$now = Carbon::now();

		if (isset($search['season']) && ! array_key_exists($search['season'], $seasons) && $search['season'] != 0) {
			unset($search['season']);
		}

		foreach ($seasons as $key => $info) {
			$seasons_list[$key] = $info['name'];
			if (! isset($search['season'])) {
				$start = call_user_func_array(['Carbon', 'create'], $info['start']);
				$end = call_user_func_array(['Carbon', 'create'], $info['end']);
				if ($now->between($start, $end)) {
					$search['season'] = $key;
				}
			}
		}
		// Generate years array, also default year
		$years_list = range($now->year + 1, Config::get('draft.earliest_year'), -1);
		$years_list = array_combine($years_list, $years_list);
		if (! isset($search['year']) || ! isset($years_list[$search['year']])) {
			$search['year'] = $now->year;
		}
		if(! isset($search['inactive'])) {
			$search['inactive'] = false;
		}

		// Generate the query
		/** @type League|\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder $leagues_query */
		$leagues_query = League::query();

		$leagues_query->where('private', 0);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

		// Season
		if ($search['season'] != 0) {
			$leagues_query->season($search['year'], $search['season']);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
		}
		// Active
		$leagues_query->where('active', !$search['inactive']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);


		$leagues = $leagues_query->paginate(10);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

		// Output
		$this->layout->title = 'Leagues';
		$this->layout->content = View::make('league.index', [
			'leagues' => $leagues,
			'seasons' => $seasons_list,
			'years'   => $years_list,
			'search'  => $search,
		]);
	}

	/**
	 * Show leagues related to the current user
	 */
	public function mine() {
		/** @type League|\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder $leagues_query */
		$leagues_query = League::query();

		// Where the user is a player
		$leagues_query->whereExists(function (\Illuminate\Database\Query\Builder $query) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
			$query->select([DB::raw(1)])
			      ->from('league_teams')
			      ->join('league_team_user', 'league_teams.id', '=', 'league_team_user.league_team_id')
			      ->where('league_team_user.user_id', Auth::user()->id)
			      ->whereRaw('league_teams.league_id = leagues.id');
		});

		// Where the user is an admin
		$leagues_query->orWhereExists(function (\Illuminate\Database\Query\Builder $query) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
			$query->select([DB::raw(1)])
			      ->from('league_admins')
			      ->where('league_admins.user_id', Auth::user()->id)
			      ->whereRaw('league_admins.league_id = leagues.id');
		});

		$leagues_query->orderBy('start_date', 'desc');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
		$leagues_query->select('leagues.*');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
		$leagues = $leagues_query->paginate(10);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

		// Output
		$this->layout->title = 'My Leagues';
		$this->layout->content = View::make('league.mine', compact('leagues'));
	}

	/**
	 * New league validation rules
	 * @var array
	 */
	public $league_valid_rules = [
		'name'        => ['required', 'max:255'],
		'description' => ['required'],
		'url'         => ['url'],
		'private'     => ['boolean'],

		'money'       => ['required', 'integer'],
		'units'       => ['required', 'max:16'],
		'extra_weeks' => ['required', 'integer', 'between:1,12'],
	];

	/**
	 * League creation form
	 */
	public function create() {

		$this->layout->title = 'Create league';
		$this->layout->content = View::make('league.create', [
			'validation_rules' => $this->league_valid_rules,
		]);
	}

	/**
	 * League creation
	 */
	public function store() {
		$validator = Validator::make(Input::all(), $this->league_valid_rules);
		if ($validator->fails()) {
			Notification::error('Whoops, something is wrong with your input. Check your errors and try again.');

			return Redirect::route('league.create')->withInput()->withErrors($validator);
		}

		// Create the league
		$league = new League(Input::only([
			'name', 'description', 'url', 'money', 'units'
		]));
		$league->private = Input::get('private') ? true : false;
		$league->mode = 'bid';
		$league->extra_weeks = Input::get('extra_weeks');
		$league->start_date = $league->end_date = Carbon::now()->addWeeks(Config::get('draft.maximum_weeks'));

		if ($league->save()) {
			// Attach current user as league admin
			$league->admins()->attach(Auth::user());

			Notification::success('Your league has been created.');

			return Redirect::route('league.show', ['league_slug' => $league->slug]);
		} else {
			Notification::error('Database error, please try again later.');

			return Redirect::back()->withInput();
		}
	}

	/**
	 * League page
	 *
	 * @param League $league
	 */
	public function show(League $league) {
		$league->load(['teams', 'teams.users', 'teams.movies' => function($query) {
			/** @type LeagueMovie|\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder $query */
			$query->ordered();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
		}, 'teams.movies.movie', 'teams.movies.latestEarnings']);

		// Pre-do some work for teams and sort them by earnings
		$teams = new Collection();

		foreach ($league->teams as $team) {
			$earnings = $team->movies->reduce(function ($total, LeagueMovie $movie) {
				if ($movie->latestEarnings) {
					return $total + $movie->latestEarnings->domestic;
				} else {
					return $total;
				}
			}, 0);
			$paid_for = $team->movies->reduce(function ($total, LeagueMovie $movie) {
				return $total + $movie->price;
			}, 0);
			$teams->push(compact('team', 'earnings', 'paid_for'));
		}
		$teams->sortByDesc('earnings');

		$this->layout->content = View::make('league.show', compact('league', 'teams'));
		$this->layout->content->show_league_info = true;
	}
	
	public function getChartData(League $league) {
		$complete = new Collection();
		$possible_dates = new Collection();
		$startdate = $league->start_date;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$enddate = $league->end_date;
		$league->load(['teams.movies.movie.earnings' => function($query) {

		}])->where('movie_earnings.date','<=',$enddate);
		
		//Find all possible dates first
		foreach ($league->teams as $team) {
			foreach ($team->movies as $movie) {
				foreach ($movie->movie->earnings as $earning){
					if($earning->date >= $league->start_date && $earning->date <= $league->end_date) {
						$possible_dates->push($earning->date->format("U"));
					}
				}
			}
		}
		$possible_dates = $possible_dates->unique();
		$possible_dates->sortBy(function($role){return $role;});
		
		//Go through the teams and populate the data
		foreach ($league->teams as $team) {
			$team_info = new Collection();
			$team_earnings = new Collection();
			$movies = new Collection();
			$complete->push($team_info);
			$team_info->put("data",$team_earnings);
			$team_info->put("label",$team->name);
			$team_info->put("id",$team->id);

			//Fill actual data for movies now
			foreach ($team->movies as $movie) {
				foreach ($movie->movie->earnings as $earning){
					$mydate = $earning->date->format("U");
					if($possible_dates->contains($mydate)) {
						$movieinfo = $movies->get($movie->movie->id,new GraphMovie());
						$movieinfo->addEarning($mydate,$earning->domestic);
						$movies->put($movie->movie->id,$movieinfo);
					}
				}
			}
			//Sort movies so we can evaluate gaps
			foreach ($movies->values() as $movie) {
				$movie->sort();
			}
			foreach ($possible_dates->values() as $date) {
				$item = new Collection();
				$item->push($date * 1000); 
				$movietotal = 0;
				foreach ($movies->values() as $movie) {
					$movietotal += $movie->getEarningForDate($date);
				}
				$item->push($movietotal);
				$team_earnings->push($item);
			}
		}
		
		return Response::json($complete);
	}

	/**
	 * League display based by movies
	 *
	 * @param League $league
	 */
	public function showMovies(League $league) {
		// Preload data
		$league->load(['movies' => function($query) {
			/** @type LeagueMovie|\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder $query */
			$query->ordered();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
		}, 'movies.movie', 'movies.latestEarnings', 'movies.teams']);

		$this->layout->content = View::make('league.show.movies', compact('league'));
		$this->layout->content->show_league_info = true;
	}
} 

Issues (103)

Security Analysis not enabled

app/controllers/LeagueController.php (18 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

t2t2 / draft

Issues (103)

Security Analysis not enabled

app/controllers/LeagueController.php (18 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like