Issues in AdminController.php (master) - Issues in master - t2t2/draft - Measure and Improve Code Quality continuously with Scrutinizer

Issues (103)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/controllers/AdminController.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

//namespace Admin;

use Illuminate\Support\Facades\Input;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Krucas\Notification\Facades\Notification;
use Illuminate\Support\Facades\Redirect;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Carbon\Carbon;
use Goutte\Client;
use Symfony\Component\DomCrawler\Crawler;
class AdminController extends \AdminBaseController {
namespace YourVendor;

class YourClass { }

	/**
	 * Admin Homepage
	 */
	public function index() {
		$stats = [
			'users' => User::count(),
			'leagues' => League::count(),
			'movies' => Movie::count(),
		];


		$this->layout->title = 'Admin';
		$this->layout->content = View::make('admin.index', compact('stats'));
	}
	
	public function movies() {
		$movies_query = Movie::query();
		$movies_query->orderBy('release', 'desc');
		$movies_query->select('movies.*');
		$movies = $movies_query->paginate(50);
		$this->layout->title = 'Movies';
		$this->layout->content = View::make('admin.movies',compact('movies'));
	}	
	public function addMovie() {
		$mojo_id = str_replace(".htm",'',Input::get('movie'));
		$info = new stdClass();
		$info->found = false;
		$info->mojo_id = $mojo_id;
		$info->old = null;
		$info->grosses = null;
		if ($mojo_id != '')
		{
			$client = new Client();
			$crawler = $client->request('GET', 'http://www.boxofficemojo.com/movies/?page=daily&view=chart&id='.$mojo_id.'.htm', [], [], [
				'HTTP_USER_AGENT' => "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0"
			]);
			$mojo_query = Movie::query();
			$mojo_query->where('boxmojo_id', $mojo_id);
			$query_result = $mojo_query->first();
			if ($query_result)
			{
				$info->old = $query_result;
			}
			
			$info->title = $crawler->filterXPath("//div[@id='body']//font[@face='Verdana']/b")->text();
			$info->release_date = new Carbon($crawler->filterXPath("//div[@id='body']//td[starts-with(.,'Release Date')]//b")->text());
			if (!$info->old)
			{
				$info->grosses = $crawler->filter('#body table[border="0"][class="chart-wide"] tr[bgcolor]:not([bgcolor="#dcdcdc"])')->each(function(Crawler $node) {
					$cols = $node->children();

					$myinfo = [
						'release_date'   => new Carbon($cols->eq(1)->text()),
						'domestic_total' => intval(str_replace(['$', ','], '', $cols->eq(8)->text())),
					];
					
					return $myinfo;
				});
			}
			
			$info->found = true;
			
			
			//Notification::success($title." ".$release_date." ".$boxmojo_id);


			//return Redirect::route('admin.movies');			

		}

		$this->layout->content = View::make('admin.addmovie',[
			'info' => $info
		]);
	}
	
	public function confirmMovie() {
		// Create the league
		$old_id = Input::get('old_id');
		if ($old_id) {
			$movie_query = Movie::query();
			$movie_query->where('id',$old_id);
			$movie = $movie_query->first();
		}
		else
		{
			$movie = new Movie(Input::only([
				'title', 'release_date', 'boxmojo_id'
			]));			
		}
		$movie->name = Input::get('title');
		$movie->release = Input::get('release_date');
		$movie->boxmojo_id = Input::get('mojo_id');
		
		$movie->save();
		
		$earnings = unserialize(Input::get('grosses'));
		$count = 0;
		if ($earnings)
		{
			$latest_earnings_id = 0;
			
			foreach($earnings as $gross) { 
				$earnings = new MovieEarning([
					'movie_id' => $movie->id,
					'date'     => $gross['release_date'],
					'domestic' => $gross['domestic_total']
				]);
				$earnings->save();
				$latest_earnings_id = $earnings->id;
				$count += 1;
			}
			if($latest_earnings_id != 0) {
				$movie->latest_earnings_id = $latest_earnings_id;
				$movie->save();
			}			
		}
		
		
		Notification::success("Successfully ".($old_id ? "updated " : "added ").$movie->name." with ".$count." day(s) of earnings");

		return Redirect::route('admin.addMovie');

	}
	
	
} 

1		<?php
2
3		//namespace Admin;
4
5		use Illuminate\Support\Facades\Input;
		0 ignored issues – show Bug introduced 2016-09-19 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Input`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
6		use Krucas\Notification\Facades\Notification;
7		use Illuminate\Support\Facades\Redirect;
		0 ignored issues – show Bug introduced 2016-09-19 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Redirect`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
8		use Carbon\Carbon;
9		use Goutte\Client;
10		use Symfony\Component\DomCrawler\Crawler;
11		class AdminController extends \AdminBaseController {
		0 ignored issues – show Coding Style Compatibility introduced 2016-09-19 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
12
13		/**
14		* Admin Homepage
15		*/
16	1	public function index() {
17		$stats = [
18	1	'users' => User::count(),
19	1	'leagues' => League::count(),
20	1	'movies' => Movie::count(),
21	1	];
22
23
24	1	$this->layout->title = 'Admin';
25	1	$this->layout->content = View::make('admin.index', compact('stats'));
26	1	}
27
28		public function movies() {
29		$movies_query = Movie::query();
30		$movies_query->orderBy('release', 'desc');
31		$movies_query->select('movies.*');
32		$movies = $movies_query->paginate(50);
33		$this->layout->title = 'Movies';
34		$this->layout->content = View::make('admin.movies',compact('movies'));
35		}
36		public function addMovie() {
37		$mojo_id = str_replace(".htm",'',Input::get('movie'));
38		$info = new stdClass();
39		$info->found = false;
40		$info->mojo_id = $mojo_id;
41		$info->old = null;
42		$info->grosses = null;
43		if ($mojo_id != '')
44		{
45		$client = new Client();
46		$crawler = $client->request('GET', 'http://www.boxofficemojo.com/movies/?page=daily&view=chart&id='.$mojo_id.'.htm', [], [], [
47		'HTTP_USER_AGENT' => "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0"
48		]);
49		$mojo_query = Movie::query();
50		$mojo_query->where('boxmojo_id', $mojo_id);
51		$query_result = $mojo_query->first();
52		if ($query_result)
53		{
54		$info->old = $query_result;
55		}
56
57		$info->title = $crawler->filterXPath("//div[@id='body']//font[@face='Verdana']/b")->text();
58		$info->release_date = new Carbon($crawler->filterXPath("//div[@id='body']//td[starts-with(.,'Release Date')]//b")->text());
59		if (!$info->old)
60		{
61		$info->grosses = $crawler->filter('#body table[border="0"][class="chart-wide"] tr[bgcolor]:not([bgcolor="#dcdcdc"])')->each(function(Crawler $node) {
62		$cols = $node->children();
63
64		$myinfo = [
65		'release_date' => new Carbon($cols->eq(1)->text()),
66		'domestic_total' => intval(str_replace(['$', ','], '', $cols->eq(8)->text())),
67		];
68
69		return $myinfo;
70		});
71		}
72
73		$info->found = true;
74
75
76		//Notification::success($title." ".$release_date." ".$boxmojo_id);
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-09-19 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
77
78		//return Redirect::route('admin.movies');
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-09-19 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
79		}
80
81		$this->layout->content = View::make('admin.addmovie',[
82		'info' => $info
83		]);
84		}
85
86		public function confirmMovie() {
87		// Create the league
88		$old_id = Input::get('old_id');
89		if ($old_id) {
90		$movie_query = Movie::query();
91		$movie_query->where('id',$old_id);
92		$movie = $movie_query->first();
93		}
94		else
95		{
96		$movie = new Movie(Input::only([
97		'title', 'release_date', 'boxmojo_id'
98		]));
99		}
100		$movie->name = Input::get('title');
101		$movie->release = Input::get('release_date');
102		$movie->boxmojo_id = Input::get('mojo_id');
103
104		$movie->save();
105
106		$earnings = unserialize(Input::get('grosses'));
107		$count = 0;
108		if ($earnings)
109		{
110		$latest_earnings_id = 0;
111
112		foreach($earnings as $gross) {
113		$earnings = new MovieEarning([
114		'movie_id' => $movie->id,
115		'date' => $gross['release_date'],
116		'domestic' => $gross['domestic_total']
117		]);
118		$earnings->save();
119		$latest_earnings_id = $earnings->id;
120		$count += 1;
121		}
122		if($latest_earnings_id != 0) {
123		$movie->latest_earnings_id = $latest_earnings_id;
124		$movie->save();
125		}
126		}
127
128
129		Notification::success("Successfully ".($old_id ? "updated " : "added ").$movie->name." with ".$count." day(s) of earnings");
130
131		return Redirect::route('admin.addMovie');
132
133		}
134
135
136		}

t2t2 / draft

Issues (103)

Security Analysis not enabled

app/controllers/AdminController.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like